New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MGMT-16151: allow CORS OPTIONS for s3 presigned url #5674
MGMT-16151: allow CORS OPTIONS for s3 presigned url #5674
Conversation
Signed-off-by: Riccardo piccoli <rpiccoli@redhat.com>
@rccrdpccl: This pull request references MGMT-16151 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adriengentil, rccrdpccl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5674 +/- ##
=======================================
Coverage 67.76% 67.77%
=======================================
Files 234 234
Lines 34444 34445 +1
=======================================
+ Hits 23342 23345 +3
Misses 9027 9027
+ Partials 2075 2073 -2
|
@rccrdpccl: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Allow OPTIONS method, as browsers check CORS with OPTIONS method.
List all the issues related to this PR
What environments does this code impact?
How was this code tested?
Checklist
docs
, README, etc)Reviewers Checklist