NO-JIRA: Enable skip mco reboot functionality only if openshift version is 4.15 and higher #5680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ori-amizur: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
jira/valid-reference
openshift-ci
bot
added
the
size/M
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ori-amizur The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5680 +/- ##
=======================================
Coverage 67.75% 67.76%
=======================================
Files 234 234
Lines 34445 34468 +23
=======================================
+ Hits 23338 23357 +19
- Misses 9030 9035 +5
+ Partials 2077 2076 -1
|
tsorya
reviewed
Nov 8, 2023
| @@ -24,6 +24,8 @@ import ( | |||
| "gorm.io/gorm" | |||
| ) | |||
|
|
|||
| const baseVersionForSkipMcoReboot = "4.15.0" | |||
There was a problem hiding this comment.
We have feature list per version maybe better to add it there?
There was a problem hiding this comment.
featuresupport package i think
ori-amizur
force-pushed
the
skip-mco-reboot-version
branch
from
1535cec
to
77c498b
Compare
|
/test ? |
|
@gamli75: The following commands are available to trigger required jobs:
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test e2e-metal-assisted-4-15 |
|
@gamli75: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/pull-ci-openshift-assisted-test-infra-master-e2e-metal-assisted-4-15 |
|
pull-ci-openshift-assisted-test-infra-master-e2e-metal-assisted-4-15 |
ori-amizur
force-pushed
the
skip-mco-reboot-version
branch
from
77c498b
to
6aaef89
Compare
openshift-ci
bot
added
the
api-review
…on is 4.15 and higher
ori-amizur
force-pushed
the
skip-mco-reboot-version
branch
from
6aaef89
to
5b70021
Compare
|
/lgtm |
|
@tsorya @ori-amizur Do we want to wait for |
openshift-merge-bot
bot
merged commit dab23bb
into
openshift:master
14 of 15 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List all the issues related to this PR
What environments does this code impact?
How was this code tested?
Checklist
docs, README, etc)Reviewers Checklist
/cc @tsorya