Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-ISSUE: dependabot optimize #5697

Merged
merged 2 commits into from Nov 16, 2023

Conversation

eifrach
Copy link
Contributor

@eifrach eifrach commented Nov 15, 2023

Optimizting dependabot,
major changes cause test not to pass, thus spliting to different groups

  1. minor group which conatins bug fixes and security
  2. major group which may need some fixes in code / lint to make test pass

List all the issues related to this PR

  • New Feature
  • Enhancement
  • Bug fix
  • Tests
  • Documentation
  • [ X] CI/CD

What environments does this code impact?

  • Automation (CI, tools, etc)
  • Cloud
  • Operator Managed Deployments
  • [] None

How was this code tested?

  • assisted-test-infra environment
  • dev-scripts environment
  • Reviewer's test appreciated
  • Waiting for CI to do a full test run
  • Manual (Elaborate on how it was tested)
  • No tests needed

Checklist

  • Title and description added to both, commit and PR.
  • Relevant issues have been associated (see CONTRIBUTING guide)
  • This change does not require a documentation update (docstring, docs, README, etc)
  • Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

  • Are the title and description (in both PR and commit) meaningful and clear?
  • Is there a bug required (and linked) for this change?
  • Should this PR be backported?

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 15, 2023
@eifrach eifrach changed the title Dependabot optimize NO-ISSUE: dependabot optimize Nov 15, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 15, 2023
@openshift-ci-robot
Copy link

@eifrach: This pull request explicitly references no jira issue.

In response to this:

Optimizting dependabot,
major changes cause test not to pass, thus spliting to different groups

  1. minor group which conatins bug fixes and security
  2. major group which may need some fixes in code / lint to make test pass

List all the issues related to this PR

  • New Feature
  • Enhancement
  • Bug fix
  • Tests
  • Documentation
  • [ X] CI/CD

What environments does this code impact?

  • Automation (CI, tools, etc)
  • Cloud
  • Operator Managed Deployments
  • [] None

How was this code tested?

  • assisted-test-infra environment
  • dev-scripts environment
  • Reviewer's test appreciated
  • Waiting for CI to do a full test run
  • Manual (Elaborate on how it was tested)
  • No tests needed

Checklist

  • Title and description added to both, commit and PR.
  • Relevant issues have been associated (see CONTRIBUTING guide)
  • This change does not require a documentation update (docstring, docs, README, etc)
  • Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

  • Are the title and description (in both PR and commit) meaningful and clear?
  • Is there a bug required (and linked) for this change?
  • Should this PR be backported?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rccrdpccl
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 15, 2023
Copy link

openshift-ci bot commented Nov 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eifrach, rccrdpccl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 15, 2023
Copy link

codecov bot commented Nov 15, 2023

Codecov Report

Merging #5697 (da7a322) into master (139ee0b) will decrease coverage by 0.06%.
Report is 5 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5697      +/-   ##
==========================================
- Coverage   67.78%   67.72%   -0.06%     
==========================================
  Files         234      234              
  Lines       34475    34632     +157     
==========================================
+ Hits        23370    23456      +86     
- Misses       9032     9104      +72     
+ Partials     2073     2072       -1     

see 8 files with indirect coverage changes

@eifrach
Copy link
Contributor Author

eifrach commented Nov 15, 2023

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Nov 15, 2023
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 0f613f8 and 2 for PR HEAD da7a322 in total

@eifrach
Copy link
Contributor Author

eifrach commented Nov 15, 2023

/test ?

Copy link

openshift-ci bot commented Nov 15, 2023

@eifrach: The following commands are available to trigger required jobs:

  • /test e2e-agent-compact-ipv4
  • /test edge-assisted-operator-catalog-publish-verify
  • /test edge-ci-index
  • /test edge-e2e-ai-operator-ztp
  • /test edge-e2e-ai-operator-ztp-sno-day2-workers
  • /test edge-e2e-ai-operator-ztp-sno-day2-workers-late-binding
  • /test edge-e2e-metal-assisted
  • /test edge-e2e-metal-assisted-4-10
  • /test edge-e2e-metal-assisted-4-11
  • /test edge-e2e-metal-assisted-4-12
  • /test edge-e2e-metal-assisted-4-9
  • /test edge-e2e-metal-assisted-cnv
  • /test edge-e2e-metal-assisted-lvm
  • /test edge-e2e-metal-assisted-odf
  • /test edge-images
  • /test edge-lint
  • /test edge-subsystem-aws
  • /test edge-subsystem-kubeapi-aws
  • /test edge-unit-test
  • /test edge-verify-generated-code
  • /test images
  • /test mce-images

The following commands are available to trigger optional jobs:

  • /test e2e-agent-ha-dualstack
  • /test e2e-agent-sno-ipv6
  • /test edge-e2e-ai-operator-ztp-3masters
  • /test edge-e2e-ai-operator-ztp-capi
  • /test edge-e2e-ai-operator-ztp-compact-day2-masters
  • /test edge-e2e-ai-operator-ztp-compact-day2-workers
  • /test edge-e2e-ai-operator-ztp-disconnected
  • /test edge-e2e-ai-operator-ztp-hypershift-zero-nodes
  • /test edge-e2e-ai-operator-ztp-multiarch-3masters-ocp-411
  • /test edge-e2e-ai-operator-ztp-multiarch-sno-ocp-411
  • /test edge-e2e-ai-operator-ztp-node-labels
  • /test edge-e2e-ai-operator-ztp-sno-day2-masters
  • /test edge-e2e-ai-operator-ztp-sno-day2-workers-ignitionoverride
  • /test edge-e2e-metal-assisted-4-13
  • /test edge-e2e-metal-assisted-4-14
  • /test edge-e2e-metal-assisted-4-15
  • /test edge-e2e-metal-assisted-bond
  • /test edge-e2e-metal-assisted-day2
  • /test edge-e2e-metal-assisted-day2-arm-workers
  • /test edge-e2e-metal-assisted-day2-single-node
  • /test edge-e2e-metal-assisted-ipv4v6
  • /test edge-e2e-metal-assisted-ipv6
  • /test edge-e2e-metal-assisted-kube-api-late-binding-single-node
  • /test edge-e2e-metal-assisted-kube-api-late-unbinding-ipv4-single-node
  • /test edge-e2e-metal-assisted-kube-api-net-suite
  • /test edge-e2e-metal-assisted-mce
  • /test edge-e2e-metal-assisted-mce-4-10
  • /test edge-e2e-metal-assisted-mce-sno
  • /test edge-e2e-metal-assisted-metallb
  • /test edge-e2e-metal-assisted-none
  • /test edge-e2e-metal-assisted-onprem
  • /test edge-e2e-metal-assisted-single-node
  • /test edge-e2e-metal-assisted-static-ip-suite
  • /test edge-e2e-metal-assisted-tang
  • /test edge-e2e-metal-assisted-tpmv2
  • /test edge-e2e-metal-assisted-upgrade-agent
  • /test edge-e2e-nutanix-assisted
  • /test edge-e2e-nutanix-assisted-2workers
  • /test edge-e2e-nutanix-assisted-4-14
  • /test edge-e2e-oci-assisted
  • /test edge-e2e-oci-assisted-4-14
  • /test edge-e2e-vsphere-assisted
  • /test edge-e2e-vsphere-assisted-4-12
  • /test edge-e2e-vsphere-assisted-4-13
  • /test edge-e2e-vsphere-assisted-4-14
  • /test edge-e2e-vsphere-assisted-umn
  • /test edge-push-pr-image
  • /test push-pr-image

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-assisted-service-master-e2e-agent-compact-ipv4
  • pull-ci-openshift-assisted-service-master-edge-ci-index
  • pull-ci-openshift-assisted-service-master-edge-images
  • pull-ci-openshift-assisted-service-master-edge-lint
  • pull-ci-openshift-assisted-service-master-edge-unit-test
  • pull-ci-openshift-assisted-service-master-edge-verify-generated-code
  • pull-ci-openshift-assisted-service-master-images
  • pull-ci-openshift-assisted-service-master-mce-images

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eifrach
Copy link
Contributor Author

eifrach commented Nov 16, 2023

/retest

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 7ec01c3 and 1 for PR HEAD da7a322 in total

@eifrach
Copy link
Contributor Author

eifrach commented Nov 16, 2023

/override ci/prow/e2e-agent-compact-ipv4

Copy link

openshift-ci bot commented Nov 16, 2023

@eifrach: eifrach unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:openshift: openshift-release-oversight.

In response to this:

/override ci/prow/e2e-agent-compact-ipv4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

openshift-ci bot commented Nov 16, 2023

@eifrach: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit a6d4170 into openshift:master Nov 16, 2023
10 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-agent-installer-api-server-container-v4.15.0-202311161308.p0.ga6d4170.assembly.stream for distgit ose-agent-installer-api-server.
All builds following this will include this PR.

danmanor pushed a commit to danmanor/assisted-service that referenced this pull request Nov 19, 2023
* NO-ISSUE: Dependabot optimize

* NO-ISSUE: dependabot optimize

before adding my tests

MGMT-12996: Part1: Add a utility that updates the current OCP releases in the DB according to a configuration file named RELEASE_SOURCES
danmanor pushed a commit to danmanor/assisted-service that referenced this pull request Nov 19, 2023
* NO-ISSUE: Dependabot optimize

* NO-ISSUE: dependabot optimize

before adding my tests

MGMT-12996: Part1: Add a utility that updates the current OCP releases in the DB according to a configuration file named RELEASE_SOURCES
danmanor pushed a commit to danmanor/assisted-service that referenced this pull request Nov 19, 2023
* NO-ISSUE: Dependabot optimize

* NO-ISSUE: dependabot optimize

before adding my tests

MGMT-12996: Part1: Add a utility that updates the current OCP releases in the DB according to a configuration file named RELEASE_SOURCES
danmanor pushed a commit to danmanor/assisted-service that referenced this pull request Nov 19, 2023
* NO-ISSUE: Dependabot optimize

* NO-ISSUE: dependabot optimize

before adding my tests

MGMT-12996: Part1: Add a utility that updates the current OCP releases in the DB according to a configuration file named RELEASE_SOURCES
danmanor pushed a commit to danmanor/assisted-service that referenced this pull request Nov 19, 2023
* NO-ISSUE: Dependabot optimize

* NO-ISSUE: dependabot optimize

before adding my tests

MGMT-12996: Part1: Add a utility that updates the current OCP releases in the DB according to a configuration file named RELEASE_SOURCES
danmanor pushed a commit to danmanor/assisted-service that referenced this pull request Nov 19, 2023
* NO-ISSUE: Dependabot optimize

* NO-ISSUE: dependabot optimize

before adding my tests

MGMT-12996: Part1: Add a utility that updates the current OCP releases in the DB according to a configuration file named RELEASE_SOURCES
danmanor pushed a commit to danmanor/assisted-service that referenced this pull request Nov 19, 2023
* NO-ISSUE: Dependabot optimize

* NO-ISSUE: dependabot optimize

before adding my tests

MGMT-12996: Part1: Add a utility that updates the current OCP releases in the DB according to a configuration file named RELEASE_SOURCES
danmanor pushed a commit to danmanor/assisted-service that referenced this pull request Nov 28, 2023
* NO-ISSUE: Dependabot optimize

* NO-ISSUE: dependabot optimize

before adding my tests

MGMT-12996: Part1: Add a utility that updates the current OCP releases in the DB according to a configuration file named RELEASE_SOURCES
danmanor pushed a commit to danmanor/assisted-service that referenced this pull request Nov 28, 2023
* NO-ISSUE: Dependabot optimize

* NO-ISSUE: dependabot optimize

before adding my tests

MGMT-12996: Part1: Add a utility that updates the current OCP releases in the DB according to a configuration file named RELEASE_SOURCES
danmanor pushed a commit to danmanor/assisted-service that referenced this pull request Nov 28, 2023
* NO-ISSUE: Dependabot optimize

* NO-ISSUE: dependabot optimize

before adding my tests

MGMT-12996: Part1: Add a utility that updates the current OCP releases in the DB according to a configuration file named RELEASE_SOURCES
danmanor pushed a commit to danmanor/assisted-service that referenced this pull request Nov 28, 2023
* NO-ISSUE: Dependabot optimize

* NO-ISSUE: dependabot optimize

before adding my tests

MGMT-12996: Part1: Add a utility that updates the current OCP releases in the DB according to a configuration file named RELEASE_SOURCES
danmanor pushed a commit to danmanor/assisted-service that referenced this pull request Nov 28, 2023
* NO-ISSUE: Dependabot optimize

* NO-ISSUE: dependabot optimize

before adding my tests

MGMT-12996: Part1: Add a utility that updates the current OCP releases in the DB according to a configuration file named RELEASE_SOURCES
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants