Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HOSTEDCP-999: Minor fixes for disconnected CAPI CI #5713

Merged

Conversation

CrystalChun
Copy link
Contributor

@CrystalChun CrystalChun commented Nov 17, 2023

https://issues.redhat.com/browse/HOSTEDCP-999
After the initial changes were merged and rehearsed, small bugs were found. This PR attempts to fix them.

  1. Corrected pull secret file passed into hypershift command.
  2. Added service-cidr flag for ipv6

List all the issues related to this PR

  • New Feature
  • Enhancement
  • Bug fix
  • Tests
  • Documentation
  • CI/CD

What environments does this code impact?

  • Automation (CI, tools, etc)
  • Cloud
  • Operator Managed Deployments
  • None

How was this code tested?

  • assisted-test-infra environment
  • dev-scripts environment
  • Reviewer's test appreciated
  • Waiting for CI to do a full test run
  • Manual (Elaborate on how it was tested)
  • No tests needed

Checklist

  • Title and description added to both, commit and PR.
  • Relevant issues have been associated (see CONTRIBUTING guide)
  • This change does not require a documentation update (docstring, docs, README, etc)
  • Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

  • Are the title and description (in both PR and commit) meaningful and clear?
  • Is there a bug required (and linked) for this change?
  • Should this PR be backported?

/cc @avishayt @filanov

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 17, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 17, 2023

@CrystalChun: This pull request references HOSTEDCP-999 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

https://issues.redhat.com/browse/HOSTEDCP-999
After the initial changes were merged and rehearsed, small bugs were found. This PR attempts to fix them.

  1. Corrected pull secret file passed into hypershift command.

List all the issues related to this PR

  • New Feature
  • Enhancement
  • Bug fix
  • Tests
  • Documentation
  • CI/CD

What environments does this code impact?

  • Automation (CI, tools, etc)
  • Cloud
  • Operator Managed Deployments
  • None

How was this code tested?

  • assisted-test-infra environment
  • dev-scripts environment
  • Reviewer's test appreciated
  • Waiting for CI to do a full test run
  • Manual (Elaborate on how it was tested)
  • No tests needed

Checklist

  • Title and description added to both, commit and PR.
  • Relevant issues have been associated (see CONTRIBUTING guide)
  • This change does not require a documentation update (docstring, docs, README, etc)
  • Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

  • Are the title and description (in both PR and commit) meaningful and clear?
  • Is there a bug required (and linked) for this change?
  • Should this PR be backported?

/cc @avishayt @filanov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 17, 2023
Copy link

openshift-ci bot commented Nov 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CrystalChun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 17, 2023
Copy link

codecov bot commented Nov 17, 2023

Codecov Report

Merging #5713 (6f9dac9) into master (a97379e) will increase coverage by 0.02%.
Report is 4 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5713      +/-   ##
==========================================
+ Coverage   67.92%   67.95%   +0.02%     
==========================================
  Files         233      233              
  Lines       34395    34395              
==========================================
+ Hits        23363    23372       +9     
+ Misses       8957     8951       -6     
+ Partials     2075     2072       -3     

see 2 files with indirect coverage changes

@CrystalChun
Copy link
Contributor Author

/retest-required

https://issues.redhat.com/browse/HOSTEDCP-999
After the initial changes were merged and rehearsed,
small bugs were found. This PR attempts to fix them.

1. Corrected pull secret file passed into hypershift command.
2. Added service-cidr flag for ipv6
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 21, 2023

@CrystalChun: This pull request references HOSTEDCP-999 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

https://issues.redhat.com/browse/HOSTEDCP-999
After the initial changes were merged and rehearsed, small bugs were found. This PR attempts to fix them.

  1. Corrected pull secret file passed into hypershift command.
  2. Added service-cidr flag for ipv6

List all the issues related to this PR

  • New Feature
  • Enhancement
  • Bug fix
  • Tests
  • Documentation
  • CI/CD

What environments does this code impact?

  • Automation (CI, tools, etc)
  • Cloud
  • Operator Managed Deployments
  • None

How was this code tested?

  • assisted-test-infra environment
  • dev-scripts environment
  • Reviewer's test appreciated
  • Waiting for CI to do a full test run
  • Manual (Elaborate on how it was tested)
  • No tests needed

Checklist

  • Title and description added to both, commit and PR.
  • Relevant issues have been associated (see CONTRIBUTING guide)
  • This change does not require a documentation update (docstring, docs, README, etc)
  • Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

  • Are the title and description (in both PR and commit) meaningful and clear?
  • Is there a bug required (and linked) for this change?
  • Should this PR be backported?

/cc @avishayt @filanov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@avishayt
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 21, 2023
@openshift-merge-bot openshift-merge-bot bot merged commit d4caa9d into openshift:master Nov 21, 2023
14 of 17 checks passed
Copy link

openshift-ci bot commented Nov 21, 2023

@CrystalChun: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/edge-e2e-ai-operator-ztp-3masters 6f9dac9 link false /test edge-e2e-ai-operator-ztp-3masters

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

CrystalChun added a commit to CrystalChun/assisted-service that referenced this pull request Nov 21, 2023
https://issues.redhat.com/browse/HOSTEDCP-999
Initial PRs missed adding service-cidr flag for hypershift
cluster creation for ipv6.
See previous, which added it only for dual-stack
openshift#5713
openshift-merge-bot bot pushed a commit that referenced this pull request Nov 23, 2023
https://issues.redhat.com/browse/HOSTEDCP-999
Initial PRs missed adding service-cidr flag for hypershift
cluster creation for ipv6.
See previous, which added it only for dual-stack
#5713
@CrystalChun CrystalChun deleted the disconnected-capi-ci branch January 29, 2024 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants