New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HOSTEDCP-999: Minor fixes for disconnected CAPI CI #5713
HOSTEDCP-999: Minor fixes for disconnected CAPI CI #5713
Conversation
@CrystalChun: This pull request references HOSTEDCP-999 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CrystalChun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5713 +/- ##
==========================================
+ Coverage 67.92% 67.95% +0.02%
==========================================
Files 233 233
Lines 34395 34395
==========================================
+ Hits 23363 23372 +9
+ Misses 8957 8951 -6
+ Partials 2075 2072 -3 |
c6b14c3
to
cf07b33
Compare
/retest-required |
cf07b33
to
877161d
Compare
https://issues.redhat.com/browse/HOSTEDCP-999 After the initial changes were merged and rehearsed, small bugs were found. This PR attempts to fix them. 1. Corrected pull secret file passed into hypershift command. 2. Added service-cidr flag for ipv6
877161d
to
6f9dac9
Compare
@CrystalChun: This pull request references HOSTEDCP-999 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
d4caa9d
into
openshift:master
@CrystalChun: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
https://issues.redhat.com/browse/HOSTEDCP-999 Initial PRs missed adding service-cidr flag for hypershift cluster creation for ipv6. See previous, which added it only for dual-stack openshift#5713
https://issues.redhat.com/browse/HOSTEDCP-999 Initial PRs missed adding service-cidr flag for hypershift cluster creation for ipv6. See previous, which added it only for dual-stack #5713
https://issues.redhat.com/browse/HOSTEDCP-999
After the initial changes were merged and rehearsed, small bugs were found. This PR attempts to fix them.
List all the issues related to this PR
What environments does this code impact?
How was this code tested?
Checklist
docs
, README, etc)Reviewers Checklist
/cc @avishayt @filanov