MGMT-15425: Change chosen MCE release to match OCP version #5716
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@danmanor: This pull request references MGMT-15425 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
|
/test all |
openshift-ci
bot
added
size/L
|
/test |
|
@danmanor: The
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5716 +/- ##
==========================================
+ Coverage 67.94% 67.99% +0.05%
==========================================
Files 233 235 +2
Lines 34395 34716 +321
==========================================
+ Hits 23370 23606 +236
- Misses 8952 9018 +66
- Partials 2073 2092 +19
|
|
@danmanor: This pull request references MGMT-15425 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
@danmanor: This pull request references MGMT-15425 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
danmanor
force-pushed
the
add-ocpmce
branch
2 times, most recently
from
beeb49f
to
be54451
Compare
|
@danmanor: This pull request references MGMT-15425 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@danmanor: This pull request references MGMT-15425 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@danmanor: This pull request references MGMT-15425 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
internal/common/version.go
Outdated
| @@ -57,3 +58,15 @@ func BaseVersionEqual(version1, versionMayEqual string) (bool, error) { | |||
|
|
|||
| return v1[0] == v2[0] && v1[1] == v2[1], nil | |||
| } | |||
|
|
|||
| func GetBaseVersion(version string) (*string, error) { | |||
There was a problem hiding this comment.
it looks like a duplicate of the other code in this file - you can use this method in other methods.
if you don't want to replace all the code - at least add tests to this method
There was a problem hiding this comment.
Initially I replaced the code and saw it doesn't actually saves code due to error handling, so I preferred leaving it like this. I will add tests for this one as well.
|
@adriengentil apparently mce-2.4 is no longer available - https://access.redhat.com/documentation/en-us/red_hat_advanced_cluster_management_for_kubernetes/2.7/html/clusters/cluster_mce_overview#mce-release-notes |
|
I will change the config accordingly and retest |
|
@danmanor: This pull request references MGMT-15425 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test edge-e2e-metal-assisted-mce-4-11 edge-e2e-metal-assisted-mce-4-12 edge-e2e-metal-assisted-mce-4-13 edge-e2e-metal-assisted-mce-4-14 edge-e2e-metal-assisted-mce-4-15 |
2.4.1 will be available on Wednesday - see: https://redhat-internal.slack.com/archives/CUPJTHQ5P/p1701108232895609?thread_ts=1700987983.925569&cid=CUPJTHQ5P |
|
@gamli75 I don't get the thread, I will hold and reconfigure it until tomorrow. |
|
/hold |
|
/test edge-e2e-metal-assisted-ipv4v6 |
|
/test edge-e2e-metal-assisted-mce-4-11 edge-e2e-metal-assisted-mce-4-12 edge-e2e-metal-assisted-mce-4-13 edge-e2e-metal-assisted-mce-4-14 edge-e2e-metal-assisted-mce-4-15 |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adriengentil, danmanor, eifrach The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test e2e-agent-compact-ipv4 |
|
/test edge-e2e-metal-assisted-day2 |
|
/test e2e-agent-compact-ipv4 |
|
/test edge-e2e-metal-assisted-day2 |
|
@danmanor: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/test e2e-agent-compact-ipv4 |
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
openshift-merge-bot
bot
merged commit 01b8b23
into
openshift:master
|
[ART PR BUILD NOTIFIER] This PR has been included in build ose-agent-installer-api-server-container-v4.15.0-202312040732.p0.g01b8b23.assembly.stream for distgit ose-agent-installer-api-server. |
Currently
MCEversion is hard coded in our code and set to 2.3 (from stable channel). EachOCPrelease matches at least one (mostly exactly one)MCErelease, hence when installing a cluster withOCPrelease that doesn't matchMCE2.3, we will get an error. To solve this I added a new configuration file which will be updated periodically manually or by an automation that soon will be created. Assisted-service takes the rightMCErelease according to the cluster'sOCPrelease and this configuration.For reference:
List all the issues related to this PR
What environments does this code impact?
How was this code tested?
Checklist
docs, README, etc)Reviewers Checklist