HOSTEDCP-999: Fix incorrect ICSP for CAPI CI #5747
Conversation
https://issues.redhat.com/browse/HOSTEDCP-999 Previously, the ICSP pointed to the incorrect mirror registry URL for OCP. OCP release was already mirrored in deploy/operator/deploy.sh and this change now uses that mirrored registry URL for the ICSP.
openshift-ci-robot
added
the
jira/valid-reference
|
@CrystalChun: This pull request references HOSTEDCP-999 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
size/S
| if [ ! -z "$PROVIDER_IMAGE" ] | ||
| then | ||
| export PROVIDER_LOCAL_IMAGE="${LOCAL_REGISTRY}/localimages/cluster-api-provider-agent:latest" | ||
| oc image mirror -a "${PULL_SECRET_FILE}" "${PROVIDER_IMAGE}" "${PROVIDER_LOCAL_IMAGE}" | ||
| export PROVIDER_IMAGE="${PROVIDER_LOCAL_IMAGE}" | ||
| fi | ||
| # 6. ImageContentPolicy for local registry | ||
| # 5. ImageContentPolicy for local mirror registry (prerequisite is the openshift release is mirrored to the local registry) | ||
| export OCP_MIRROR_REGISTRY="${LOCAL_REGISTRY}/$(get_image_repository_only ${ASSISTED_OPENSHIFT_INSTALL_RELEASE_IMAGE})" |
There was a problem hiding this comment.
OCP release is mirrored here
openshift-ci
bot
added
the
approved
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5747 +/- ##
==========================================
+ Coverage 67.98% 69.31% +1.33%
==========================================
Files 234 235 +1
Lines 34353 36390 +2037
==========================================
+ Hits 23355 25225 +1870
- Misses 8925 9020 +95
- Partials 2073 2145 +72 |
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CrystalChun, filanov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Red Hat Trusted App Pipeline/assisted-service-q2vh-on-pull-request |
|
@CrystalChun: The
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
1 similar comment
|
/retest |
|
@CrystalChun: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
openshift-merge-bot
bot
merged commit ef5f296
into
openshift:master
|
[ART PR BUILD NOTIFIER] This PR has been included in build ose-agent-installer-api-server-container-v4.15.0-202311300249.p0.gef5f296.assembly.stream for distgit ose-agent-installer-api-server. |
https://issues.redhat.com/browse/HOSTEDCP-999
Previously, the ICSP pointed to the incorrect mirror registry URL for OCP. OCP release was already mirrored in deploy/operator/deploy.sh and this change now uses that mirrored registry URL for the ICSP.
List all the issues related to this PR
What environments does this code impact?
How was this code tested?
Checklist
docs, README, etc)Reviewers Checklist
/cc @filanov @avishayt