OCPBUGS-24319: fix: allow LVMS to be installed for MultiNode / HA Configurations in OpenShift >=4.15.0 #5757
Conversation
openshift-ci-robot
added
jira/valid-reference
|
@jakobmoellerdev: This pull request references Jira Issue OCPBUGS-24319, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@jakobmoellerdev: This pull request references Jira Issue OCPBUGS-24319, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
size/M
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5757 +/- ##
==========================================
- Coverage 67.88% 67.88% -0.01%
==========================================
Files 234 235 +1
Lines 34508 34552 +44
==========================================
+ Hits 23426 23455 +29
- Misses 9003 9010 +7
- Partials 2079 2087 +8
|
|
/test e2e-agent-compact-ipv4 |
|
/test ? |
|
@eifrach: The following commands are available to trigger required jobs:
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@eifrach anything else necessary here? |
added a small nit, but looks good to me |
jakobmoellerdev
force-pushed
the
OCPBUGS-24319-mno-lvms
branch
from
7f5808e
to
8fbf100
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eifrach, jakobmoellerdev The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/test edge-e2e-metal-assisted-lvm |
|
@jakobmoellerdev: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@jakobmoellerdev: Jira Issue OCPBUGS-24319: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-24319 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[ART PR BUILD NOTIFIER] This PR has been included in build ose-agent-installer-api-server-container-v4.16.0-202312060031.p0.g10f9260.assembly.stream for distgit ose-agent-installer-api-server. |
With https://issues.redhat.com/browse/OCPEDGE-64 LVMS will officially support HA configurations out of the box. Currently the assisted-service logic still blocks these installations. I added a flag for a minimum HA version support for 4.15.0 and a test case so that we can make sure this is supported in the future with assisted-service as well and not blocked.
List all the issues related to this PR
What environments does this code impact?
How was this code tested?
Checklist
docs, README, etc)Reviewers Checklist