MGMT-16250: Propagate OS_IMAGES var in operator deploy #5762
Conversation
|
Skipping CI for Draft Pull Request. |
openshift-ci
bot
added
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danielerez The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/test edge-e2e-metal-assisted-kube-api-late-binding-single-node |
|
/retest |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5762 +/- ##
==========================================
- Coverage 67.89% 67.89% -0.01%
==========================================
Files 234 235 +1
Lines 34503 34545 +42
==========================================
+ Hits 23426 23454 +28
- Misses 9000 9007 +7
- Partials 2077 2084 +7 |
danielerez
force-pushed
the
propagate_os_images
branch
from
07ff048
to
b72ad38
Compare
openshift-ci
bot
added
size/S
|
/test edge-e2e-metal-assisted-kube-api-late-binding-single-node |
|
/test all |
|
/test ? |
|
@danielerez: The following commands are available to trigger required jobs:
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
|
/cc @paul-maidment |
danielerez
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
| if [ "${DISCONNECTED}" = "true" ]; then | ||
| echo "Adding osImages to AgentServiceConfig because we're in disconnected mode" | ||
| wait_for_object_amount agentserviceconfigs/agent 1 10 ${ASSISTED_NAMESPACE} | ||
| echo "Adding osImages to AgentServiceConfig (to support filterred list on assisted-image-service)" |
There was a problem hiding this comment.
Small typo here, should read filtered
When deploying the operator, OS_IMAGES env var should propagate if already defined. This should solve e2e failures of jobs that use superfluous storage. I.e. download all OS images, instead of the ones in the list filtered by test-infra.
danielerez
force-pushed
the
propagate_os_images
branch
from
b72ad38
to
843c98f
Compare
|
/test edge-e2e-metal-assisted-kube-api-late-binding-single-node |
|
/lgtm |
|
please retitle the PR to https://issues.redhat.com/browse/MGMT-16250 |
danielerez
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@danielerez: This pull request references MGMT-16250 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-merge-bot
bot
merged commit bd844f3
into
openshift:master
|
@danielerez: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
| @@ -48,4 +48,4 @@ fi | |||
|
|
|||
| export ASSISTED_OPENSHIFT_VERSION="${ASSISTED_OPENSHIFT_VERSION:-openshift-v${VERSION}}" | |||
| export ASSISTED_OPENSHIFT_INSTALL_RELEASE_IMAGE="${ASSISTED_OPENSHIFT_INSTALL_RELEASE_IMAGE:-${RELEASE_IMAGE}}" | |||
| export OS_IMAGES=$(echo ${DEFAULT_OS_IMAGES} | jq -rc 'map(select((.openshift_version|split(".")|map(tonumber)) >= [4,8]))') | |||
| export OS_IMAGES="${OS_IMAGES:-$(echo ${DEFAULT_OS_IMAGES} | jq -rc 'map(select((.openshift_version|split(".")|map(tonumber)) >= [4,8]))')}" | |||
There was a problem hiding this comment.
4.8 is not relevant anymore so we can probably update that to support 4.12 and up.
@gamli75 what do you think?
There was a problem hiding this comment.
4.11 is still in maintenance mode, see: https://access.redhat.com/support/policy/updates/openshift but we can change it to 4.11
|
[ART PR BUILD NOTIFIER] This PR has been included in build ose-agent-installer-api-server-container-v4.15.0-202312041611.p0.gbd844f3.assembly.stream for distgit ose-agent-installer-api-server. |
When deploying the operator, OS_IMAGES env var should propagate if already defined.
This should solve e2e failures of jobs that use superfluous storage. I.e. download all OS images, instead of the ones in the list filtered by test-infra.
In addition, passing 'osImages' to AgentServiceConfig to propagate the filtered list to assisted-image-service.
List all the issues related to this PR
What environments does this code impact?
How was this code tested?
Checklist
docs, README, etc)Reviewers Checklist