New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NO-ISSUE: add build tags option #5768
NO-ISSUE: add build tags option #5768
Conversation
/cc @gamli75 |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5768 +/- ##
==========================================
+ Coverage 67.88% 67.91% +0.02%
==========================================
Files 235 235
Lines 34545 34555 +10
==========================================
+ Hits 23451 23467 +16
+ Misses 9008 9005 -3
+ Partials 2086 2083 -3 |
Makefile
Outdated
@@ -218,10 +220,10 @@ build-in-docker: | |||
|
|||
build-assisted-service: | |||
# We need the CGO_ENABLED for the go-sqlite library build. | |||
cd ./cmd && CGO_ENABLED=1 go build $(DEBUG_ARGS) -o $(BUILD_FOLDER)/assisted-service | |||
cd ./cmd && CGO_ENABLED=1 go build -o $(GO_BUILD_TAGS) $(DEBUG_ARGS) -o $(BUILD_FOLDER)/assisted-service |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
having two -o
flags means the first one is simply ignored.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fortunately you caught this one, total mistake I was meant to pass -tags
/hold |
Signed-off-by: Riccardo piccoli <rpiccoli@redhat.com>
b32847d
to
b7c2b42
Compare
/test edge-e2e-metal-assisted |
/retest |
/unhold |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adriengentil, gamli75, rccrdpccl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/jira refresh |
@rccrdpccl: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@rccrdpccl: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
[ART PR BUILD NOTIFIER] This PR has been included in build ose-agent-installer-api-server-container-v4.15.0-202312051331.p0.ga9532bc.assembly.stream for distgit ose-agent-installer-api-server. |
This would enable us to pass BUILD_TAGS from downstream build to produce, for instance, FIPS-enable artifacts
List all the issues related to this PR
What environments does this code impact?
How was this code tested?
Checklist
docs
, README, etc)Reviewers Checklist