MGMT-15886: Fix domain validation

[CrystalChun]

https://issues.redhat.com/browse/MGMT-15886
Modify domain validation to adhere to the RFC standard for domains https://datatracker.ietf.org/doc/html/rfc1034#section-3.5
Rules for labels:

1. start with a letter
2. end with a letter or digit
3. and have as interior characters only letters, digits, and hyphen

Domains contains either one label or multiple labels separated by a period.

Top level (base) domains must have at least two characters and cannot end in a dash.

List all the issues related to this PR

• New Feature
• Enhancement
• Bug fix
• Tests
• Documentation
• CI/CD

What environments does this code impact?

• Automation (CI, tools, etc)
• Cloud
• Operator Managed Deployments
• None

How was this code tested?

• assisted-test-infra environment
• dev-scripts environment
• Reviewer's test appreciated
• Waiting for CI to do a full test run
• Manual (Elaborate on how it was tested)
• No tests needed

Checklist

• Title and description added to both, commit and PR.
• Relevant issues have been associated (see CONTRIBUTING guide)
• This change does not require a documentation update (docstring, docs, README, etc)
• Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

/cc @ori-amizur @carbonin @filanov

[openshift-ci-robot]

@CrystalChun: This pull request references MGMT-15886 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

https://issues.redhat.com/browse/MGMT-15886
Modify domain validation to adhere to the RFC standard for domains https://datatracker.ietf.org/doc/html/rfc1034#section-3.5
Rules for labels:

1. start with a letter
2. end with a letter or digit
3. and have as interior characters only letters, digits, and hyphen

Domains contains either one label or multiple labels separated by a period.

Top level (base) domains must have at least two characters and cannot end in a dash.

List all the issues related to this PR

• New Feature
• Enhancement
• Bug fix
• Tests
• Documentation
• CI/CD

What environments does this code impact?

• Automation (CI, tools, etc)
• Cloud
• Operator Managed Deployments
• None

How was this code tested?

• assisted-test-infra environment
• dev-scripts environment
• Reviewer's test appreciated
• Waiting for CI to do a full test run
• Manual (Elaborate on how it was tested)
• No tests needed

Checklist

• Title and description added to both, commit and PR.
• Relevant issues have been associated (see CONTRIBUTING guide)
• This change does not require a documentation update (docstring, docs, README, etc)
• Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

/cc @ori-amizur @carbonin @filanov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[codecov]

Codecov Report

Merging #5801 (1d50506) into master (286c4af) will increase coverage by 1.17%.
Report is 8 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5801      +/-   ##
==========================================
+ Coverage   67.88%   69.05%   +1.17%     
==========================================
  Files         235      235              
  Lines       34552    36630    +2078     
==========================================
+ Hits        23454    25296    +1842     
- Misses       9010     9107      +97     
- Partials     2088     2227     +139     

Files	Coverage Δ
pkg/validations/validations.go	92.30% <ø> (ø)

... and 22 files with indirect coverage changes

[CrystalChun]

/retest-required

[openshift-ci]

@CrystalChun: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CrystalChun, filanov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [CrystalChun,filanov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-agent-installer-api-server-container-v4.16.0-202312171702.p0.gfd8eb19.assembly.stream for distgit ose-agent-installer-api-server.
All builds following this will include this PR.