New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MGMT-16420: enable latest lso for 4.15 ztp #5805
Conversation
@eifrach: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test ? |
@eifrach: The following commands are available to trigger required jobs:
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5805 +/- ##
==========================================
+ Coverage 67.88% 69.13% +1.24%
==========================================
Files 235 235
Lines 34552 36726 +2174
==========================================
+ Hits 23456 25390 +1934
- Misses 9009 9100 +91
- Partials 2087 2236 +149 |
/cc @danmanor |
can you fix the indentation so we can review the change a bit more easily? |
The removal of LSO looks good! What about |
I tied it, it causes other issues down the road |
ok then just update the PR description |
/test edge-e2e-ai-operator-ztp |
1 similar comment
/test edge-e2e-ai-operator-ztp |
/test edge-e2e-metal-assisted-kube-api-late-binding-single-node |
@eifrach: This pull request references MGMT-16420 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@eifrach: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adriengentil, eifrach The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test e2e-agent-compact-ipv4 |
@eifrach: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
[ART PR BUILD NOTIFIER] This PR has been included in build ose-agent-installer-api-server-container-v4.16.0-202312191312.p0.g893fffb.assembly.stream for distgit ose-agent-installer-api-server. |
LSO is now avilable on 4.15 catalog
List all the issues related to this PR
What environments does this code impact?
How was this code tested?
Checklist
docs
, README, etc)Reviewers Checklist