New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MGMT-16047: Compare normalized infraenv and preprov image architectures #5816
MGMT-16047: Compare normalized infraenv and preprov image architectures #5816
Conversation
Before this change a user would get an error if, for example, arm64 was provided in the infraenv, but aarch64 was provided in the BMH when in reality those should match. Resolves https://issues.redhat.com/browse/MGMT-16047
@carbonin: This pull request references MGMT-16047 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5816 +/- ##
==========================================
+ Coverage 68.07% 69.05% +0.98%
==========================================
Files 235 235
Lines 34398 36632 +2234
==========================================
+ Hits 23416 25297 +1881
- Misses 8921 9108 +187
- Partials 2061 2227 +166
|
/cherry-pick release-ocm-2.9 |
@filanov: once the present PR merges, I will cherry-pick it on top of release-ocm-2.9 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: carbonin, filanov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@carbonin: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@filanov: new pull request created: #5823 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[ART PR BUILD NOTIFIER] This PR has been included in build ose-agent-installer-api-server-container-v4.16.0-202312172051.p0.gdf5c8d3.assembly.stream for distgit ose-agent-installer-api-server. |
Before this change a user would get an error if, for example, arm64 was provided in the infraenv, but aarch64 was provided in the BMH when in reality those should match.
List all the issues related to this PR
Resolves https://issues.redhat.com/browse/MGMT-16047
What environments does this code impact?
How was this code tested?
Unit tests
Checklist
docs
, README, etc)Reviewers Checklist