Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MGMT-16428: create migration from oci to external platform type #5829

Merged
merged 1 commit into from Dec 19, 2023

Conversation

adriengentil
Copy link
Contributor

@adriengentil adriengentil commented Dec 19, 2023

Update existing clusters with platform type oci to use the external platform type

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 19, 2023
Copy link

openshift-ci bot commented Dec 19, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 19, 2023
@adriengentil adriengentil changed the title create migration from oci to external platform type MGMT-16428: create migration from oci to external platform type Dec 19, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 19, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 19, 2023

@adriengentil: This pull request references MGMT-16428 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@adriengentil
Copy link
Contributor Author

/test edge-lint edge-unit-test

@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 19, 2023

@adriengentil: This pull request references MGMT-16428 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@adriengentil
Copy link
Contributor Author

/test edge-lint edge-unit-test

@openshift-ci openshift-ci bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 19, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 19, 2023

@adriengentil: This pull request references MGMT-16428 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to this:

Update existing clusters with platform type oci to use the external platform type

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot removed the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 19, 2023
@adriengentil
Copy link
Contributor Author

/cc @rccrdpccl @gamli75

@adriengentil adriengentil marked this pull request as ready for review December 19, 2023 15:03
Copy link

codecov bot commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e561973) 67.97% compared to head (07fa393) 68.00%.
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5829      +/-   ##
==========================================
+ Coverage   67.97%   68.00%   +0.02%     
==========================================
  Files         235      236       +1     
  Lines       34482    34494      +12     
==========================================
+ Hits        23439    23456      +17     
+ Misses       8977     8975       -2     
+ Partials     2066     2063       -3     
Files Coverage Δ
...1219105000_update_oci_to_external_platform_type.go 100.00% <100.00%> (ø)
internal/migrations/migrations.go 90.00% <100.00%> (+0.34%) ⬆️

... and 1 file with indirect coverage changes

@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 19, 2023
@openshift-ci openshift-ci bot requested a review from avishayt December 19, 2023 15:14
@rccrdpccl
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 19, 2023
Copy link

openshift-ci bot commented Dec 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adriengentil, rccrdpccl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [adriengentil,rccrdpccl]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

openshift-ci bot commented Dec 19, 2023

@adriengentil: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit c000485 into openshift:master Dec 19, 2023
14 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-agent-installer-api-server-container-v4.16.0-202312191909.p0.gc000485.assembly.stream for distgit ose-agent-installer-api-server.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants