MGMT-16330: disable SDN for 4.15 and above

[rccrdpccl]

This PR aims at disabling SDN option when installing OCP 4.15 and above

List all the issues related to this PR

• New Feature
• Enhancement
• Bug fix
• Tests
• Documentation
• CI/CD

What environments does this code impact?

• Automation (CI, tools, etc)
• Cloud
• Operator Managed Deployments
• None

How was this code tested?

• assisted-test-infra environment
• dev-scripts environment
• Reviewer's test appreciated
• Waiting for CI to do a full test run
• Manual (Elaborate on how it was tested)
• No tests needed

Checklist

• Title and description added to both, commit and PR.
• Relevant issues have been associated (see CONTRIBUTING guide)
• This change does not require a documentation update (docstring, docs, README, etc)
• Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

[openshift-ci-robot]

@rccrdpccl: This pull request references MGMT-16330 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.16.0" version, but no target version was set.

In response to this:

This PR aims at disabling SDN option when installing OCP 4.15 and above

List all the issues related to this PR

• New Feature
• Enhancement
• Bug fix
• Tests
• Documentation
• CI/CD

What environments does this code impact?

• Automation (CI, tools, etc)
• Cloud
• Operator Managed Deployments
• None

How was this code tested?

• assisted-test-infra environment
• dev-scripts environment
• Reviewer's test appreciated
• Waiting for CI to do a full test run
• Manual (Elaborate on how it was tested)
• No tests needed

Checklist

• Title and description added to both, commit and PR.
• Relevant issues have been associated (see CONTRIBUTING guide)
• This change does not require a documentation update (docstring, docs, README, etc)
• Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[adriengentil]

not sure if these changes are enough to forbid the setting on back-end side, is that what we want?

[rccrdpccl]

not sure if these changes are enough to forbid the setting on back-end side, is that what we want?

Yes that's what we want, I misread a bit of code and thought it was automatic, so you're right it is not enough

[rccrdpccl]

/refresh

[rccrdpccl]

/hold

Holding to control merge once back from PTO

[codecov]

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (893fffb) 67.96% compared to head (aa3cb2b) 69.27%.
Report is 14 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5833      +/-   ##
==========================================
+ Coverage   67.96%   69.27%   +1.31%     
==========================================
  Files         235      235              
  Lines       34482    35855    +1373     
==========================================
+ Hits        23435    24838    +1403     
+ Misses       8981     8926      -55     
- Partials     2066     2091      +25     

Files	Coverage Δ
internal/featuresupport/feature_support_level.go	89.47% <ø> (ø)
internal/featuresupport/common.go	87.09% <88.00%> (+0.73%)	⬆️
internal/bminventory/inventory.go	78.85% <81.81%> (+7.41%)	⬆️
internal/featuresupport/features_networking.go	85.34% <89.47%> (+1.34%)	⬆️

... and 18 files with indirect coverage changes

[rccrdpccl]

/retest

[rccrdpccl]

/retest

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adriengentil, gamli75, rccrdpccl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [adriengentil,gamli75,rccrdpccl]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[adriengentil]

/retest

[adriengentil]

/retest

[adriengentil]

/retest

[rccrdpccl]

/retest

[rccrdpccl]

/override e2e-agent-compact-ipv4

[openshift-ci]

@rccrdpccl: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

• e2e-agent-compact-ipv4

Only the following failed contexts/checkruns were expected:

• ci/prow/e2e-agent-compact-ipv4
• ci/prow/edge-ci-index
• ci/prow/edge-e2e-ai-operator-disconnected-capi
• ci/prow/edge-e2e-ai-operator-ztp
• ci/prow/edge-e2e-ai-operator-ztp-capi
• ci/prow/edge-e2e-metal-assisted
• ci/prow/edge-images
• ci/prow/edge-lint
• ci/prow/edge-subsystem-aws
• ci/prow/edge-subsystem-kubeapi-aws
• ci/prow/edge-unit-test
• ci/prow/edge-verify-generated-code
• ci/prow/images
• ci/prow/mce-images
• pull-ci-openshift-assisted-service-cloud_hotfix_releases-images
• pull-ci-openshift-assisted-service-master-e2e-agent-compact-ipv4
• pull-ci-openshift-assisted-service-master-edge-ci-index
• pull-ci-openshift-assisted-service-master-edge-e2e-ai-operator-disconnected-capi
• pull-ci-openshift-assisted-service-master-edge-e2e-ai-operator-ztp
• pull-ci-openshift-assisted-service-master-edge-e2e-ai-operator-ztp-capi
• pull-ci-openshift-assisted-service-master-edge-e2e-metal-assisted
• pull-ci-openshift-assisted-service-master-edge-images
• pull-ci-openshift-assisted-service-master-edge-lint
• pull-ci-openshift-assisted-service-master-edge-subsystem-aws
• pull-ci-openshift-assisted-service-master-edge-subsystem-kubeapi-aws
• pull-ci-openshift-assisted-service-master-edge-unit-test
• pull-ci-openshift-assisted-service-master-edge-verify-generated-code
• pull-ci-openshift-assisted-service-master-mce-images
• tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override e2e-agent-compact-ipv4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[rccrdpccl]

/override ci/prow/e2e-agent-compact-ipv4
/unhold

[openshift-ci]

@rccrdpccl: Overrode contexts on behalf of rccrdpccl: ci/prow/e2e-agent-compact-ipv4

In response to this:

/override ci/prow/e2e-agent-compact-ipv4
/unhold

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@rccrdpccl: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-agent-installer-api-server-container-v4.16.0-202401082351.p0.g2f45852.assembly.stream for distgit ose-agent-installer-api-server.
All builds following this will include this PR.