Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MGMT-16452: Change MCE subscription to use the default channel #5843

Merged
merged 1 commit into from Dec 28, 2023
Merged

MGMT-16452: Change MCE subscription to use the default channel #5843

merged 1 commit into from Dec 28, 2023

Conversation

danmanor
Copy link
Contributor

Change MCE subscription to use the default channel in order to reduce redundant complexity and maintaining configuration of OCP -> MCE releases

List all the issues related to this PR

  • New Feature
  • Enhancement
  • Bug fix
  • Tests
  • Documentation
  • CI/CD

What environments does this code impact?

  • Automation (CI, tools, etc)
  • Cloud
  • Operator Managed Deployments
  • None

How was this code tested?

  • assisted-test-infra environment
  • dev-scripts environment
  • Reviewer's test appreciated
  • Waiting for CI to do a full test run
  • Manual (Elaborate on how it was tested)
  • No tests needed

Checklist

  • Title and description added to both, commit and PR.
  • Relevant issues have been associated (see CONTRIBUTING guide)
  • This change does not require a documentation update (docstring, docs, README, etc)
  • Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

  • Are the title and description (in both PR and commit) meaningful and clear?
  • Is there a bug required (and linked) for this change?
  • Should this PR be backported?

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 24, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 24, 2023 •
edited by openshift-ci bot

@danmanor: This pull request references MGMT-16452 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to this:

Change MCE subscription to use the default channel in order to reduce redundant complexity and maintaining configuration of OCP -> MCE releases

List all the issues related to this PR

  • New Feature
  • Enhancement
  • Bug fix
  • Tests
  • Documentation
  • CI/CD

What environments does this code impact?

  • Automation (CI, tools, etc)
  • Cloud
  • Operator Managed Deployments
  • None

How was this code tested?

  • assisted-test-infra environment
  • dev-scripts environment
  • Reviewer's test appreciated
  • Waiting for CI to do a full test run
  • Manual (Elaborate on how it was tested)
  • No tests needed

Checklist

  • Title and description added to both, commit and PR.
  • Relevant issues have been associated (see CONTRIBUTING guide)
  • This change does not require a documentation update (docstring, docs, README, etc)
  • Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

  • Are the title and description (in both PR and commit) meaningful and clear?
  • Is there a bug required (and linked) for this change?
  • Should this PR be backported?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@danmanor
Copy link
Contributor Author

/test

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 24, 2023
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 24, 2023

@danmanor: The /test command needs one or more targets.
The following commands are available to trigger required jobs:

  • /test e2e-agent-compact-ipv4
  • /test edge-assisted-operator-catalog-publish-verify
  • /test edge-ci-index
  • /test edge-e2e-ai-operator-ztp
  • /test edge-e2e-ai-operator-ztp-sno-day2-workers
  • /test edge-e2e-ai-operator-ztp-sno-day2-workers-late-binding
  • /test edge-e2e-metal-assisted
  • /test edge-e2e-metal-assisted-4-11
  • /test edge-e2e-metal-assisted-4-12
  • /test edge-e2e-metal-assisted-cnv
  • /test edge-e2e-metal-assisted-lvm
  • /test edge-e2e-metal-assisted-odf
  • /test edge-images
  • /test edge-lint
  • /test edge-subsystem-aws
  • /test edge-subsystem-kubeapi-aws
  • /test edge-unit-test
  • /test edge-verify-generated-code
  • /test images
  • /test mce-images

The following commands are available to trigger optional jobs:

  • /test e2e-agent-ha-dualstack
  • /test e2e-agent-sno-ipv6
  • /test edge-e2e-ai-operator-ztp-3masters
  • /test edge-e2e-ai-operator-ztp-capi
  • /test edge-e2e-ai-operator-ztp-compact-day2-masters
  • /test edge-e2e-ai-operator-ztp-compact-day2-workers
  • /test edge-e2e-ai-operator-ztp-disconnected
  • /test edge-e2e-ai-operator-ztp-hypershift-zero-nodes
  • /test edge-e2e-ai-operator-ztp-multiarch-3masters-ocp
  • /test edge-e2e-ai-operator-ztp-multiarch-sno-ocp
  • /test edge-e2e-ai-operator-ztp-node-labels
  • /test edge-e2e-ai-operator-ztp-sno-day2-masters
  • /test edge-e2e-ai-operator-ztp-sno-day2-workers-ignitionoverride
  • /test edge-e2e-metal-assisted-4-13
  • /test edge-e2e-metal-assisted-4-14
  • /test edge-e2e-metal-assisted-4-15
  • /test edge-e2e-metal-assisted-bond
  • /test edge-e2e-metal-assisted-day2
  • /test edge-e2e-metal-assisted-day2-arm-workers
  • /test edge-e2e-metal-assisted-day2-single-node
  • /test edge-e2e-metal-assisted-external
  • /test edge-e2e-metal-assisted-external-4-14
  • /test edge-e2e-metal-assisted-ipv4v6
  • /test edge-e2e-metal-assisted-ipv6
  • /test edge-e2e-metal-assisted-kube-api-late-binding-single-node
  • /test edge-e2e-metal-assisted-kube-api-late-unbinding-ipv4-single-node
  • /test edge-e2e-metal-assisted-kube-api-net-suite
  • /test edge-e2e-metal-assisted-mce-4-11
  • /test edge-e2e-metal-assisted-mce-4-12
  • /test edge-e2e-metal-assisted-mce-4-13
  • /test edge-e2e-metal-assisted-mce-4-14
  • /test edge-e2e-metal-assisted-mce-4-15
  • /test edge-e2e-metal-assisted-mce-sno
  • /test edge-e2e-metal-assisted-metallb
  • /test edge-e2e-metal-assisted-none
  • /test edge-e2e-metal-assisted-onprem
  • /test edge-e2e-metal-assisted-single-node
  • /test edge-e2e-metal-assisted-static-ip-suite
  • /test edge-e2e-metal-assisted-tang
  • /test edge-e2e-metal-assisted-tpmv2
  • /test edge-e2e-metal-assisted-upgrade-agent
  • /test edge-e2e-nutanix-assisted
  • /test edge-e2e-nutanix-assisted-2workers
  • /test edge-e2e-nutanix-assisted-4-14
  • /test edge-e2e-oci-assisted
  • /test edge-e2e-oci-assisted-4-14
  • /test edge-e2e-oci-assisted-iscsi
  • /test edge-e2e-vsphere-assisted
  • /test edge-e2e-vsphere-assisted-4-12
  • /test edge-e2e-vsphere-assisted-4-13
  • /test edge-e2e-vsphere-assisted-4-14
  • /test edge-e2e-vsphere-assisted-umn
  • /test edge-push-pr-image
  • /test push-pr-image

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-assisted-service-master-e2e-agent-compact-ipv4
  • pull-ci-openshift-assisted-service-master-edge-ci-index
  • pull-ci-openshift-assisted-service-master-edge-e2e-ai-operator-ztp
  • pull-ci-openshift-assisted-service-master-edge-e2e-metal-assisted
  • pull-ci-openshift-assisted-service-master-edge-e2e-metal-assisted-bond
  • pull-ci-openshift-assisted-service-master-edge-e2e-metal-assisted-cnv
  • pull-ci-openshift-assisted-service-master-edge-e2e-metal-assisted-day2
  • pull-ci-openshift-assisted-service-master-edge-e2e-metal-assisted-day2-single-node
  • pull-ci-openshift-assisted-service-master-edge-e2e-metal-assisted-ipv4v6
  • pull-ci-openshift-assisted-service-master-edge-e2e-metal-assisted-lvm
  • pull-ci-openshift-assisted-service-master-edge-e2e-metal-assisted-odf
  • pull-ci-openshift-assisted-service-master-edge-e2e-metal-assisted-single-node
  • pull-ci-openshift-assisted-service-master-edge-e2e-metal-assisted-static-ip-suite
  • pull-ci-openshift-assisted-service-master-edge-images
  • pull-ci-openshift-assisted-service-master-edge-lint
  • pull-ci-openshift-assisted-service-master-edge-subsystem-aws
  • pull-ci-openshift-assisted-service-master-edge-subsystem-kubeapi-aws
  • pull-ci-openshift-assisted-service-master-edge-unit-test
  • pull-ci-openshift-assisted-service-master-edge-verify-generated-code
  • pull-ci-openshift-assisted-service-master-images
  • pull-ci-openshift-assisted-service-master-mce-images

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from omertuc December 24, 2023 12:12
@danmanor
Copy link
Contributor Author

/test edge-e2e-metal-assisted-mce-4-11
/test edge-e2e-metal-assisted-mce-4-12
/test edge-e2e-metal-assisted-mce-4-13
/test edge-e2e-metal-assisted-mce-4-14
/test edge-e2e-metal-assisted-mce-4-15

@openshift-ci openshift-ci bot requested a review from vrutkovs December 24, 2023 12:12
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 24, 2023
@codecov Codecov
Copy link

codecov bot commented Dec 24, 2023 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (03e376c) 68.02% compared to head (20c3df0) 68.04%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5843      +/-   ##
==========================================
+ Coverage   68.02%   68.04%   +0.02%     
==========================================
  Files         236      235       -1     
  Lines       34601    34565      -36     
==========================================
- Hits        23536    23521      -15     
+ Misses       8995     8982      -13     
+ Partials     2070     2062       -8
Files Coverage Δ
internal/operators/builder.go 100.00% <100.00%> (ø)
internal/operators/mce/manifest.go 72.72% <100.00%> (+1.89%) ⬆️
internal/operators/mce/mce_operator.go 70.47% <100.00%> (+2.29%) ⬆️

... and 3 files with indirect coverage changes

@danmanor
Copy link
Contributor Author

/test edge-e2e-metal-assisted-lvm

@danmanor
Copy link
Contributor Author

/cc @gamli75 @eifrach

@eifrach
Copy link
Contributor

eifrach commented Dec 25, 2023

/hold

waiting for fix
danmanor#1

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 25, 2023
@danmanor danmanor force-pushed the change-to-default-mce-channel branch from d17b3b4 to 20c3df0 Compare December 27, 2023 10:09
@danmanor danmanor marked this pull request as draft December 27, 2023 10:10
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 27, 2023
@danmanor
Copy link
Contributor Author

/test edge-e2e-metal-assisted-lvm

@danmanor
Copy link
Contributor Author

/abort

@danmanor
Copy link
Contributor Author

/test edge-e2e-metal-assisted-lvm

@danmanor danmanor marked this pull request as ready for review December 27, 2023 14:52
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 27, 2023
@danmanor
Copy link
Contributor Author

@eifrach For clarity sake lets merge this one and fix the version comparison in another PR

@danmanor
Copy link
Contributor Author

/retest

@danmanor
Copy link
Contributor Author

/test edge-e2e-metal-assisted-mce-4-11
/test edge-e2e-metal-assisted-mce-4-12
/test edge-e2e-metal-assisted-mce-4-13
/test edge-e2e-metal-assisted-mce-4-14
/test edge-e2e-metal-assisted-mce-4-15

@eifrach
Copy link
Contributor

eifrach commented Dec 28, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 28, 2023
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 28, 2023

@danmanor: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@eifrach
Copy link
Contributor

eifrach commented Dec 28, 2023

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 28, 2023
@eifrach
Copy link
Contributor

eifrach commented Dec 28, 2023

/approve

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danmanor, eifrach

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit e604bc4 into openshift:master Dec 28, 2023
28 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-agent-installer-api-server-container-v4.16.0-202312281131.p0.ge604bc4.assembly.stream for distgit ose-agent-installer-api-server.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omertuc omertuc Awaiting requested review from omertuc

@vrutkovs vrutkovs Awaiting requested review from vrutkovs

@gamli75 gamli75 Awaiting requested review from gamli75

@danielerez danielerez Awaiting requested review from danielerez

@osherdp osherdp Awaiting requested review from osherdp

@eifrach eifrach Awaiting requested review from eifrach

Assignees

@eifrach eifrach

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@danmanor @openshift-ci-robot @eifrach @openshift-bot