NO-ISSUE: testing go1.20 in all packages #5850
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@eifrach: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Skipping CI for Draft Pull Request. |
openshift-ci
bot
added
do-not-merge/work-in-progress
|
/test ? |
|
@eifrach: The following commands are available to trigger required jobs:
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
approved
|
/test edge-verify-generated-code |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5850 +/- ##
==========================================
+ Coverage 68.04% 68.45% +0.40%
==========================================
Files 235 235
Lines 34565 35245 +680
==========================================
+ Hits 23521 24127 +606
- Misses 8983 9032 +49
- Partials 2061 2086 +25 |
eifrach
force-pushed
the
align-go1.20
branch
from
937514a
to
e9a582d
Compare
openshift-ci
bot
added
size/XS
|
/test edge-verify-generated-code |
eifrach
force-pushed
the
align-go1.20
branch
from
e9a582d
to
f206ff4
Compare
|
/test edge-verify-generated-code |
eifrach
force-pushed
the
align-go1.20
branch
from
f206ff4
to
5459a63
Compare
|
/test edge-verify-generated-code |
|
/test edge-images |
|
/test edge-e2e-metal-assisted |
|
hey @carbonin, I appricate you're input here. This will solve some of our depndenices issues and also fix this PR you created furthermore, I think we can remove this command from the file, since it already has Golang version installed in the base image # https://github.com/openshift/assisted-service/blob/5459a631ffa92d533c4549d824cb4d4c4c290926/hack/setup_env.sh#L17
/tmp/golang_installer -version 1.20base image # https://github.com/openshift/assisted-service/blob/5459a631ffa92d533c4549d824cb4d4c4c290926/ci-images/Dockerfile.base#L11C21-L11C22
COPY --from=registry.ci.openshift.org/openshift/release:golang-1.20 /usr/local/go /usr/local/go
COPY --from=registry.ci.openshift.org/openshift/release:golang-1.20 /usr/bin/gotestsum /usr/bin/make /usr/bin/thanks in advance |
|
/test edge-ci-index |
|
As far as I can tell the only user of this is assisted-service/hack/setup_env.sh Lines 102 to 104 in 315899d I think it would be worth investigating if we need that |
|
/test edge-images |
openshift-ci
bot
added
size/S
|
/test edge-e2e-metal-assisted |
|
/cc @carbonin |
|
/test e2e-agent-compact-ipv4 |
|
/test edge-e2e-metal-assisted |
|
/test e2e-agent-compact-ipv4 |
|
/override ci/prow/e2e-agent-compact-ipv4 broken job due to SDN default and OCP 4.15 |
|
@rccrdpccl: Overrode contexts on behalf of rccrdpccl: ci/prow/e2e-agent-compact-ipv4 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test ci/prow/edge-e2e-ai-operator-ztp |
|
@rccrdpccl: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test edge-e2e-ai-operator-ztp |
1 similar comment
|
/test edge-e2e-ai-operator-ztp |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eifrach, rccrdpccl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold Revision 165730a was retested 3 times: holding |
openshift-ci
bot
added
the
do-not-merge/hold
|
/test ci/prow/e2e-agent-compact-ipv4 |
|
@eifrach: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test e2e-agent-compact-ipv4 |
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
|
@eifrach: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
List all the issues related to this PR
What environments does this code impact?
How was this code tested?
Checklist
docs, README, etc)Reviewers Checklist