MGMT-16208: Add controller stages to assisted service

[ori-amizur]

Add the controller stages and the timeouts handling to the assisted service. This includes handling both for "soft" and "hard" timeouts.

Add API handling for reporting controller timeouts.

Add new event for soft finalizing stage timeouts

List all the issues related to this PR

• New Feature
• Enhancement
• Bug fix
• Tests
• Documentation
• CI/CD

What environments does this code impact?

• Automation (CI, tools, etc)
• Cloud
• Operator Managed Deployments
• None

How was this code tested?

• assisted-test-infra environment
• dev-scripts environment
• Reviewer's test appreciated
• Waiting for CI to do a full test run
• Manual (Elaborate on how it was tested)
• No tests needed

Checklist

• Title and description added to both, commit and PR.
• Relevant issues have been associated (see CONTRIBUTING guide)
• This change does not require a documentation update (docstring, docs, README, etc)
• Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

/cc @filanov

[openshift-ci-robot]

@ori-amizur: This pull request references MGMT-16208 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to this:

Add the controller stages and the timeouts handling to the assisted service. This includes handling both for "soft" and "hard" timeouts.

Add API handling for reporting controller timeouts.

Add new event for soft finalizing stage timeouts

List all the issues related to this PR

• New Feature
• Enhancement
• Bug fix
• Tests
• Documentation
• CI/CD

What environments does this code impact?

• Automation (CI, tools, etc)
• Cloud
• Operator Managed Deployments
• None

How was this code tested?

• assisted-test-infra environment
• dev-scripts environment
• Reviewer's test appreciated
• Waiting for CI to do a full test run
• Manual (Elaborate on how it was tested)
• No tests needed

Checklist

• Title and description added to both, commit and PR.
• Relevant issues have been associated (see CONTRIBUTING guide)
• This change does not require a documentation update (docstring, docs, README, etc)
• Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

/cc @filanov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[ori-amizur]

/cc @carbonin

[codecov]

Codecov Report

Attention: 22 lines in your changes are missing coverage. Please review.

Comparison is base (a75c684) 68.11% compared to head (19c55ad) 68.05%.
Report is 9 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5880      +/-   ##
==========================================
- Coverage   68.11%   68.05%   -0.06%     
==========================================
  Files         235      236       +1     
  Lines       34640    34858     +218     
==========================================
+ Hits        23595    23723     +128     
- Misses       8984     9066      +82     
- Partials     2061     2069       +8     

Files	Coverage Δ
internal/cluster/statemachine.go	100.00% <100.00%> (ø)
internal/host/common.go	88.88% <ø> (ø)
internal/cluster/common.go	78.00% <80.00%> (+0.14%)	⬆️
internal/cluster/cluster.go	65.98% <88.00%> (+0.40%)	⬆️
internal/cluster/finalizing_stages.go	89.28% <89.28%> (ø)
internal/bminventory/inventory_v2_handlers.go	56.88% <0.00%> (-0.38%)	⬇️
internal/cluster/transition.go	74.09% <76.74%> (+0.22%)	⬆️

... and 3 files with indirect coverage changes

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: carbonin, ori-amizur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [carbonin,ori-amizur]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ori-amizur]

/test edge-e2e-metal-assisted-odf

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 2c149a3 and 2 for PR HEAD 19c55ad in total

[openshift-ci]

@ori-amizur: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-agent-installer-api-server-container-v4.16.0-202401240612.p0.g003cbfd.assembly.stream for distgit ose-agent-installer-api-server.
All builds following this will include this PR.