MGMT-16332: fix validation for LVM multinode #5898

eifrach · 2024-01-21T12:32:25Z

Fixing requirements for LVM multinode deployment

full cluster should require disk on worker nodes only
full cluster shouldn't allow auto assign
fixing requirment calculation
adding tests for requirements resources

List all the issues related to this PR

What environments does this code impact?

Automation (CI, tools, etc)
Cloud
Operator Managed Deployments
None

How was this code tested?

assisted-test-infra environment
dev-scripts environment
Reviewer's test appreciated
Waiting for CI to do a full test run
Manual (Elaborate on how it was tested)
No tests needed

Checklist

Title and description added to both, commit and PR.
Relevant issues have been associated (see CONTRIBUTING guide)
This change does not require a documentation update (docstring, docs, README, etc)
Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

Are the title and description (in both PR and commit) meaningful and clear?
Is there a bug required (and linked) for this change?
Should this PR be backported?

openshift-ci-robot · 2024-01-21T12:32:28Z

openshift-ci · 2024-01-21T12:32:29Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

eifrach · 2024-01-21T12:32:44Z

/test images
/test unit-tests

eifrach · 2024-01-21T15:08:06Z

/test ?

openshift-ci · 2024-01-21T15:08:13Z

@eifrach: The following commands are available to trigger required jobs:

/test e2e-agent-compact-ipv4
/test edge-assisted-operator-catalog-publish-verify
/test edge-ci-index
/test edge-e2e-ai-operator-ztp
/test edge-e2e-ai-operator-ztp-sno-day2-workers
/test edge-e2e-ai-operator-ztp-sno-day2-workers-late-binding
/test edge-e2e-metal-assisted
/test edge-e2e-metal-assisted-4-11
/test edge-e2e-metal-assisted-4-12
/test edge-e2e-metal-assisted-cnv
/test edge-e2e-metal-assisted-lvm
/test edge-e2e-metal-assisted-odf
/test edge-images
/test edge-lint
/test edge-subsystem-aws
/test edge-subsystem-kubeapi-aws
/test edge-unit-test
/test edge-verify-generated-code
/test images
/test mce-images

The following commands are available to trigger optional jobs:

/test e2e-agent-ha-dualstack
/test e2e-agent-sno-ipv6
/test edge-e2e-ai-operator-disconnected-capi
/test edge-e2e-ai-operator-ztp-3masters
/test edge-e2e-ai-operator-ztp-capi
/test edge-e2e-ai-operator-ztp-compact-day2-masters
/test edge-e2e-ai-operator-ztp-compact-day2-workers
/test edge-e2e-ai-operator-ztp-disconnected
/test edge-e2e-ai-operator-ztp-hypershift-zero-nodes
/test edge-e2e-ai-operator-ztp-multiarch-3masters-ocp
/test edge-e2e-ai-operator-ztp-multiarch-sno-ocp
/test edge-e2e-ai-operator-ztp-node-labels
/test edge-e2e-ai-operator-ztp-sno-day2-masters
/test edge-e2e-ai-operator-ztp-sno-day2-workers-ignitionoverride
/test edge-e2e-metal-assisted-4-13
/test edge-e2e-metal-assisted-4-14
/test edge-e2e-metal-assisted-4-15
/test edge-e2e-metal-assisted-bond
/test edge-e2e-metal-assisted-bond-4-14
/test edge-e2e-metal-assisted-day2
/test edge-e2e-metal-assisted-day2-arm-workers
/test edge-e2e-metal-assisted-day2-single-node
/test edge-e2e-metal-assisted-external
/test edge-e2e-metal-assisted-external-4-14
/test edge-e2e-metal-assisted-ipv4v6
/test edge-e2e-metal-assisted-ipv6
/test edge-e2e-metal-assisted-kube-api-late-binding-single-node
/test edge-e2e-metal-assisted-kube-api-late-unbinding-ipv4-single-node
/test edge-e2e-metal-assisted-kube-api-net-suite
/test edge-e2e-metal-assisted-mce-4-11
/test edge-e2e-metal-assisted-mce-4-12
/test edge-e2e-metal-assisted-mce-4-13
/test edge-e2e-metal-assisted-mce-4-14
/test edge-e2e-metal-assisted-mce-4-15
/test edge-e2e-metal-assisted-mce-sno
/test edge-e2e-metal-assisted-metallb
/test edge-e2e-metal-assisted-none
/test edge-e2e-metal-assisted-onprem
/test edge-e2e-metal-assisted-single-node
/test edge-e2e-metal-assisted-static-ip-suite
/test edge-e2e-metal-assisted-static-ip-suite-4-14
/test edge-e2e-metal-assisted-tang
/test edge-e2e-metal-assisted-tpmv2
/test edge-e2e-metal-assisted-upgrade-agent
/test edge-e2e-nutanix-assisted
/test edge-e2e-nutanix-assisted-2workers
/test edge-e2e-nutanix-assisted-4-14
/test edge-e2e-oci-assisted
/test edge-e2e-oci-assisted-4-14
/test edge-e2e-oci-assisted-iscsi
/test edge-e2e-vsphere-assisted
/test edge-e2e-vsphere-assisted-4-12
/test edge-e2e-vsphere-assisted-4-13
/test edge-e2e-vsphere-assisted-4-14
/test edge-e2e-vsphere-assisted-umn
/test edge-push-pr-image
/test push-pr-image

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-assisted-service-master-e2e-agent-compact-ipv4
pull-ci-openshift-assisted-service-master-edge-ci-index
pull-ci-openshift-assisted-service-master-edge-e2e-ai-operator-ztp
pull-ci-openshift-assisted-service-master-edge-e2e-metal-assisted
pull-ci-openshift-assisted-service-master-edge-e2e-metal-assisted-cnv
pull-ci-openshift-assisted-service-master-edge-e2e-metal-assisted-lvm
pull-ci-openshift-assisted-service-master-edge-e2e-metal-assisted-odf
pull-ci-openshift-assisted-service-master-edge-images
pull-ci-openshift-assisted-service-master-edge-lint
pull-ci-openshift-assisted-service-master-edge-subsystem-aws
pull-ci-openshift-assisted-service-master-edge-subsystem-kubeapi-aws
pull-ci-openshift-assisted-service-master-edge-unit-test
pull-ci-openshift-assisted-service-master-edge-verify-generated-code
pull-ci-openshift-assisted-service-master-images
pull-ci-openshift-assisted-service-master-mce-images

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

eifrach · 2024-01-21T15:10:19Z

/test edge-lint
/test edge-unit-test
/test edge-images
/test images

codecov · 2024-01-21T15:30:44Z

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (9f19758) 68.32% compared to head (e436abe) 68.27%.
Report is 6 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5898      +/-   ##
==========================================
- Coverage   68.32%   68.27%   -0.05%     
==========================================
  Files         236      236              
  Lines       34943    35047     +104     
==========================================
+ Hits        23874    23929      +55     
- Misses       8997     9044      +47     
- Partials     2072     2074       +2

Files	Coverage Δ
internal/bminventory/inventory.go	`71.31% <100.00%> (-0.22%)`	⬇️
internal/operators/cnv/cnv_operator.go	`79.65% <100.00%> (ø)`
internal/operators/lvm/config.go	`100.00% <ø> (ø)`
internal/operators/lvm/manifest.go	`72.88% <100.00%> (ø)`
internal/operators/lvm/lvm_operator.go	`80.20% <97.05%> (+8.63%)`	⬆️
internal/operators/manager.go	`77.64% <0.00%> (ø)`
internal/host/hostutil/test_utils.go	`11.39% <0.00%> (ø)`

... and 13 files with indirect coverage changes

eifrach · 2024-01-24T16:31:44Z

/test edge-lint
/test edge-unit-test
/test edge-images
/test images
/test edge-e2e-metal-assisted-lvm

eifrach · 2024-01-25T09:50:33Z

/test edge-e2e-metal-assisted-lvm

eifrach · 2024-01-28T11:57:59Z

/test edge-lint
/test edge-unit-test
/test edge-images
/test images
/test edge-e2e-metal-assisted-lvm

eifrach · 2024-01-28T15:15:44Z

/test edge-lint
/test edge-unit-test
/test edge-images
/test images

openshift-ci-robot · 2024-01-28T15:50:31Z

openshift-ci-robot · 2024-01-28T15:50:45Z

internal/operators/lvm/lvm_operator.go

internal/operators/odf/odf_operator.go

internal/operators/lvm/common.go

internal/operators/lvm/lvm_operator.go

internal/common/common.go

eifrach · 2024-01-29T15:49:54Z

/test edge-lint
/test edge-unit-test
/test edge-images
/test images

internal/operators/lvm/lvm_operator.go

eifrach · 2024-02-11T13:25:07Z

/test edge-subsystem-aws

eifrach · 2024-02-11T13:29:36Z

/test edge-subsystem-aws

osherdp

Mainly syntactic comments

internal/operators/lvm/config.go

internal/operators/lvm/lvm_operator.go

eifrach · 2024-02-12T15:15:25Z

/test images

gamli75 · 2024-02-13T07:05:45Z

/retest-required

avishayt · 2024-02-13T08:21:41Z

/lgtm

eifrach · 2024-02-13T13:56:58Z

/test edge-e2e-metal-assisted-odf

eifrach · 2024-02-13T15:04:01Z

/test edge-e2e-metal-assisted-odf

eifrach · 2024-02-13T16:41:11Z

/cc @osherdp
/cc @gamli75

openshift-ci · 2024-02-13T19:30:26Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eifrach, gamli75

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [eifrach,gamli75]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

gamli75 · 2024-02-13T21:21:03Z

/unhold

openshift-ci · 2024-02-13T23:57:48Z

@eifrach: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-bot · 2024-02-14T02:56:18Z

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-agent-installer-api-server-container-v4.16.0-202402140210.p0.g5bf3f33.assembly.stream.el8 for distgit ose-agent-installer-api-server.
All builds following this will include this PR.

$eifrach$

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 21, 2024

openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 21, 2024

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 21, 2024

$@eifrach$ eifrach force-pushed the lvm_clustertype_deployment branch 3 times, most recently from 2a6b359 to 9dedc6f Compare January 28, 2024 11:56

openshift-ci bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 28, 2024

$@eifrach$ eifrach force-pushed the lvm_clustertype_deployment branch from 9dedc6f to 4c85ac9 Compare January 28, 2024 15:15

$@eifrach$ eifrach changed the title ~~MGMT-16332: moving deployment type to common~~ MGMT-16332: align LVM multi node requirements Jan 28, 2024

gamli75 reviewed Jan 29, 2024

View reviewed changes

avishayt reviewed Jan 29, 2024

View reviewed changes

$@eifrach$ eifrach force-pushed the lvm_clustertype_deployment branch 2 times, most recently from 24f4cbb to 1b39606 Compare January 29, 2024 14:04

avishayt reviewed Jan 29, 2024

View reviewed changes

internal/operators/lvm/lvm_operator.go Outdated Show resolved Hide resolved

$@eifrach$ eifrach force-pushed the lvm_clustertype_deployment branch from 265f4df to cacfdf8 Compare February 11, 2024 13:28

osherdp reviewed Feb 12, 2024

View reviewed changes

$@eifrach$

MGMT-16332: fix validation and tests for LVM multinode

d34fa3a

$@eifrach$ eifrach force-pushed the lvm_clustertype_deployment branch from cacfdf8 to d34fa3a Compare February 12, 2024 12:02

$@eifrach$ eifrach marked this pull request as ready for review February 12, 2024 12:09

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 12, 2024

openshift-ci bot requested review from avishayt and eliorerz February 12, 2024 12:12

$@eifrach$

MGMT-16332: fix lvmo operator name

80839f9

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 13, 2024

$@eifrach$

MGMT-16332: subsystem tests

e436abe

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 13, 2024

$@eifrach$ eifrach requested a review from osherdp February 13, 2024 15:11

gamli75 approved these changes Feb 13, 2024

View reviewed changes

openshift-ci bot assigned gamli75 Feb 13, 2024

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 13, 2024

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 13, 2024

openshift-merge-bot bot merged commit 5bf3f33 into openshift:master Feb 13, 2024
17 checks passed

MGMT-16332: fix validation for LVM multinode #5898

MGMT-16332: fix validation for LVM multinode #5898

Conversation

eifrach commented Jan 21, 2024 • edited

List all the issues related to this PR

What environments does this code impact?

How was this code tested?

Checklist

Reviewers Checklist

openshift-ci-robot commented Jan 21, 2024 • edited by openshift-ci bot

List all the issues related to this PR

What environments does this code impact?

How was this code tested?

Checklist

Reviewers Checklist

openshift-ci bot commented Jan 21, 2024

eifrach commented Jan 21, 2024

eifrach commented Jan 21, 2024

openshift-ci bot commented Jan 21, 2024

eifrach commented Jan 21, 2024

codecov bot commented Jan 21, 2024 • edited

Codecov Report

eifrach commented Jan 24, 2024

eifrach commented Jan 25, 2024

eifrach commented Jan 28, 2024

eifrach commented Jan 28, 2024

openshift-ci-robot commented Jan 28, 2024 • edited by openshift-ci bot

List all the issues related to this PR

What environments does this code impact?

How was this code tested?

Checklist

Reviewers Checklist

openshift-ci-robot commented Jan 28, 2024 • edited by openshift-ci bot

List all the issues related to this PR

What environments does this code impact?

How was this code tested?

Checklist

Reviewers Checklist

eifrach commented Jan 29, 2024

eifrach commented Feb 11, 2024

eifrach commented Feb 11, 2024

osherdp left a comment

Choose a reason for hiding this comment

eifrach commented Feb 12, 2024

gamli75 commented Feb 13, 2024

avishayt commented Feb 13, 2024

eifrach commented Feb 13, 2024

eifrach commented Feb 13, 2024

eifrach commented Feb 13, 2024

openshift-ci bot commented Feb 13, 2024

gamli75 commented Feb 13, 2024

openshift-ci bot commented Feb 13, 2024

openshift-bot commented Feb 14, 2024

$@eifrach$ eifrach commented Jan 21, 2024 •

edited

openshift-ci-robot commented Jan 21, 2024 •

edited by openshift-ci bot

codecov bot commented Jan 21, 2024 •

edited

openshift-ci-robot commented Jan 28, 2024 •

edited by openshift-ci bot

openshift-ci-robot commented Jan 28, 2024 •

edited by openshift-ci bot