MGMT-16649: Add Ignition Endpoint Headers to Host and Agent APIs #5931
Conversation
|
@CrystalChun: This pull request references MGMT-16649 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
openshift-ci
bot
added
the
size/L
|
/test ? |
|
@CrystalChun: The following commands are available to trigger required jobs:
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
api-review
CrystalChun
force-pushed
the
host-api-changes
branch
2 times, most recently
from
1a82330
to
f0d28c5
Compare
|
/test edge-e2e-ai-operator-ztp-sno-day2-workers edge-subsystem-kubeapi-aws |
CrystalChun
force-pushed
the
host-api-changes
branch
3 times, most recently
from
6f4c53a
to
c025500
Compare
|
/test edge-e2e-ai-operator-ztp-sno-day2-workers edge-subsystem-kubeapi-aws |
CrystalChun
force-pushed
the
host-api-changes
branch
from
c025500
to
99cc068
Compare
|
/test edge-e2e-ai-operator-ztp-sno-day2-workers edge-subsystem-kubeapi-aws edge-lint edge-unit-test |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5931 +/- ##
=======================================
Coverage 68.31% 68.31%
=======================================
Files 236 236
Lines 34917 34917
=======================================
+ Hits 23852 23853 +1
+ Misses 8997 8996 -1
Partials 2068 2068
|
CrystalChun
force-pushed
the
host-api-changes
branch
2 times, most recently
from
ebcf291
to
5e24503
Compare
openshift-ci
bot
removed
the
size/L
CrystalChun
changed the title
openshift-ci
bot
added
the
size/S
|
@CrystalChun: This pull request references MGMT-16649 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/test edge-unit-test |
|
@CrystalChun: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
CrystalChun
force-pushed
the
host-api-changes
branch
from
5e24503
to
424548a
Compare
CrystalChun
force-pushed
the
host-api-changes
branch
from
424548a
to
6853281
Compare
openshift-ci
bot
added
size/M
CrystalChun
force-pushed
the
host-api-changes
branch
from
6853281
to
e3a92e5
Compare
api/v1beta1/agent_types.go
Outdated
| @@ -194,6 +194,8 @@ type AgentSpec struct { | |||
| IgnitionConfigOverrides string `json:"ignitionConfigOverrides,omitempty"` | |||
| // IgnitionEndpointTokenReference references a secret containing an Authorization Bearer token to fetch the ignition from ignition_endpoint_url. | |||
| IgnitionEndpointTokenReference *IgnitionEndpointTokenReference `json:"ignitionEndpointTokenReference,omitempty"` | |||
| // IgnitionEndpointHTTPHeaders is a json formatted string of the additional HTTP headers when fetching the ignition. | |||
| IgnitionEndpointHTTPHeaders map[string]string `json:"ignition_endpoint_http_headers,omitempty"` | |||
There was a problem hiding this comment.
| IgnitionEndpointHTTPHeaders map[string]string `json:"ignition_endpoint_http_headers,omitempty"` | |
| IgnitionEndpointHTTPHeaders map[string]string `json:"ignitionEndpointHttpHeaders,omitempty"` |
There was a problem hiding this comment.
Modified as suggested, thank you!
CrystalChun
force-pushed
the
host-api-changes
branch
from
e3a92e5
to
b192620
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: avishayt, CrystalChun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test edge-subsystem-kubeapi-aws Flaky tests |
|
[ART PR BUILD NOTIFIER] This PR has been included in build ose-agent-installer-api-server-container-v4.16.0-202402070113.p0.g80bb2b2.assembly.stream.el8 for distgit ose-agent-installer-api-server. |
Adds
IgnitionEndpointHTTPHeadersto the host and agent APIs. This allows adding sending additional headers when pulling the ignition from other ignition servers such as the hypershift ignition server. The unstructured string allows for flexibility in case headers need to be added or removed in the future.List all the issues related to this PR
https://issues.redhat.com/browse/MGMT-16649
What environments does this code impact?
How was this code tested?
Checklist
docs, README, etc)Reviewers Checklist