MGMT-16704: Add organization capability to control soft timeouts

[ori-amizur]

We would like to control invocation of soft timeouts based on organizational permissions. Therefore, capability for allowing soft timeouts was added.

This capability is used in conjunction with corresponding soft timeouts environment variable. Soft timeouts will be used for cluster insallation if both it is enabled by the assisted service environment variable and if it is allowed by capability.

List all the issues related to this PR

• New Feature
• Enhancement
• Bug fix
• Tests
• Documentation
• CI/CD

What environments does this code impact?

• Automation (CI, tools, etc)
• Cloud
• Operator Managed Deployments
• None

How was this code tested?

• assisted-test-infra environment
• dev-scripts environment
• Reviewer's test appreciated
• Waiting for CI to do a full test run
• Manual (Elaborate on how it was tested)
• No tests needed

Checklist

• Title and description added to both, commit and PR.
• Relevant issues have been associated (see CONTRIBUTING guide)
• This change does not require a documentation update (docstring, docs, README, etc)
• Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

/cc @gamli75
/cc @jhernand

[openshift-ci-robot]

@ori-amizur: This pull request references MGMT-16704 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to this:

We would like to control invocation of soft timeouts based on organizational permissions. Therefore, capability for allowing soft timeouts was added.

This capability is used in conjunction with corresponding soft timeouts environment variable. Soft timeouts will be used for cluster insallation if both it is enabled by the assisted service environment variable and if it is allowed by capability.

List all the issues related to this PR

• New Feature
• Enhancement
• Bug fix
• Tests
• Documentation
• CI/CD

What environments does this code impact?

• Automation (CI, tools, etc)
• Cloud
• Operator Managed Deployments
• None

How was this code tested?

• assisted-test-infra environment
• dev-scripts environment
• Reviewer's test appreciated
• Waiting for CI to do a full test run
• Manual (Elaborate on how it was tested)
• No tests needed

Checklist

• Title and description added to both, commit and PR.
• Relevant issues have been associated (see CONTRIBUTING guide)
• This change does not require a documentation update (docstring, docs, README, etc)
• Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

/cc @gamli75
/cc @jhernand

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ori-amizur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ori-amizur]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov]

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (df15ca0) 68.26% compared to head (3ff6e0b) 68.40%.
Report is 19 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5935      +/-   ##
==========================================
+ Coverage   68.26%   68.40%   +0.13%     
==========================================
  Files         236      236              
  Lines       34913    35223     +310     
==========================================
+ Hits        23833    24093     +260     
- Misses       9006     9053      +47     
- Partials     2074     2077       +3     

Files	Coverage Δ
internal/bminventory/inventory.go	71.53% <100.00%> (+0.04%)	⬆️
internal/host/conditions.go	100.00% <100.00%> (ø)
internal/cluster/transition.go	75.59% <60.00%> (+1.50%)	⬆️

... and 11 files with indirect coverage changes

[ori-amizur]

/retest

[ori-amizur]

/retest

[ori-amizur]

/retest

[tsorya]

/lgtm

[ori-amizur]

/test e2e-agent-compact-ipv4

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD da7d84e and 2 for PR HEAD 3ff6e0b in total

[openshift-ci]

@ori-amizur: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-agent-installer-api-server-container-v4.16.0-202402090109.p0.gc5959f8.assembly.stream.el8 for distgit ose-agent-installer-api-server.
All builds following this will include this PR.