Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MGMT-16739: CNV and MCE should be disabled when select platform Nutanix #5941

Merged

Conversation

danmanor
Copy link
Contributor

@danmanor danmanor commented Feb 1, 2024

CNV and MCE should be disabled when select platform Nutanix as it is not supported by OCP

List all the issues related to this PR

  • New Feature
  • Enhancement
  • Bug fix
  • Tests
  • Documentation
  • CI/CD

What environments does this code impact?

  • Automation (CI, tools, etc)
  • Cloud
  • Operator Managed Deployments
  • None

How was this code tested?

  • assisted-test-infra environment
  • dev-scripts environment
  • Reviewer's test appreciated
  • Waiting for CI to do a full test run
  • Manual (Elaborate on how it was tested)
  • No tests needed

Checklist

  • Title and description added to both, commit and PR.
  • Relevant issues have been associated (see CONTRIBUTING guide)
  • This change does not require a documentation update (docstring, docs, README, etc)
  • Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

  • Are the title and description (in both PR and commit) meaningful and clear?
  • Is there a bug required (and linked) for this change?
  • Should this PR be backported?

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 1, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 1, 2024

@danmanor: This pull request references MGMT-16739 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

CNV and MCE should be disabled when select platform Nutanix as it is not supported by OCP

List all the issues related to this PR

  • New Feature
  • Enhancement
  • Bug fix
  • Tests
  • Documentation
  • CI/CD

What environments does this code impact?

  • Automation (CI, tools, etc)
  • Cloud
  • Operator Managed Deployments
  • None

How was this code tested?

  • assisted-test-infra environment
  • dev-scripts environment
  • Reviewer's test appreciated
  • Waiting for CI to do a full test run
  • Manual (Elaborate on how it was tested)
  • No tests needed

Checklist

  • Title and description added to both, commit and PR.
  • Relevant issues have been associated (see CONTRIBUTING guide)
  • This change does not require a documentation update (docstring, docs, README, etc)
  • Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

  • Are the title and description (in both PR and commit) meaningful and clear?
  • Is there a bug required (and linked) for this change?
  • Should this PR be backported?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 1, 2024
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 1, 2024
@danmanor
Copy link
Contributor Author

danmanor commented Feb 1, 2024

/cc @gamli75

@openshift-ci openshift-ci bot requested a review from gamli75 February 1, 2024 11:06
@danmanor
Copy link
Contributor Author

danmanor commented Feb 1, 2024

@carbonin @gamli75 @omertuc There is a CI issue at the moment

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 1, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD b7c47f3 and 2 for PR HEAD c67ae1c in total

@gamli75
Copy link
Contributor

gamli75 commented Feb 1, 2024

/retest

4 similar comments
@danmanor
Copy link
Contributor Author

danmanor commented Feb 1, 2024

/retest

@danmanor
Copy link
Contributor Author

danmanor commented Feb 1, 2024

/retest

@danmanor
Copy link
Contributor Author

danmanor commented Feb 1, 2024

/retest

@gamli75
Copy link
Contributor

gamli75 commented Feb 1, 2024

/retest

Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (df15ca0) 68.26% compared to head (d61d1c8) 68.28%.
Report is 2 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5941      +/-   ##
==========================================
+ Coverage   68.26%   68.28%   +0.01%     
==========================================
  Files         236      236              
  Lines       34913    34915       +2     
==========================================
+ Hits        23833    23840       +7     
+ Misses       9006     9002       -4     
+ Partials     2074     2073       -1     
Files Coverage Δ
internal/featuresupport/features_olm_operators.go 86.76% <100.00%> (+4.54%) ⬆️
internal/featuresupport/features_platforms.go 91.01% <100.00%> (+0.05%) ⬆️

... and 3 files with indirect coverage changes

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD f4dd8a1 and 1 for PR HEAD c67ae1c in total

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 3, 2024
Copy link

openshift-ci bot commented Feb 3, 2024

@danmanor: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 4, 2024
Copy link

openshift-ci bot commented Feb 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danmanor, gamli75

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 99a3b96 into openshift:master Feb 4, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants