Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.14] MGMT-16949: Move nodeip-configuration file creation from mc to ignition #5974

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #5926

/assign tsorya

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 11, 2024

@openshift-cherrypick-robot: Ignoring requests to cherry-pick non-bug issues: MGMT-16494

In response to this:

This is an automated cherry-pick of #5926

/assign tsorya

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 11, 2024
@tsorya
Copy link
Contributor

tsorya commented Feb 11, 2024

/test e2e-agent-sno-ipv6

@tsorya
Copy link
Contributor

tsorya commented Feb 11, 2024

/test?

Copy link

openshift-ci bot commented Feb 11, 2024

@tsorya: The following commands are available to trigger required jobs:

  • /test e2e-agent-compact-ipv4
  • /test images

The following commands are available to trigger optional jobs:

  • /test e2e-agent-ha-dualstack
  • /test e2e-agent-sno-ipv6
  • /test push-pr-image

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-assisted-service-release-4.14-e2e-agent-compact-ipv4
  • pull-ci-openshift-assisted-service-release-4.14-images

In response to this:

/test?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eranco74
Copy link
Contributor

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 11, 2024
Copy link

openshift-ci bot commented Feb 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eranco74, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 11, 2024
@gamli75
Copy link
Contributor

gamli75 commented Feb 12, 2024

/test images

@tsorya
Copy link
Contributor

tsorya commented Feb 14, 2024

/retest

@eranco74 eranco74 changed the title [release-4.14] MGMT-16494: Move ip hint file creation to ignition in order to change it in IBI process [release-4.14] MGMT-16949 Move nodeip-configuration file creation from mc to ignition Feb 18, 2024
@eranco74
Copy link
Contributor

/jira refresh

@openshift-ci-robot
Copy link

@eranco74: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@eranco74 eranco74 changed the title [release-4.14] MGMT-16949 Move nodeip-configuration file creation from mc to ignition MGMT-16949 Move nodeip-configuration file creation from mc to ignition [release-4.14] Feb 18, 2024
@eranco74
Copy link
Contributor

/jira refresh

@openshift-ci-robot
Copy link

@eranco74: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@eranco74 eranco74 changed the title MGMT-16949 Move nodeip-configuration file creation from mc to ignition [release-4.14] [release-4.14] MGMT-16949: Move nodeip-configuration file creation from mc to ignition Feb 18, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 18, 2024

@openshift-cherrypick-robot: This pull request references MGMT-16949 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.14.z" version, but no target version was set.

In response to this:

This is an automated cherry-pick of #5926

/assign tsorya

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 18, 2024
Copy link

openshift-ci bot commented Feb 18, 2024

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit ef21bf5 into openshift:release-4.14 Feb 18, 2024
4 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-agent-installer-api-server-container-v4.14.0-202402181139.p0.gef21bf5.assembly.stream.el8 for distgit ose-agent-installer-api-server.
All builds following this will include this PR.

eranco74 added a commit to eranco74/ib-orchestrate-vm that referenced this pull request Feb 28, 2024
This should allow us to update the nodeip-hint since this release
include this fix in the assisted-service/agent-installer:
MGMT-16949: Move nodeip-configuration file creation from mc to ignition
openshift/assisted-service#5974

Signed-off-by: Eran Cohen <eranco@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants