Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.14] MGMT-16517: Add Env Var Deployment Type & Set ABI #5987

Merged
merged 3 commits into from Feb 16, 2024
Merged

[release-4.14] MGMT-16517: Add Env Var Deployment Type & Set ABI #5987

merged 3 commits into from Feb 16, 2024

Conversation

CrystalChun
Copy link
Contributor

@CrystalChun CrystalChun commented Feb 14, 2024 •
edited

Backport of PRs:

  1. NO-ISSUE: Add versions file to onprem event upload #5514 to add the versions file when sending onprem data
  2. MGMT-16517: Add Env Var for On-Prem Data Deployment Type #5874 (https://issues.redhat.com/browse/MGMT-16517) to add environment variable DEPLOYMENT_TYPE
  3. MGMT-16523: Set ABI deployment type for on-prem data collection #5967 (https://issues.redhat.com/browse/MGMT-16523) to set it to ABI when it's an agent-based install

List all the issues related to this PR

  • New Feature
  • Enhancement
  • Bug fix
  • Tests
  • Documentation
  • CI/CD

What environments does this code impact?

  • Automation (CI, tools, etc)
  • Cloud
  • Operator Managed Deployments
  • None

How was this code tested?

  • assisted-test-infra environment
  • dev-scripts environment
  • Reviewer's test appreciated
  • Waiting for CI to do a full test run
  • Manual (Elaborate on how it was tested)
  • No tests needed

Checklist

  • Title and description added to both, commit and PR.
  • Relevant issues have been associated (see CONTRIBUTING guide)
  • This change does not require a documentation update (docstring, docs, README, etc)
  • Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

  • Are the title and description (in both PR and commit) meaningful and clear?
  • Is there a bug required (and linked) for this change?
  • Should this PR be backported?

@CrystalChun
NO-ISSUE: Add versions file to onprem event upload (openshift#5514)
4a46b20
@CrystalChun
MGMT-16517: Add Env Var for On-Prem Data Deployment Type (openshift#5874
b48c666 
)

* MGMT-16517: Add Env Var for On-Prem Data Deployment Type

https://issues.redhat.com/browse/MGMT-16517
Adds the environment variables `DEPLOYMENT_TYPE`
and `DEPLOYMENT_VERSION` to determine how assisted
was deployed. Expected values for deployment type
include ACM, MCE, ABI, podman, standalone operator.

* MGMT-16517: Add Env Var to podman and SaaS templates

https://issues.redhat.com/browse/MGMT-16517
@CrystalChun
MGMT-16523: Set ABI deployment type for on-prem data collection (open…
0ed13d2 
…shift#5967)

https://issues.redhat.com/browse/MGMT-16523
The agent team sets the env var INSTALL_INVOKER to "agent-installer"
during their deployment. This can be used to determine that it's
an ABI deployment in our on-prem data collection.
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 14, 2024 •
edited by openshift-ci bot

@CrystalChun: This pull request references MGMT-16517 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.14.z" version, but no target version was set.

In response to this:

Backport of PRs:

  1. NO-ISSUE: Add versions file to onprem event upload #5514 to add the versions file
  2. MGMT-16517: Add Env Var for On-Prem Data Deployment Type #5874 (https://issues.redhat.com/browse/MGMT-16517) to add environment variable DEPLOYMENT_TYPE
  3. MGMT-16523: Set ABI deployment type for on-prem data collection #5967 (https://issues.redhat.com/browse/MGMT-16523) to set it to ABI when it's an agent-based install

List all the issues related to this PR

  • New Feature
  • Enhancement
  • Bug fix
  • Tests
  • Documentation
  • CI/CD

What environments does this code impact?

  • Automation (CI, tools, etc)
  • Cloud
  • Operator Managed Deployments
  • None

How was this code tested?

  • assisted-test-infra environment
  • dev-scripts environment
  • Reviewer's test appreciated
  • Waiting for CI to do a full test run
  • Manual (Elaborate on how it was tested)
  • No tests needed

Checklist

  • Title and description added to both, commit and PR.
  • Relevant issues have been associated (see CONTRIBUTING guide)
  • This change does not require a documentation update (docstring, docs, README, etc)
  • Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

  • Are the title and description (in both PR and commit) meaningful and clear?
  • Is there a bug required (and linked) for this change?
  • Should this PR be backported?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 14, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 14, 2024 •
edited by openshift-ci bot

@CrystalChun: This pull request references MGMT-16517 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.14.z" version, but no target version was set.

In response to this:

Backport of PRs:

  1. NO-ISSUE: Add versions file to onprem event upload #5514 to add the versions file when sending onprem data
  2. MGMT-16517: Add Env Var for On-Prem Data Deployment Type #5874 (https://issues.redhat.com/browse/MGMT-16517) to add environment variable DEPLOYMENT_TYPE
  3. MGMT-16523: Set ABI deployment type for on-prem data collection #5967 (https://issues.redhat.com/browse/MGMT-16523) to set it to ABI when it's an agent-based install

List all the issues related to this PR

  • New Feature
  • Enhancement
  • Bug fix
  • Tests
  • Documentation
  • CI/CD

What environments does this code impact?

  • Automation (CI, tools, etc)
  • Cloud
  • Operator Managed Deployments
  • None

How was this code tested?

  • assisted-test-infra environment
  • dev-scripts environment
  • Reviewer's test appreciated
  • Waiting for CI to do a full test run
  • Manual (Elaborate on how it was tested)
  • No tests needed

Checklist

  • Title and description added to both, commit and PR.
  • Relevant issues have been associated (see CONTRIBUTING guide)
  • This change does not require a documentation update (docstring, docs, README, etc)
  • Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

  • Are the title and description (in both PR and commit) meaningful and clear?
  • Is there a bug required (and linked) for this change?
  • Should this PR be backported?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@CrystalChun
Copy link
Contributor Author

/cc @gamli75 @zaneb

@openshift-ci openshift-ci bot requested review from gamli75 and zaneb February 14, 2024 18:46
@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 14, 2024
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 14, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 14, 2024

@CrystalChun: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 16, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CrystalChun, osherdp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [CrystalChun,osherdp]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 023071e into openshift:release-4.14 Feb 16, 2024
5 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-agent-installer-api-server-container-v4.14.0-202402161139.p0.g023071e.assembly.stream.el8 for distgit ose-agent-installer-api-server.
All builds following this will include this PR.

@CrystalChun CrystalChun mentioned this pull request Feb 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osherdp osherdp osherdp approved these changes

@gamli75 gamli75 Awaiting requested review from gamli75

@zaneb zaneb Awaiting requested review from zaneb

@avishayt avishayt Awaiting requested review from avishayt

Assignees

@osherdp osherdp

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@CrystalChun @openshift-ci-robot @openshift-bot @osherdp