New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NO-ISSUE: Fix subsystem test for invalid nmstate config error message #5988
NO-ISSUE: Fix subsystem test for invalid nmstate config error message #5988
Conversation
The error message for an invalid nmstate config has changed from containing "Unsupported keys found" to "Invalid YAML string: unknown field". See kubeapi subsystem test history for failing tests https://prow.ci.openshift.org/job-history/gs/test-platform-results/pr-logs/directory/pull-ci-openshift-assisted-service-master-edge-subsystem-kubeapi-aws
@CrystalChun: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CrystalChun, gamli75 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5988 +/- ##
=======================================
Coverage 68.30% 68.31%
=======================================
Files 236 236
Lines 35113 35113
=======================================
+ Hits 23984 23986 +2
+ Misses 9050 9049 -1
+ Partials 2079 2078 -1 |
@CrystalChun: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
[ART PR BUILD NOTIFIER] This PR has been included in build ose-agent-installer-api-server-container-v4.16.0-202402150209.p0.gf40deb8.assembly.stream.el8 for distgit ose-agent-installer-api-server. |
The error message for an invalid nmstate config has changed from containing "Unsupported keys found" to "Invalid YAML string: unknown field". See kubeapi subsystem test history for failing tests https://prow.ci.openshift.org/job-history/gs/test-platform-results/pr-logs/directory/pull-ci-openshift-assisted-service-master-edge-subsystem-kubeapi-aws
List all the issues related to this PR
What environments does this code impact?
How was this code tested?
Checklist
docs
, README, etc)Reviewers Checklist
/cc @gamli75