Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "MGMT-16262: Create a utility that fetches current OCP releases from OpenShift API and updates DB (#5916)" #6033

Closed
wants to merge 3 commits into from
Closed

Revert "MGMT-16262: Create a utility that fetches current OCP releases from OpenShift API and updates DB (#5916)" #6033

wants to merge 3 commits into from

Conversation

danmanor
Copy link
Contributor

@danmanor danmanor commented Feb 28, 2024 •
edited by openshift-ci bot

Revert "MGMT-16262: Create a utility that fetches current OCP releases from OpenShift API and updates DB (#5916)"

List all the issues related to this PR

  • New Feature
  • Enhancement
  • Bug fix
  • Tests
  • Documentation
  • CI/CD

What environments does this code impact?

  • Automation (CI, tools, etc)
  • Cloud
  • Operator Managed Deployments
  • None

How was this code tested?

  • assisted-test-infra environment
  • dev-scripts environment
  • Reviewer's test appreciated
  • Waiting for CI to do a full test run
  • Manual (Elaborate on how it was tested)
  • No tests needed

Checklist

  • Title and description added to both, commit and PR.
  • Relevant issues have been associated (see CONTRIBUTING guide)
  • This change does not require a documentation update (docstring, docs, README, etc)
  • Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

  • Are the title and description (in both PR and commit) meaningful and clear?
  • Is there a bug required (and linked) for this change?
  • Should this PR be backported?

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 28, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 28, 2024 •
edited by openshift-ci bot

@danmanor: This pull request references MGMT-16262 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.16.0" version, but no target version was set.

In response to this:

Revert "MGMT-16262: Create a utility that fetches current OCP releases from OpenShift API and updates DB (#5916)"

List all the issues related to this PR

  • New Feature
  • Enhancement
  • Bug fix
  • Tests
  • Documentation
  • CI/CD

What environments does this code impact?

  • Automation (CI, tools, etc)
  • Cloud
  • Operator Managed Deployments
  • None

How was this code tested?

  • assisted-test-infra environment
  • dev-scripts environment
  • Reviewer's test appreciated
  • Waiting for CI to do a full test run
  • Manual (Elaborate on how it was tested)
  • No tests needed

Checklist

  • Title and description added to both, commit and PR.
  • Relevant issues have been associated (see CONTRIBUTING guide)
  • This change does not require a documentation update (docstring, docs, README, etc)
  • Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

  • Are the title and description (in both PR and commit) meaningful and clear?
  • Is there a bug required (and linked) for this change?
  • Should this PR be backported?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 28, 2024
@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 28, 2024 •
edited by openshift-ci bot

@danmanor: This pull request references MGMT-16262 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.16.0" version, but no target version was set.

In response to this:

Revert "MGMT-16262: Create a utility that fetches current OCP releases from OpenShift API and updates DB (#5916)"

List all the issues related to this PR

  • New Feature
  • Enhancement
  • Bug fix
  • Tests
  • Documentation
  • CI/CD

What environments does this code impact?

  • Automation (CI, tools, etc)
  • Cloud
  • Operator Managed Deployments
  • None

How was this code tested?

  • assisted-test-infra environment
  • dev-scripts environment
  • Reviewer's test appreciated
  • Waiting for CI to do a full test run
  • Manual (Elaborate on how it was tested)
  • No tests needed

Checklist

  • Title and description added to both, commit and PR.
  • Relevant issues have been associated (see CONTRIBUTING guide)
  • This change does not require a documentation update (docstring, docs, README, etc)
  • Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

  • Are the title and description (in both PR and commit) meaningful and clear?
  • Is there a bug required (and linked) for this change?
  • Should this PR be backported?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@danmanor danmanor closed this Feb 28, 2024
@openshift-ci openshift-ci bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 28, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 28, 2024

@danmanor: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/edge-e2e-ai-operator-ztp-capi f38ec80 link false /test edge-e2e-ai-operator-ztp-capi
ci/prow/edge-unit-test f38ec80 link true /test edge-unit-test
ci/prow/edge-ci-index f38ec80 link true /test edge-ci-index
ci/prow/edge-e2e-ai-operator-ztp f38ec80 link true /test edge-e2e-ai-operator-ztp
ci/prow/edge-e2e-ai-operator-ztp-disconnected f38ec80 link false /test edge-e2e-ai-operator-ztp-disconnected
ci/prow/edge-lint f38ec80 link true /test edge-lint
ci/prow/edge-subsystem-aws f38ec80 link true /test edge-subsystem-aws
ci/prow/edge-verify-generated-code f38ec80 link true /test edge-verify-generated-code
ci/prow/edge-e2e-ai-operator-disconnected-capi f38ec80 link false /test edge-e2e-ai-operator-disconnected-capi
ci/prow/e2e-agent-compact-ipv4 f38ec80 link false /test e2e-agent-compact-ipv4
ci/prow/edge-e2e-metal-assisted f38ec80 link true /test edge-e2e-metal-assisted
ci/prow/edge-images f38ec80 link true /test edge-images
ci/prow/images f38ec80 link true /test images
ci/prow/edge-subsystem-kubeapi-aws f38ec80 link true /test edge-subsystem-kubeapi-aws
ci/prow/mce-images f38ec80 link true /test mce-images
ci/prow/edge-assisted-operator-catalog-publish-verify f38ec80 link true /test edge-assisted-operator-catalog-publish-verify
ci/prow/edge-e2e-ai-operator-ztp-3masters f38ec80 link false /test edge-e2e-ai-operator-ztp-3masters

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot added the api-review Categorizes an issue or PR as actively needing an API review. label Feb 28, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danmanor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omertuc omertuc Awaiting requested review from omertuc

@osherdp osherdp Awaiting requested review from osherdp

Assignees
No one assigned
Labels
api-review Categorizes an issue or PR as actively needing an API review. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@danmanor @openshift-ci-robot @openshift-merge-robot @adriengentil