Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MGMT-16620: Update OCP 4.15 GA in release images #6035

Merged
merged 1 commit into from Feb 29, 2024

Conversation

danmanor
Copy link
Contributor

List all the issues related to this PR

  • New Feature
  • Enhancement
  • Bug fix
  • Tests
  • Documentation
  • CI/CD

What environments does this code impact?

  • Automation (CI, tools, etc)
  • Cloud
  • Operator Managed Deployments
  • None

How was this code tested?

  • assisted-test-infra environment
  • dev-scripts environment
  • Reviewer's test appreciated
  • Waiting for CI to do a full test run
  • Manual (Elaborate on how it was tested)
  • No tests needed

Checklist

  • Title and description added to both, commit and PR.
  • Relevant issues have been associated (see CONTRIBUTING guide)
  • This change does not require a documentation update (docstring, docs, README, etc)
  • Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

  • Are the title and description (in both PR and commit) meaningful and clear?
  • Is there a bug required (and linked) for this change?
  • Should this PR be backported?

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 28, 2024
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 28, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 28, 2024
Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.40%. Comparing base (977b53b) to head (ffc11d6).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6035   +/-   ##
=======================================
  Coverage   68.39%   68.40%           
=======================================
  Files         239      239           
  Lines       35454    35454           
=======================================
+ Hits        24250    24251    +1     
  Misses       9099     9099           
+ Partials     2105     2104    -1     

see 2 files with indirect coverage changes

@danmanor
Copy link
Contributor Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 28, 2024
@adriengentil
Copy link
Contributor

/retest

@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 28, 2024
@danmanor danmanor force-pushed the 415-ga branch 2 times, most recently from 81df5e3 to 5dd0598 Compare February 29, 2024 08:56
Copy link

openshift-ci bot commented Feb 29, 2024

@danmanor: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-agent-compact-ipv4 ffc11d6 link false /test e2e-agent-compact-ipv4

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@danmanor
Copy link
Contributor Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 29, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 29, 2024
Copy link

openshift-ci bot commented Feb 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adriengentil, danmanor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [adriengentil,danmanor]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@danmanor
Copy link
Contributor Author

/override ci/prow/e2e-compact-agent-ipv4

Copy link

openshift-ci bot commented Feb 29, 2024

@danmanor: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • ci/prow/e2e-compact-agent-ipv4

Only the following failed contexts/checkruns were expected:

  • ci/prow/e2e-agent-compact-ipv4
  • ci/prow/edge-ci-index
  • ci/prow/edge-e2e-ai-operator-ztp
  • ci/prow/edge-e2e-metal-assisted
  • ci/prow/edge-e2e-metal-assisted-bond
  • ci/prow/edge-e2e-metal-assisted-bond-4-14
  • ci/prow/edge-e2e-metal-assisted-day2
  • ci/prow/edge-e2e-metal-assisted-day2-single-node
  • ci/prow/edge-e2e-metal-assisted-ipv4v6
  • ci/prow/edge-e2e-metal-assisted-single-node
  • ci/prow/edge-e2e-metal-assisted-static-ip-suite
  • ci/prow/edge-e2e-metal-assisted-static-ip-suite-4-14
  • ci/prow/edge-images
  • ci/prow/edge-lint
  • ci/prow/edge-subsystem-aws
  • ci/prow/edge-subsystem-kubeapi-aws
  • ci/prow/edge-unit-test
  • ci/prow/edge-verify-generated-code
  • ci/prow/images
  • ci/prow/mce-images
  • pull-ci-openshift-assisted-service-cloud_hotfix_releases-images
  • pull-ci-openshift-assisted-service-master-e2e-agent-compact-ipv4
  • pull-ci-openshift-assisted-service-master-edge-ci-index
  • pull-ci-openshift-assisted-service-master-edge-e2e-ai-operator-ztp
  • pull-ci-openshift-assisted-service-master-edge-e2e-metal-assisted
  • pull-ci-openshift-assisted-service-master-edge-e2e-metal-assisted-bond
  • pull-ci-openshift-assisted-service-master-edge-e2e-metal-assisted-bond-4-14
  • pull-ci-openshift-assisted-service-master-edge-e2e-metal-assisted-day2
  • pull-ci-openshift-assisted-service-master-edge-e2e-metal-assisted-day2-single-node
  • pull-ci-openshift-assisted-service-master-edge-e2e-metal-assisted-ipv4v6
  • pull-ci-openshift-assisted-service-master-edge-e2e-metal-assisted-single-node
  • pull-ci-openshift-assisted-service-master-edge-e2e-metal-assisted-static-ip-suite
  • pull-ci-openshift-assisted-service-master-edge-e2e-metal-assisted-static-ip-suite-4-14
  • pull-ci-openshift-assisted-service-master-edge-images
  • pull-ci-openshift-assisted-service-master-edge-lint
  • pull-ci-openshift-assisted-service-master-edge-subsystem-aws
  • pull-ci-openshift-assisted-service-master-edge-subsystem-kubeapi-aws
  • pull-ci-openshift-assisted-service-master-edge-unit-test
  • pull-ci-openshift-assisted-service-master-edge-verify-generated-code
  • pull-ci-openshift-assisted-service-master-mce-images
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override ci/prow/e2e-compact-agent-ipv4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@danmanor
Copy link
Contributor Author

override ci/prow/e2e-agent-compact-ipv4

@adriengentil
Copy link
Contributor

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 29, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 29, 2024

@adriengentil: This pull request references MGMT-16620 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot openshift-merge-bot bot merged commit f208430 into openshift:master Feb 29, 2024
21 of 22 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-agent-installer-api-server-container-v4.16.0-202402291846.p0.gf208430.assembly.stream.el8 for distgit ose-agent-installer-api-server.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants