MGMT-16759: Copy cluster proxy settings to imported local-cluster AgentCluster Install

[paul-maidment]

The settings for HTTPProxy and HTTPSProxy should be copied to the AgentClusterInstall that is created during the import of the local cluster.
This PR ensures that this takes place.

List all the issues related to this PR

• New Feature
• Enhancement
• Bug fix
• Tests
• Documentation
• CI/CD

What environments does this code impact?

• Automation (CI, tools, etc)
• Cloud
• Operator Managed Deployments
• None

How was this code tested?

• assisted-test-infra environment
• dev-scripts environment
• Reviewer's test appreciated
• Waiting for CI to do a full test run
• Manual (Elaborate on how it was tested)
• No tests needed

Checklist

• Title and description added to both, commit and PR.
• Relevant issues have been associated (see CONTRIBUTING guide)
• This change does not require a documentation update (docstring, docs, README, etc)
• Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

[openshift-ci-robot]

@paul-maidment: This pull request references MGMT-16759 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

The local cluster settings for HTTPProxy and HTTPSProxy should be copied to the AgentClusterInstall This PR ensures that this takes place.

List all the issues related to this PR

• New Feature
• Enhancement
• Bug fix
• Tests
• Documentation
• CI/CD

What environments does this code impact?

• Automation (CI, tools, etc)
• Cloud
• Operator Managed Deployments
• None

How was this code tested?

• assisted-test-infra environment
• dev-scripts environment
• Reviewer's test appreciated
• Waiting for CI to do a full test run
• Manual (Elaborate on how it was tested)
• No tests needed

Checklist

• Title and description added to both, commit and PR.
• Relevant issues have been associated (see CONTRIBUTING guide)
• This change does not require a documentation update (docstring, docs, README, etc)
• Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[codecov]

Codecov Report

Attention: Patch coverage is 58.62069% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 68.28%. Comparing base (ffc9aef) to head (76e54ae).
Report is 5 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #6051      +/-   ##
==========================================
- Coverage   68.39%   68.28%   -0.12%     
==========================================
  Files         239      239              
  Lines       35454    35560     +106     
==========================================
+ Hits        24249    24281      +32     
- Misses       9100     9175      +75     
+ Partials     2105     2104       -1     

Files	Coverage Δ
...oller/controllers/agentserviceconfig_controller.go	85.20% <ø> (ø)
...terimport/local_cluster_import_operations_mocks.go	78.74% <100.00%> (+1.62%)	⬆️
pkg/localclusterimport/import_local_cluster.go	83.41% <72.72%> (-0.80%)	⬇️
...alclusterimport/local_cluster_import_operations.go	0.00% <0.00%> (ø)

... and 5 files with indirect coverage changes

[paul-maidment]

Looks like edge-e2e-ai-operator-disconnected-capi is generally broken for others too, so not failing due to any issues in this PR.

[paul-maidment]

/override pull-ci-openshift-assisted-service-master-edge-e2e-ai-operator-disconnected-capi

[paul-maidment]

/override ci/prow/edge-e2e-ai-operator-disconnected-capi

[openshift-ci]

@paul-maidment: Overrode contexts on behalf of paul-maidment: ci/prow/edge-e2e-ai-operator-disconnected-capi

In response to this:

/override pull-ci-openshift-assisted-service-master-edge-e2e-ai-operator-disconnected-capi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@paul-maidment: Overrode contexts on behalf of paul-maidment: ci/prow/edge-e2e-ai-operator-disconnected-capi

In response to this:

/override ci/prow/edge-e2e-ai-operator-disconnected-capi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[eranco74]

Why would we want this behavior?
What if the spoke cluster should use a different proxy?
If the spoke cluster requires a proxy the user can provide it explicitly.
NM, I now notice that this behavior is for imported cluster, please make it clear in the commit message.
Otherwise, LGTM

[openshift-ci-robot]

@paul-maidment: This pull request references MGMT-16759 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

The settings for HTTPProxy and HTTPSProxy should be copied to the AgentClusterInstall that is created during the import of the local cluster.
This PR ensures that this takes place.

List all the issues related to this PR

• New Feature
• Enhancement
• Bug fix
• Tests
• Documentation
• CI/CD

What environments does this code impact?

• Automation (CI, tools, etc)
• Cloud
• Operator Managed Deployments
• None

How was this code tested?

• assisted-test-infra environment
• dev-scripts environment
• Reviewer's test appreciated
• Waiting for CI to do a full test run
• Manual (Elaborate on how it was tested)
• No tests needed

Checklist

• Title and description added to both, commit and PR.
• Relevant issues have been associated (see CONTRIBUTING guide)
• This change does not require a documentation update (docstring, docs, README, etc)
• Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[paul-maidment]

Why would we want this behavior? What if the spoke cluster should use a different proxy? If the spoke cluster requires a proxy the user can provide it explicitly. NM, I now notice that this behavior is for imported cluster, please make it clear in the commit message. Otherwise, LGTM

Done. Description and title updated in the PR and commit.

[CrystalChun]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CrystalChun, paul-maidment

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [CrystalChun,paul-maidment]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@paul-maidment: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-agent-installer-api-server-container-v4.16.0-202403120045.p0.gf24b433.assembly.stream.el8 for distgit ose-agent-installer-api-server.
All builds following this will include this PR.