MGMT-17106: Disable ironic vlan creation when static networking config is present

[carbonin]

Previously the ironic agent would define vlan interfaces when it
detected that vlans were present using LLDP

This change only allows this type of reconfiguration if the user didn't
provide static networking config. If a user does provide static
networking config and requires vlans it's expected that they will
configure them manually rather than relying on LLDP-based configuration
from the ironic agent.

This also requires new ICC code to vendor in the change to accept this
parameter when we create the ironic agent ignition.

List all the issues related to this PR

Resolves https://issues.redhat.com/browse/MGMT-17106

• New Feature
• Enhancement
• Bug fix
• Tests
• Documentation
• CI/CD

What environments does this code impact?

• Automation (CI, tools, etc)
• Cloud
• Operator Managed Deployments
• None

How was this code tested?

• assisted-test-infra environment
• dev-scripts environment
• Reviewer's test appreciated
• Waiting for CI to do a full test run
• Manual (Elaborate on how it was tested)
• No tests needed

I don't have the environment to test this, unit tests are all I can do for now.
CI will catch any potential regressions and hopefully QE has the kind of environment required to actually test it.

Checklist

• Title and description added to both, commit and PR.
• Relevant issues have been associated (see [CONTRIBUTING] guide)
• This change does not require a documentation update (docstring, docs, README, etc)
• Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: carbonin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [carbonin]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@carbonin: This pull request references MGMT-17106 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

Previously the ironic agent would define vlan interfaces when it
detected that vlans were present using LLDP

This change only allows this type of reconfiguration if the user didn't
provide static networking config. If a user does provide static
networking config and requires vlans it's expected that they will
configure them manually rather than relying on LLDP-based configuration
from the ironic agent.

This also requires new ICC code to vendor in the change to accept this
parameter when we create the ironic agent ignition.

List all the issues related to this PR

Resolves https://issues.redhat.com/browse/MGMT-17106

• New Feature
• Enhancement
• Bug fix
• Tests
• Documentation
• CI/CD

What environments does this code impact?

• Automation (CI, tools, etc)
• Cloud
• Operator Managed Deployments
• None

How was this code tested?

• assisted-test-infra environment
• dev-scripts environment
• Reviewer's test appreciated
• Waiting for CI to do a full test run
• Manual (Elaborate on how it was tested)
• No tests needed

I don't have the environment to test this, unit tests are all I can do for now.
CI will catch any potential regressions and hopefully QE has the kind of environment required to actually test it.

Checklist

• Title and description added to both, commit and PR.
• Relevant issues have been associated (see [CONTRIBUTING] guide)
• This change does not require a documentation update (docstring, docs, README, etc)
• Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.40%. Comparing base (97daf5f) to head (ccb68ea).
Report is 2 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #6055      +/-   ##
==========================================
+ Coverage   68.39%   68.40%   +0.01%     
==========================================
  Files         239      239              
  Lines       35454    35457       +3     
==========================================
+ Hits        24247    24253       +6     
+ Misses       9101     9099       -2     
+ Partials     2106     2105       -1     

Files	Coverage Δ
internal/ignition/ironic.go	100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

[eifrach]

/lgtm

[openshift-ci]

@carbonin: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-agent-installer-api-server-container-v4.16.0-202403061739.p0.g3864109.assembly.stream.el8 for distgit ose-agent-installer-api-server.
All builds following this will include this PR.

[gamli75]

/cherry-pick release-ocm-2.10

[openshift-cherrypick-robot]

@gamli75: new pull request created: #6081

In response to this:

/cherry-pick release-ocm-2.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.