[release-ocm-2.10] MGMT-17131: Use all cluster networks to determine IP family for ironic #6057
Conversation
Before this, when deploying an IPv6 spoke from a dualstack hub only the machine network was being used to determine the address family of the spoke cluster. This was an issue because the machine network is not generally set until after hosts are discovered. This change uses all the cluster networks to determine the address family and should allow the preprovisioning image controller to correctly determine the IP family and set the ironic and inspector urls accordingly. Resolves https://issues.redhat.com/browse/MGMT-16814
|
@openshift-cherrypick-robot: Ignoring requests to cherry-pick non-bug issues: MGMT-16814 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
size/XS
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-ocm-2.10 #6057 +/- ##
=================================================
Coverage 68.29% 68.30%
=================================================
Files 237 237
Lines 35115 35115
=================================================
+ Hits 23982 23984 +2
+ Misses 9058 9057 -1
+ Partials 2075 2074 -1
|
|
/retest-required |
|
@openshift-cherrypick-robot: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
carbonin
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@openshift-cherrypick-robot: This pull request references MGMT-17131 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gamli75, openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
openshift-merge-bot
bot
merged commit 0122114
into
openshift:release-ocm-2.10
This is an automated cherry-pick of #6048
/assign gamli75