Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NO-ISSUE: Docs - clarifying consequences of capabilities override #6060

Merged
merged 1 commit into from Mar 12, 2024
Merged

NO-ISSUE: Docs - clarifying consequences of capabilities override #6060

merged 1 commit into from Mar 12, 2024

Conversation

omertuc
Copy link
Contributor

@omertuc omertuc commented Mar 6, 2024 •
edited

Disabling capabilities could cause problems in some situations, e.g. disabling the baremetal-operator on a baremetal platform cluster will cause installation to fail. The docs should be more clear about these consequences.

Mar 06 15:38:49 master1 bootkube.sh[5424]: "99_openshift-cluster-api_master-machines-0.yaml": failed to create machines.v1beta1.machine.openshift.io/minimal-xkgn9-master-0 -n openshift-machine-api: the server could not find the requested resource

List all the issues related to this PR

  • New Feature
  • Enhancement
  • Bug fix
  • Tests
  • Documentation
  • CI/CD

What environments does this code impact?

  • Automation (CI, tools, etc)
  • Cloud
  • Operator Managed Deployments
  • None

How was this code tested?

  • assisted-test-infra environment
  • dev-scripts environment
  • Reviewer's test appreciated
  • Waiting for CI to do a full test run
  • Manual (Elaborate on how it was tested)
  • No tests needed

Checklist

  • Title and description added to both, commit and PR.
  • Relevant issues have been associated (see CONTRIBUTING guide)
  • This change does not require a documentation update (docstring, docs, README, etc)
  • Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

  • Are the title and description (in both PR and commit) meaningful and clear?
  • Is there a bug required (and linked) for this change?
  • Should this PR be backported?

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 6, 2024
@openshift-ci openshift-ci bot requested review from eifrach and osherdp March 6, 2024 16:35
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 6, 2024
@eifrach
Copy link
Contributor

eifrach commented Mar 7, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 7, 2024
osherdp
osherdp reviewed Mar 11, 2024
View reviewed changes
docs/user-guide/install-customization.md
The `CVO`, will then calculate the effective status, that means, based on the [axioms](https://github.com/openshift/enhancements/blob/master/enhancements/installer/component-selection.md#axioms), CVO will allow to have them disabled at install time or still install them based on requirements, etc. Note that axioms will help in day-2 behaviors, for an installation, it will install the components not excluded or the required ones for dependencies.
See https://docs.openshift.com/container-platform/latest/installing/cluster-capabilities.html for more information.

Note that disabling capabilities could cause problems in some situations, e.g. disabling the baremetal-operator on a baremetal platform cluster will cause installation to fail.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Note that disabling capabilities could cause problems in some situations, e.g. disabling the baremetal-operator on a baremetal platform cluster will cause installation to fail.
> [!IMPORTANT]
> Disabling capabilities could cause problems in some situations, e.g. disabling the baremetal-operator on a baremetal platform cluster will cause installation to fail.

Never tried it, but it should display that part in a clearer way at GitHub.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Seems to work

@omertuc omertuc force-pushed the capdoc branch 2 times, most recently from 307eb20 to 6492159 Compare March 12, 2024 08:38
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 12, 2024
@omertuc omertuc changed the title Docs - clarifying consequences of capabilities override NO-ISSUE: Docs - clarifying consequences of capabilities override Mar 12, 2024
@openshift-ci-robot
Copy link

@omertuc: This pull request explicitly references no jira issue.

In response to this:

Disabling capabilities could cause problems in some situations, e.g. disabling the baremetal-operator on a baremetal platform cluster will cause installation to fail. The docs should be more clear about these consequences.

Mar 06 15:38:49 master1 bootkube.sh[5424]: "99_openshift-cluster-api_master-machines-0.yaml": failed to create machines.v1beta1.machine.openshift.io/minimal-xkgn9-master-0 -n openshift-machine-api: the server could not find the requested resource

List all the issues related to this PR

  • New Feature
  • Enhancement
  • Bug fix
  • Tests
  • Documentation
  • CI/CD

What environments does this code impact?

  • Automation (CI, tools, etc)
  • Cloud
  • Operator Managed Deployments
  • None

How was this code tested?

  • assisted-test-infra environment
  • dev-scripts environment
  • Reviewer's test appreciated
  • Waiting for CI to do a full test run
  • Manual (Elaborate on how it was tested)
  • No tests needed

Checklist

  • Title and description added to both, commit and PR.
  • Relevant issues have been associated (see CONTRIBUTING guide)
  • This change does not require a documentation update (docstring, docs, README, etc)
  • Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

  • Are the title and description (in both PR and commit) meaningful and clear?
  • Is there a bug required (and linked) for this change?
  • Should this PR be backported?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 12, 2024
@omertuc
NO-ISSUE: Docs - clarifying consequences of capabilities override
87d50df 
Disabling capabilities could cause problems in some situations, e.g.
disabling the baremetal-operator on a baremetal platform cluster will
cause installation to fail. The docs should be more clear about these
consequences.

```
Mar 06 15:38:49 master1 bootkube.sh[5424]: "99_openshift-cluster-api_master-machines-0.yaml": failed to create machines.v1beta1.machine.openshift.io/minimal-xkgn9-master-0 -n openshift-machine-api: the server could not find the requested resource
```
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Mar 12, 2024

@omertuc: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 12, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Mar 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: omertuc, osherdp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 0eb2aee into openshift:master Mar 12, 2024
6 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-agent-installer-api-server-container-v4.16.0-202403121016.p0.g0eb2aee.assembly.stream.el8 for distgit ose-agent-installer-api-server.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osherdp osherdp osherdp approved these changes

@eifrach eifrach Awaiting requested review from eifrach

Assignees

@osherdp osherdp

@eifrach eifrach

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@omertuc @eifrach @openshift-ci-robot @openshift-bot @osherdp