Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AGENT-860: Update configure command to handle multiple HostConfigs #6062

Merged
merged 1 commit into from Mar 15, 2024

Conversation

rwsu
Copy link
Contributor

@rwsu rwsu commented Mar 6, 2024

for day-2/addnodes workflow.

Updated the LoadHostConfigs function to only load the current host's HostConfig if the workflow is addnodes.

Only the current host's HostConfig is needed because each host in the addnodes workflow has its own assisted-service. Loading other node's HostConfigs would cause the apply-host-config service to continually wait for other hosts to register with assisted-service because each node is added in isolation.

List all the issues related to this PR

  • New Feature
  • Enhancement
  • Bug fix
  • Tests
  • Documentation
  • CI/CD

What environments does this code impact?

  • Automation (CI, tools, etc)
  • Cloud
  • Operator Managed Deployments
  • None

How was this code tested?

  • assisted-test-infra environment
  • dev-scripts environment
  • Reviewer's test appreciated
  • Waiting for CI to do a full test run
  • Manual (Elaborate on how it was tested) - Tested using ABI with the addnodes workflow currently being developed.
  • [] No tests needed

Checklist

  • Title and description added to both, commit and PR.
  • Relevant issues have been associated (see CONTRIBUTING guide)
  • This change does not require a documentation update (docstring, docs, README, etc)
  • Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

  • Are the title and description (in both PR and commit) meaningful and clear?
  • Is there a bug required (and linked) for this change?
  • Should this PR be backported?

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 6, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 6, 2024

@rwsu: This pull request references AGENT-860 which is a valid jira issue.

In response to this:

for day-2/addnodes workflow.

Updated the LoadHostConfigs function to only load the current host's HostConfig if the workflow is addnodes.

Only the current host's HostConfig is needed because each host in the addnodes workflow has its own assisted-service. Loading other node's HostConfigs would cause the apply-host-config service to continually wait for other hosts to register with assisted-service because each node is added in isolation.

List all the issues related to this PR

  • New Feature
  • Enhancement
  • Bug fix
  • Tests
  • Documentation
  • CI/CD

What environments does this code impact?

  • Automation (CI, tools, etc)
  • Cloud
  • Operator Managed Deployments
  • None

How was this code tested?

  • assisted-test-infra environment
  • dev-scripts environment
  • Reviewer's test appreciated
  • Waiting for CI to do a full test run
  • Manual (Elaborate on how it was tested) - Tested using ABI with the addnodes workflow currently being developed.
  • [] No tests needed

Checklist

  • Title and description added to both, commit and PR.
  • Relevant issues have been associated (see CONTRIBUTING guide)
  • This change does not require a documentation update (docstring, docs, README, etc)
  • Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

  • Are the title and description (in both PR and commit) meaningful and clear?
  • Is there a bug required (and linked) for this change?
  • Should this PR be backported?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 6, 2024
Copy link

openshift-ci bot commented Mar 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rwsu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 6, 2024
Copy link

codecov bot commented Mar 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 68.55%. Comparing base (3864109) to head (9b1dd06).
Report is 12 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6062      +/-   ##
==========================================
+ Coverage   68.40%   68.55%   +0.15%     
==========================================
  Files         239      239              
  Lines       35457    36175     +718     
==========================================
+ Hits        24253    24801     +548     
- Misses       9099     9233     +134     
- Partials     2105     2141      +36     
Files Coverage Δ
cmd/agentbasedinstaller/host_config.go 0.00% <0.00%> (ø)

... and 10 files with indirect coverage changes

cmd/agentbasedinstaller/client/main.go Outdated Show resolved Hide resolved
cmd/agentbasedinstaller/host_config.go Outdated Show resolved Hide resolved
cmd/agentbasedinstaller/host_config.go Outdated Show resolved Hide resolved
cmd/agentbasedinstaller/host_config.go Outdated Show resolved Hide resolved
for day-2/addnodes workflow.

Updated the LoadHostConfigs function to only load the current
host's HostConfig if the workflow is addnodes.

Only the current host's HostConfig is needed because each host in
the addnodes workflow has its own assisted-service. Loading other
node's HostConfigs would cause the apply-host-config service
to continually wait for other hosts to register with assisted-service
because each node is added in isolation.
@andfasano
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 15, 2024
Copy link

openshift-ci bot commented Mar 15, 2024

@rwsu: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 1a4191c into openshift:master Mar 15, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants