New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AGENT-860: Update configure command to handle multiple HostConfigs #6062
AGENT-860: Update configure command to handle multiple HostConfigs #6062
Conversation
@rwsu: This pull request references AGENT-860 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rwsu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6062 +/- ##
==========================================
+ Coverage 68.40% 68.55% +0.15%
==========================================
Files 239 239
Lines 35457 36175 +718
==========================================
+ Hits 24253 24801 +548
- Misses 9099 9233 +134
- Partials 2105 2141 +36
|
for day-2/addnodes workflow. Updated the LoadHostConfigs function to only load the current host's HostConfig if the workflow is addnodes. Only the current host's HostConfig is needed because each host in the addnodes workflow has its own assisted-service. Loading other node's HostConfigs would cause the apply-host-config service to continually wait for other hosts to register with assisted-service because each node is added in isolation.
d2359ab
to
9b1dd06
Compare
/lgtm |
@rwsu: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
for day-2/addnodes workflow.
Updated the LoadHostConfigs function to only load the current host's HostConfig if the workflow is addnodes.
Only the current host's HostConfig is needed because each host in the addnodes workflow has its own assisted-service. Loading other node's HostConfigs would cause the apply-host-config service to continually wait for other hosts to register with assisted-service because each node is added in isolation.
List all the issues related to this PR
What environments does this code impact?
How was this code tested?
Checklist
docs
, README, etc)Reviewers Checklist