New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NO-ISSUE: Add environment variable ENABLE_SOFT_TIMEOUTS to openshift/template.yaml #6083
NO-ISSUE: Add environment variable ENABLE_SOFT_TIMEOUTS to openshift/template.yaml #6083
Conversation
@ori-amizur: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift/template.yaml
Outdated
@@ -44,6 +44,8 @@ parameters: | |||
value: "true" | |||
- name: ENABLE_SKIP_MCO_REBOOT | |||
value: "true" | |||
- name: ENABLE_SOFT_TIMEOUTS | |||
value: "true" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please change the default to false
490c21e
to
b56f79b
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gamli75, ori-amizur The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@ori-amizur: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
List all the issues related to this PR
What environments does this code impact?
How was this code tested?
Checklist
docs
, README, etc)Reviewers Checklist
/cc @gamli75
/cc @rccrdpccl