MGMT-17196: Fix none existens of static MAC adr. in case of specific network devices on s390x.

[AmadeusPodvratnik]

On s390x there are some network configurations where MAC addresses are not static and lead to issues using Assisted Installer, Agent based Installer and HCP (see attached net conf).

For AI and HCP there is a possibility to patch kernel arguments but using the UI there is a separate manual step needed using the API. This will be a bad user experience.
In addition patching the kernel arguments for ABI is not possible.

To solve this, a config override parameter need to be added to the parm file by the user and the ip settings will be automatically passed to the coreos installer regardless what the user configure (DHCP or static IP using nmstate).

See matrix in ticket:
https://issues.redhat.com/browse/MGMT-17196

Doc ticket:
https://issues.redhat.com/browse/MULTIARCH-4537

List all the issues related to this PR

• New Feature
• Enhancement
• [x ] Bug fix
• Tests
• Documentation
• CI/CD

What environments does this code impact?

• Automation (CI, tools, etc)
• Cloud
• Operator Managed Deployments
• None

How was this code tested?

• Simple parse test by running unit tests

• assisted-test-infra environment

• dev-scripts environment

• Reviewer's test appreciated

• Waiting for CI to do a full test run

• Manual (Elaborate on how it was tested)

• [] No tests needed

Checklist

• [x ] Title and description added to both, commit and PR.
• [ x] Relevant issues have been associated (see CONTRIBUTING guide)
• This change does not require a documentation update (docstring, docs, README, etc)
• [x ] Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

[openshift-ci-robot]

@AmadeusPodvratnik: This pull request references MGMT-17196 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

On s390x there are some network configurations where MAC addresses are not static and lead to issues using Assisted Installer, Agent based Installer and HCP (see attached net conf).

For AI and HCP there is a possibility to patch kernel arguments but using the UI there is a separate manual step needed using the API. This will be a bad user experience.
In addition patching the kernel arguments for ABI is not possible.

To solve this, a config override parameter need to be added to the parm file by the user and the ip settings will be automatically passed to the coreos installer regardless what the user configure (DHCP or static IP using nmstate).

See matrix in ticket:
https://issues.redhat.com/browse/MGMT-17196

Doc ticket:
https://issues.redhat.com/browse/MULTIARCH-4537

List all the issues related to this PR

• New Feature
• Enhancement
• [x ] Bug fix
• Tests
• Documentation
• CI/CD

What environments does this code impact?

• Automation (CI, tools, etc)
• Cloud
• Operator Managed Deployments
• None

How was this code tested?

• Simple parse test by running unit tests

• assisted-test-infra environment

• dev-scripts environment

• Reviewer's test appreciated

• Waiting for CI to do a full test run

• Manual (Elaborate on how it was tested)

• [] No tests needed

Checklist

• [x ] Title and description added to both, commit and PR.
• [ x] Relevant issues have been associated (see CONTRIBUTING guide)
• This change does not require a documentation update (docstring, docs, README, etc)
• [x ] Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

Hi @AmadeusPodvratnik. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[omertuc]

/lgtm

[omertuc]

/ok-to-test

[omertuc]

/approve

[omertuc]

Please rebase squash all commits

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AmadeusPodvratnik, omertuc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [omertuc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.21%. Comparing base (94da376) to head (4e2b253).
Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #6087      +/-   ##
==========================================
- Coverage   68.38%   68.21%   -0.18%     
==========================================
  Files         239      239              
  Lines       35503    35607     +104     
==========================================
+ Hits        24280    24290      +10     
- Misses       9115     9212      +97     
+ Partials     2108     2105       -3     

Files	Coverage Δ
internal/host/hostcommands/install_cmd.go	84.45% <100.00%> (+0.26%)	⬆️

... and 4 files with indirect coverage changes

[omertuc]

/lgtm

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 1a4191c and 2 for PR HEAD 4e2b253 in total

[openshift-ci]

@AmadeusPodvratnik: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.