MGMT-17241: [soft-timeout] Installation not timeout /aborted after 24 Hours #6092
Conversation
…Hours Missing 24h statemachine transition for soft timeouts was added.
openshift-ci-robot
added
the
jira/valid-reference
|
@ori-amizur: This pull request references MGMT-17241 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
size/L
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ori-amizur The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6092 +/- ##
==========================================
+ Coverage 68.36% 70.01% +1.65%
==========================================
Files 239 240 +1
Lines 35524 38102 +2578
==========================================
+ Hits 24287 26679 +2392
- Misses 9131 9208 +77
- Partials 2106 2215 +109
|
| @@ -72,6 +72,7 @@ type TransitionHandler interface { | |||
| PostRefreshFinalizingStageSoftTimedOut(sw stateswitch.StateSwitch, args stateswitch.TransitionArgs) error | |||
| SoftTimeoutsEnabled(_ stateswitch.StateSwitch, _ stateswitch.TransitionArgs) (bool, error) | |||
| FinalizingStageTimeoutMinutes(sCluster *stateCluster) interface{} | |||
| InstallationTimeoutMinutes(_ *stateCluster) interface{} | |||
There was a problem hiding this comment.
For formatting the status info
There was a problem hiding this comment.
I assume if we have FinalizingStageTimeoutMinutes it is sort of logical to have this one too but i really not sure i understand why to have both in interface
There was a problem hiding this comment.
The installation timeout member is a data member of transitionHandler, and the statemachine accesses the interface (not the object itself). Therefore it needs to be part of the interface too.
|
/lgtm |
|
@ori-amizur: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
[ART PR BUILD NOTIFIER] This PR has been included in build ose-agent-installer-api-server-container-v4.16.0-202403222013.p0.g7cac29d.assembly.stream.el8 for distgit ose-agent-installer-api-server. |
…Hours (openshift#6092) Missing 24h statemachine transition for soft timeouts was added.
…Hours (openshift#6092) Missing 24h statemachine transition for soft timeouts was added.
Missing 24h statemachine transition for soft timeouts was added.
List all the issues related to this PR
What environments does this code impact?
How was this code tested?
Checklist
docs, README, etc)Reviewers Checklist
/cc @gamli75
/cc @tsorya