Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MGMT-17518: Bump x/net to 0.24.0 to mitigate CVE-2023-45288 (api go.mod) #6212

Merged

Conversation

paul-maidment
Copy link
Contributor

Bump x/net to 0.24.0 to mitigate CVE-2023-45288 (api go.mod)
I Forgot to deal with api/go.mod, this PR addresses that.

List all the issues related to this PR

  • New Feature
  • Enhancement
  • Bug fix
  • Tests
  • Documentation
  • CI/CD

What environments does this code impact?

  • Automation (CI, tools, etc)
  • Cloud
  • Operator Managed Deployments
  • None

How was this code tested?

  • assisted-test-infra environment
  • dev-scripts environment
  • Reviewer's test appreciated
  • Waiting for CI to do a full test run
  • Manual (Elaborate on how it was tested)
  • No tests needed

Checklist

  • Title and description added to both, commit and PR.
  • Relevant issues have been associated (see CONTRIBUTING guide)
  • This change does not require a documentation update (docstring, docs, README, etc)
  • Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

  • Are the title and description (in both PR and commit) meaningful and clear?
  • Is there a bug required (and linked) for this change?
  • Should this PR be backported?

Bump x/net to 0.24.0 to mitigate CVE-2023-45288 (api go.mod)
Forgot to deal with api/go.mod, this PR addresses that.
@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 18, 2024
@openshift-ci openshift-ci bot added api-review Categorizes an issue or PR as actively needing an API review. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 18, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 18, 2024
Copy link

openshift-ci bot commented Apr 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adriengentil, paul-maidment

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [adriengentil,paul-maidment]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.42%. Comparing base (4dcebe4) to head (535718b).
Report is 2 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6212      +/-   ##
==========================================
+ Coverage   68.28%   68.42%   +0.13%     
==========================================
  Files         240      240              
  Lines       35815    35962     +147     
==========================================
+ Hits        24456    24606     +150     
- Misses       9200     9202       +2     
+ Partials     2159     2154       -5     

see 3 files with indirect coverage changes

@CrystalChun
Copy link
Contributor

/retitle OCPBUGS-30905: Bump x/net to 0.24.0 to mitigate CVE-2023-45288 (api go.mod)

@openshift-ci openshift-ci bot changed the title OCPBUGS: Bump x/net to 0.24.0 to mitigate CVE-2023-45288 (api go.mod) OCPBUGS-30905: Bump x/net to 0.24.0 to mitigate CVE-2023-45288 (api go.mod) Apr 18, 2024
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 18, 2024
@openshift-ci-robot
Copy link

@paul-maidment: This pull request references Jira Issue OCPBUGS-30905, which is invalid:

  • expected the bug to target either version "4.16." or "openshift-4.16.", but it targets "4.13.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bump x/net to 0.24.0 to mitigate CVE-2023-45288 (api go.mod)
I Forgot to deal with api/go.mod, this PR addresses that.

List all the issues related to this PR

  • New Feature
  • Enhancement
  • Bug fix
  • Tests
  • Documentation
  • CI/CD

What environments does this code impact?

  • Automation (CI, tools, etc)
  • Cloud
  • Operator Managed Deployments
  • None

How was this code tested?

  • assisted-test-infra environment
  • dev-scripts environment
  • Reviewer's test appreciated
  • Waiting for CI to do a full test run
  • Manual (Elaborate on how it was tested)
  • No tests needed

Checklist

  • Title and description added to both, commit and PR.
  • Relevant issues have been associated (see CONTRIBUTING guide)
  • This change does not require a documentation update (docstring, docs, README, etc)
  • Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

  • Are the title and description (in both PR and commit) meaningful and clear?
  • Is there a bug required (and linked) for this change?
  • Should this PR be backported?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@CrystalChun
Copy link
Contributor

CrystalChun commented Apr 18, 2024

/retitle MGMT-17518: Bump x/net to 0.24.0 to mitigate GHSA-4v7x-pqxf-cx7m (api go.mod)

@openshift-ci openshift-ci bot changed the title OCPBUGS-30905: Bump x/net to 0.24.0 to mitigate CVE-2023-45288 (api go.mod) MGMT-17518: Bump x/net to 0.24.0 to mitigate https://github.com/advisories/GHSA-4v7x-pqxf-cx7m (api go.mod) Apr 18, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 18, 2024

@paul-maidment: This pull request references MGMT-17518 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Bump x/net to 0.24.0 to mitigate CVE-2023-45288 (api go.mod)
I Forgot to deal with api/go.mod, this PR addresses that.

List all the issues related to this PR

  • New Feature
  • Enhancement
  • Bug fix
  • Tests
  • Documentation
  • CI/CD

What environments does this code impact?

  • Automation (CI, tools, etc)
  • Cloud
  • Operator Managed Deployments
  • None

How was this code tested?

  • assisted-test-infra environment
  • dev-scripts environment
  • Reviewer's test appreciated
  • Waiting for CI to do a full test run
  • Manual (Elaborate on how it was tested)
  • No tests needed

Checklist

  • Title and description added to both, commit and PR.
  • Relevant issues have been associated (see CONTRIBUTING guide)
  • This change does not require a documentation update (docstring, docs, README, etc)
  • Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

  • Are the title and description (in both PR and commit) meaningful and clear?
  • Is there a bug required (and linked) for this change?
  • Should this PR be backported?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Apr 18, 2024
@CrystalChun
Copy link
Contributor

CrystalChun commented Apr 18, 2024

/retitle MGMT-17518: Bump x/net to 0.24.0 to mitigate CVE-2023-45288 (api go.mod)

@openshift-ci openshift-ci bot changed the title MGMT-17518: Bump x/net to 0.24.0 to mitigate https://github.com/advisories/GHSA-4v7x-pqxf-cx7m (api go.mod) MGMT-17518: Bump x/net to 0.24.0 to mitigate CVE-2023-45288 (api go.mod) Apr 18, 2024
Copy link

openshift-ci bot commented Apr 19, 2024

@paul-maidment: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 35aed7d into openshift:master Apr 19, 2024
12 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-agent-installer-api-server-container-v4.16.0-202404190512.p0.g35aed7d.assembly.stream.el8 for distgit ose-agent-installer-api-server.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-review Categorizes an issue or PR as actively needing an API review. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants