New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MGMT-17558: Allow installation on iSCSI volume #6218
Conversation
Open installation of OCP on iSCSI boot volume to all platforms. Remove `ip=ibft` from the kernel arguments as it prevent proper network configuration when several NICs are in use. RHCOS team recommend to leave DHCP configuration.
@adriengentil: This pull request references MGMT-17558 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Skipping CI for Draft Pull Request. |
@adriengentil: This pull request references MGMT-17558 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/test edge-unit-test edge-lint |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6218 +/- ##
=======================================
Coverage 68.27% 68.28%
=======================================
Files 240 240
Lines 35814 35811 -3
=======================================
+ Hits 24452 24453 +1
+ Misses 9202 9200 -2
+ Partials 2160 2158 -2
|
/cc @mlorenzofr @gamli75 |
@adriengentil: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adriengentil, gamli75 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick cloud_hotfix_releases |
@gamli75: once the present PR merges, I will cherry-pick it on top of cloud_hotfix_releases in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@gamli75: new pull request created: #6222 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[ART PR BUILD NOTIFIER] This PR has been included in build ose-agent-installer-api-server-container-v4.16.0-202404181812.p0.g2d4a39e.assembly.stream.el8 for distgit ose-agent-installer-api-server. |
Open installation of OCP on iSCSI boot volume to all platforms, as it was
allowed only on OCI.
Remove
ip=ibft
from the kernel arguments as it prevent proper networkconfiguration when several NICs are in use. RHCOS team recommend to
leave DHCP configuration.