Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-ocm-2.10] MGMT-17641: Deploy dual stack with IPv6 on top of bond/vlan fails #6235

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #6149

/assign ori-amizur

IPv6 L2 connectivity check uses nmap.  nmap uses NDP (Network Discovery
Protocol) to check L2 connectivty to IPv6 hosts. There are cases that
NDP response does not arrive or it is not captured by nmap which means
that the system assumes there is no connectivity to the host.  However,
there might be L3 connectivity (ping) to the same host.
So change adds fallback for IPv6 L2 connectivity.  In case there is
failure in L2 connectivity to IPv6 host and success in L3 connecivity to
the same host, the host is assumed connected on L2, providing that the
remote address is part of the L2 subnet being checked.
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Could not make automatic cherrypick of Jira Issue OCPBUGS-31631 for this PR as the target version is not set for this branch in the jira plugin config. Running refresh:
/jira refresh

In response to this:

This is an automated cherry-pick of #6149

/assign ori-amizur

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 24, 2024
@openshift-ci-robot
Copy link

@openshift-ci-robot: This pull request references Jira Issue OCPBUGS-31631, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead
  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required"
  • expected Jira Issue OCPBUGS-31631 to depend on a bug in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

@openshift-cherrypick-robot: Could not make automatic cherrypick of Jira Issue OCPBUGS-31631 for this PR as the target version is not set for this branch in the jira plugin config. Running refresh:
/jira refresh

In response to this:

This is an automated cherry-pick of #6149

/assign ori-amizur

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Apr 24, 2024
@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 24, 2024
@ori-amizur
Copy link
Contributor

ori-amizur commented Apr 24, 2024

/retitle MGMT-17641 [release-ocm-2.10] : Deploy dual stack with IPv6 on top of bond/vlan fails

@openshift-ci openshift-ci bot changed the title [release-ocm-2.10] OCPBUGS-31631: Deploy dual stack with IPv6 on top of bond/vlan fails MGMT-17641 [release-ocm-2.10] : Deploy dual stack with IPv6 on top of bond/vlan fails Apr 24, 2024
@openshift-ci-robot openshift-ci-robot removed jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 24, 2024
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to this:

This is an automated cherry-pick of #6149

/assign ori-amizur

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ori-amizur
Copy link
Contributor

ori-amizur commented Apr 24, 2024

/retitle [release-ocm-2.10] MGMT-17641: Deploy dual stack with IPv6 on top of bond/vlan fails

@openshift-ci openshift-ci bot changed the title MGMT-17641 [release-ocm-2.10] : Deploy dual stack with IPv6 on top of bond/vlan fails [release-ocm-2.10] MGMT-17641: Deploy dual stack with IPv6 on top of bond/vlan fails Apr 24, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 24, 2024

@openshift-cherrypick-robot: This pull request references MGMT-17641 which is a valid jira issue.

In response to this:

This is an automated cherry-pick of #6149

/assign ori-amizur

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 24, 2024
Copy link

codecov bot commented Apr 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.31%. Comparing base (5bd583f) to head (440a376).

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                  @@
##           release-ocm-2.10    #6235      +/-   ##
====================================================
+ Coverage             68.30%   68.31%   +0.01%     
====================================================
  Files                   237      237              
  Lines                 35152    35160       +8     
====================================================
+ Hits                  24009    24021      +12     
+ Misses                 9063     9062       -1     
+ Partials               2080     2077       -3     
Files Coverage Δ
internal/network/connectivity_groups.go 87.62% <100.00%> (+0.34%) ⬆️

... and 2 files with indirect coverage changes

@ori-amizur
Copy link
Contributor

/cc @gamli75
/uncc @romfreiman
/uncc @danmanor

@openshift-ci openshift-ci bot requested review from gamli75 and removed request for romfreiman and danmanor April 24, 2024 08:03
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 24, 2024
Copy link

openshift-ci bot commented Apr 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gamli75, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 24, 2024
Copy link

openshift-ci bot commented Apr 24, 2024

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 5a79ab7 into openshift:release-ocm-2.10 Apr 24, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants