Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MGMT-2706 Delete console kernel argument #737

Closed
wants to merge 1 commit into from
Closed

MGMT-2706 Delete console kernel argument #737

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions internal/host/transition.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ func (th *transitionHandler) PostRegisterHost(sw stateswitch.StateSwitch, args s

sHost.host.StatusUpdatedAt = strfmt.DateTime(time.Now())
sHost.host.StatusInfo = swag.String(statusInfoDiscovering)
sHost.host.InstallerArgs = "--delete-karg 'console=tty0'"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be ttyS0

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or perhaps delete it via regexp

Copy link
Contributor Author

@YuviGold YuviGold Nov 25, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the decision from the remove console=ttyS0 on metal issue - all console defaults kargs can be dropped.
But as looking in the coreos-installer code it seems regex isn't implemented.

Copy link
Contributor Author

@YuviGold YuviGold Nov 25, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created a PR for coreos-installer repository.
I guess it would take time.

log.Infof("Register new host %s cluster %s", sHost.host.ID.String(), sHost.host.ClusterID)
return params.db.Create(sHost.host).Error
}
Expand Down