STOR-1167: Enable extra-create-metadata to tag snapshots

[jsafrane]

This is required by the new driver feature "Interpolated tags in VolumeSnapshotClass".

cc @openshift/storage

[openshift-ci-robot]

@jsafrane: This pull request references STOR-1167 which is a valid jira issue.

In response to this:

This is required by the new driver feature "Interpolated tags in VolumeSnapshotClass".

cc @openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jsafrane]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jsafrane]

/label docs-approved
/label px-approved

[jsafrane]

All snapshot tests failed
/hold

[jsafrane]

E0518 13:07:47.230657 1 snapshot_controller.go:124] checkandUpdateContentStatus [snapcontent-a467cef2-493b-48bb-b358-98f1f267af4b]: error occurred failed to take snapshot of the volume vol-0d503ba85f0ac069e: "rpc error: code = InvalidArgument desc = Invalid parameter key csi.storage.k8s.io/volumesnapshot/namespace for CreateSnapshot"

So, --extra-create-metadata needs the new CSI driver, openshift/aws-ebs-csi-driver#222

I think that a cluster with both this PR and the new CSI driver PR should work. The CSI driver rebase needs to be merged first.

[Phaow]

@jsafrane Pre merge test passed with job build openshift/aws-ebs-csi-driver#222,openshift/cluster-storage-operator#369,openshift/aws-ebs-csi-driver-operator#223 succeeded
With the fix patch, the "Interpolated tags in VolumeSnapshotClass" new feature works as expected. BTW, when I go through upstream docs, there's another Interpolated tags in storageClass provision pv with tags feature, do we also want to enbale it(add --extra-create-metadata flag to our csi-provisioner sidecar) by default?

Ref:

• https://github.com/kubernetes-sigs/aws-ebs-csi-driver/blob/master/docs/tagging.md

To allow for PV-level granularity, the CSI driver support runtime string interpolation on the tag values. You can specify placeholders for PVC namespace, PVC name and PV name, which will then be dynamically computed at runtime.

NOTE: This requires the --extra-create-metadata flag to be enabled on the external-provisioner sidecar.

[jsafrane]

/hold cancel
we need to merge openshift/aws-ebs-csi-driver#222 first, but that does not block testing of the rebase

[RomanBednar]

/lgtm

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 5756b4d and 2 for PR HEAD ecb3e28 in total

[jsafrane]

/retest

[jsafrane]

/retest

[jsafrane]

/retest

[jsafrane]

/retest

[jsafrane]

/retest

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 4eef5db and 1 for PR HEAD ecb3e28 in total

[mpatlasov]

/test hypershift-aws-e2e-external

[openshift-ci]

@jsafrane: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-hypershift-conformance	ecb3e28	link	false	/test e2e-hypershift-conformance

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[jsafrane]

/retest