Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1871051: Add external-attacher permissions to patch status #79

Merged
merged 1 commit into from Aug 25, 2020
Merged

Bug 1871051: Add external-attacher permissions to patch status #79

merged 1 commit into from Aug 25, 2020

Conversation

jsafrane
Copy link
Contributor

v3.0.0 of the external-attacher uses PATCH to update volumeattachment/status

@jsafrane
Add external-attacher permissions to patch status
c6705b3 
v3.0.0 of the external-attacher uses PATCH to update volumeattachment/status
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Aug 21, 2020
@openshift-ci-robot
Copy link
Contributor

@jsafrane: This pull request references Bugzilla bug 1871051, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1871051: Add external-attacher permissions to patch status

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 21, 2020
@jsafrane
Copy link
Contributor Author

Upstream AWS EBS CSI driver still uses v1.2.0, so updating the permissions does not make sense there.

bertinatto
bertinatto reviewed Aug 21, 2020
View reviewed changes
Copy link
Member

@bertinatto bertinatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 21, 2020
@jsafrane
Copy link
Contributor Author

/retest

2 similar comments
@jsafrane
Copy link
Contributor Author

/retest

@jsafrane
Copy link
Contributor Author

/retest

@jsafrane
Copy link
Contributor Author

jsafrane commented Aug 21, 2020 •
edited

CI is useful!

AWSEBSCSIDriverOperatorCRDegraded: AWSEBSDriverStaticResourcesControllerDegraded: "rbac/attacher_role.yaml" (string): clusterroles.rbac.authorization.k8s.io "ebs-external-attacher-role" is forbidden: user "system:serviceaccount:openshift-cluster-csi-drivers:aws-ebs-csi-driver-operator" (groups=["system:serviceaccounts" "system:serviceaccounts:openshift-cluster-csi-drivers" "system:authenticated"]) is attempting to grant RBAC permissions not currently held:
AWSEBSCSIDriverOperatorCRDegraded: AWSEBSDriverStaticResourcesControllerDegraded: {APIGroups:["storage.k8s.io"], Resources:["volumeattachments/status"], Verbs:["patch"]}
AWSEBSCSIDriverOperatorCRDegraded: AWSEBSDriverStaticResourcesControllerDegraded: "rbac/attacher_binding.yaml" (string): clusterroles.rbac.authorization.k8s.io "ebs-external-attacher-role" not found
AWSEBSCSIDriverOperatorCRDegraded: AWSEBSDriverStaticResourcesControllerDegraded:```

We need to patch CSO first.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Aug 21, 2020
@bertinatto
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 21, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

10 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

12 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@gnufied
Copy link
Member

gnufied commented Aug 24, 2020 •
edited

This PR looks to be buggy.

 Aug 24 12:07:47.451 W ns/openshift-cluster-csi-drivers deployment/aws-ebs-csi-driver-operator reason/ClusterRoleCreateFailed Failed to create ClusterRole.rbac.authorization.k8s.io/ebs-external-attacher-role: clusterroles.rbac.authorization.k8s.io "ebs-external-attacher-role" is forbidden: user "system:serviceaccount:openshift-cluster-csi-drivers:aws-ebs-csi-driver-operator" (groups=["system:serviceaccounts" "system:serviceaccounts:openshift-cluster-csi-drivers" "system:authenticated"]) is attempting to grant RBAC permissions not currently held:\n{APIGroups:["storage.k8s.io"], Resources:["volumeattachments/status"], Verbs:["patch"]} (65 times)

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto, gnufied, jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [bertinatto,gnufied,jsafrane]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gnufied
Copy link
Member

gnufied commented Aug 24, 2020

lets wait for openshift/cluster-storage-operator#78 to merge first.

@gnufied
Copy link
Member

gnufied commented Aug 24, 2020

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 24, 2020
@openshift-ci-robot openshift-ci-robot mentioned this pull request Aug 25, 2020
Merged
@bertinatto
Copy link
Member

/test e2e-operator

@bertinatto
Copy link
Member

openshift/cluster-storage-operator#78 has been merged.

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 25, 2020
@openshift-merge-robot openshift-merge-robot merged commit 020e614 into openshift:master Aug 25, 2020
@openshift-ci-robot
Copy link
Contributor

@jsafrane: All pull requests linked via external trackers have merged: openshift/cluster-storage-operator#78, openshift/aws-ebs-csi-driver-operator#79. Bugzilla bug 1871051 has been moved to the MODIFIED state.

In response to this:

Bug 1871051: Add external-attacher permissions to patch status

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bertinatto bertinatto bertinatto left review comments

@gnufied gnufied Awaiting requested review from gnufied

@huffmanca huffmanca Awaiting requested review from huffmanca

Assignees

@gnufied gnufied

@bertinatto bertinatto

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jsafrane @openshift-ci-robot @bertinatto @openshift-bot @gnufied @openshift-merge-robot