vendor: bump aws sdk for sts webhook authentication #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
upstream PR kubernetes-sigs#614 |
bertinatto
reviewed
Nov 19, 2020
There was a problem hiding this comment.
/lgtm
For the record: the upstream PR has some extra files that aren't used here yet:
.../github.com/aws/aws-sdk-go/service/elb/api.go | 83 +-
.../github.com/aws/aws-sdk-go/service/elb/doc.go | 2 +-
.../github.com/aws/aws-sdk-go/service/elbv2/api.go | 1039 +-
.../github.com/aws/aws-sdk-go/service/elbv2/doc.go | 22 +-
.../aws/aws-sdk-go/service/elbv2/errors.go | 6 +
.../github.com/aws/aws-sdk-go/service/kms/api.go | 1228 +-
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, bertinatto The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref: https://issues.redhat.com/browse/CO-1298
Is this a bug fix or adding new feature?
Supporting https://docs.aws.amazon.com/STS/latest/APIReference/API_AssumeRoleWithWebIdentity.html for authenticating with AWS SDK.
What is this PR about? / Why do we need it?
The AWS SDK added support for the AssumeRoleWithWebIdentity in latest release >=1.35 and bumping the vendor allows uses that for authentication with AWS IAM.
What testing is done?
TBD