OCPBUGS-4185: Fix nodeService.getVolumesLimit() adding more instance

[gnufied]

This commit fixes the getVolumesLimit function.

Previously, the volume limit for Nitro instances was based off of a regex. This regex is insufficient for the wide variety of Nitro instances that AWS supports today.

Nitro instances share attachments with ENIs and NVMe instance stores.

The number of attached ENIs is queried through IMDS, against the network/interfaces/macs endpoint.

The number of already attached block devices is also queried through IMDS, against the block-device-mapping endpoint.

Currently, IMDS does not provide a way to query NVMe instance store volumes. So, all instances that support NVMe instance stores are listed in pkg/cloud/volume_limits.go

This commit also added more tests to cover various scenarios.

[openshift-ci]

@gnufied: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

JIRA 4185: Fix nodeService.getVolumesLimit() adding more instance

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@gnufied: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

OCPBUGS 4185: Fix nodeService.getVolumesLimit() adding more instance

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@gnufied: This pull request references Jira Issue OCPBUGS-4185, which is invalid:

• expected Jira Issue OCPBUGS-4185 to depend on a bug targeting a version in 4.12.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This commit fixes the getVolumesLimit function.

Previously, the volume limit for Nitro instances was based off of a regex. This regex is insufficient for the wide variety of Nitro instances that AWS supports today.

Nitro instances share attachments with ENIs and NVMe instance stores.

The number of attached ENIs is queried through IMDS, against the network/interfaces/macs endpoint.

The number of already attached block devices is also queried through IMDS, against the block-device-mapping endpoint.

Currently, IMDS does not provide a way to query NVMe instance store volumes. So, all instances that support NVMe instance stores are listed in pkg/cloud/volume_limits.go

This commit also added more tests to cover various scenarios.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@gnufied: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

OCPBUGS-4185: Fix nodeService.getVolumesLimit() adding more instance

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[gnufied]

/jira refresh

[openshift-ci-robot]

@gnufied: An error was encountered converting bugzilla URL https://issues.redhat.com/browse/OCPBUGS-3775 to an ID for bug OCPBUGS-4185 on the Jira server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message.

strconv.Atoi: parsing "https://issues.redhat.com/browse/OCPBUGS-3775": invalid syntax

Please contact an administrator to resolve this issue, then request a bug refresh with /jira refresh.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gnufied

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [gnufied]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[gnufied]

/jira refresh

[openshift-ci-robot]

@gnufied: This pull request references Jira Issue OCPBUGS-4185, which is invalid:

• expected dependent Jira Issue OCPBUGS-3775 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is Closed (Cannot Reproduce) instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[gnufied]

/jira refresh

[openshift-ci-robot]

@gnufied: This pull request references Jira Issue OCPBUGS-4185, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.11.z) matches configured target version for branch (4.11.z)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
• dependent bug Jira Issue OCPBUGS-3775 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
• dependent Jira Issue OCPBUGS-3775 targets the "4.12.0" version, which is one of the valid target versions: 4.12.0
• bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (wduan@redhat.com), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@gnufied: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[dobsonj]

/lgtm
/label backport-risk-assessed

[duanwei33]

/label cherry-pick-approved

[openshift-ci-robot]

@gnufied: All pull requests linked via external trackers have merged:

• openshift/aws-ebs-csi-driver#213

Jira Issue OCPBUGS-4185 has been moved to the MODIFIED state.

In response to this:

This commit fixes the getVolumesLimit function.

Previously, the volume limit for Nitro instances was based off of a regex. This regex is insufficient for the wide variety of Nitro instances that AWS supports today.

Nitro instances share attachments with ENIs and NVMe instance stores.

The number of attached ENIs is queried through IMDS, against the network/interfaces/macs endpoint.

The number of already attached block devices is also queried through IMDS, against the block-device-mapping endpoint.

Currently, IMDS does not provide a way to query NVMe instance store volumes. So, all instances that support NVMe instance stores are listed in pkg/cloud/volume_limits.go

This commit also added more tests to cover various scenarios.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.