Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STOR-1400: Rebase to v1.25.0 for OCP 4.15 #244

Merged
merged 249 commits into from Nov 23, 2023

Conversation

jsafrane
Copy link

@jsafrane jsafrane commented Nov 21, 2023

Diff to upstream v1.25.0:
kubernetes-sigs/aws-ebs-csi-driver@v1.25.0...jsafrane:rebase-v1.25.0

I had to downgrade go to v1.20, we don't have 1.21 in OCP yet.

Notable changes since v1.18.0 (OCP 4.14):

Full changelog: https://github.com/kubernetes-sigs/aws-ebs-csi-driver/blob/master/CHANGELOG.md

@openshift/storage

petderek and others added 30 commits April 14, 2023 21:02
Signed-off-by: Connor Catlett <conncatl@amazon.com>
Signed-off-by: Eddie Torres <torredil@amazon.com>
Use K8s `stable-1.27` for External Storage tests on Windows
Signed-off-by: Eddie Torres <torredil@amazon.com>
Signed-off-by: Connor Catlett <conncatl@amazon.com>
…roughput

Allow throughput with defaulted GP3 volume type
Fix e2e test flakes due to volume node affinity conflict
Signed-off-by: Eddie Torres <torredil@amazon.com>
Signed-off-by: Hanyue Liang <hanliang@amazon.com>
Co-authored-by: Gengtao Xu <gengtaox@amazon.com>
Signed-off-by: Connor Catlett <conncatl@amazon.com>
…quency

Signed-off-by: Eddie Torres <torredil@amazon.com>
…release-url

Use dl.k8s.io instead of kubernetes-release bucket
NodeUnstage/UnpublishVolume should return a success when the path
requested has already been unstaged/unpublished.

Signed-off-by: Connor Catlett <conncatl@amazon.com>
Signed-off-by: Eddie Torres <torredil@amazon.com>
The AWS SDK has its own EC2 interface, so ours is just bloatware
unnecessarily increasing developer overhead every time they forget to
add a function to it.

Signed-off-by: Connor Catlett <conncatl@amazon.com>
Check for 'not mounted' in linux Unstage/Unpublish
Signed-off-by: Eddie Torres <torredil@amazon.com>
Remove CPU limits; Decrease node pod CPU usage
The commit allows users to modify volume properties through PVC
annotations. For more details, refer to the modify-volume doc.
* Migrates Windows containers to EKS-D base images
* Add explicit runAsUserName to Windows manifests

Signed-off-by: Connor Catlett <conncatl@amazon.com>
Upstream does not store it in git.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 21, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 21, 2023

@jsafrane: This pull request references STOR-1400 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

Diff to upstream v1.25.0:
kubernetes-sigs/aws-ebs-csi-driver@v1.25.0...jsafrane:rebase-v1.25.0

Notable changes since v1.18.0 (OCP 4.14):

Full changelog: https://github.com/kubernetes-sigs/aws-ebs-csi-driver/blob/master/CHANGELOG.md

@openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

openshift-ci bot commented Nov 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 21, 2023
We do not have go 1.21 in OCP 4.15
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 21, 2023

@jsafrane: This pull request references STOR-1400 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

Diff to upstream v1.25.0:
kubernetes-sigs/aws-ebs-csi-driver@v1.25.0...jsafrane:rebase-v1.25.0

I had to downgrade go to v1.20, we don't have 1.21 in OCP yet.

Notable changes since v1.18.0 (OCP 4.14):

Full changelog: https://github.com/kubernetes-sigs/aws-ebs-csi-driver/blob/master/CHANGELOG.md

@openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jsafrane
Copy link
Author

/override ci/prow/verify-commits

Copy link

openshift-ci bot commented Nov 22, 2023

@jsafrane: Overrode contexts on behalf of jsafrane: ci/prow/verify-commits

In response to this:

/override ci/prow/verify-commits

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jsafrane
Copy link
Author

/label docs-approved
/label px-approved

@openshift-ci openshift-ci bot added docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR labels Nov 22, 2023
@gnufied
Copy link
Member

gnufied commented Nov 22, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 22, 2023
@dobsonj
Copy link
Member

dobsonj commented Nov 22, 2023

/label acknowledge-critical-fixes-only

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Nov 22, 2023
@Phaow
Copy link

Phaow commented Nov 23, 2023

Use the pre merged build registry.build05.ci.openshift.org/ci-ln-i3rdbkt/release:latest (build #244,openshift/csi-operator#69,openshift/csi-operator#72) test passed

  1. Check the driver version as expected
$ oc rsh aws-ebs-csi-driver-controller-66d6ddb48-bnxqj
Defaulted container "csi-driver" out of: csi-driver, driver-kube-rbac-proxy, csi-provisioner, provisioner-kube-rbac-proxy, csi-attacher, attacher-kube-rbac-proxy, csi-resizer, resizer-kube-rbac-proxy, csi-snapshotter, snapshotter-kube-rbac-proxy, csi-liveness-probe
sh-4.4$ ps -elf
F S UID          PID    PPID  C PRI  NI ADDR SZ WCHAN  STIME TTY          TIME CMD
4 S 1000190+       1       0  0  80   0 - 326426 ep_pol 01:06 ?       00:00:00 /usr/bin/aws-ebs-csi-driver controller --endpoint=unix:///var/lib/csi/sockets/pluginproxy/
4 S 1000190+      14       0  0  80   0 -  3015 do_wai 01:47 pts/0    00:00:00 /bin/sh
4 R 1000190+      20      14  0  80   0 - 11174 -      01:47 pts/0    00:00:00 ps -elf
sh-4.4$ /usr/bin/aws-ebs-csi-driver --version
{
  "driverVersion": "v1.25.0",
  "gitCommit": "5631a456c759944b7e3a1c5124d7734c6aeb8aab",
  "buildDate": "2023-11-22T00:33:25+00:00",
  "goVersion": "go1.20.10 X:strictfipsruntime",
  "compiler": "gc",
  "platform": "linux/amd64"
}
  1. Noteable changes tests all looks good except Implement Generic Batching Framework + Batch DescribeVolume API requests also needs the STOR-1400: Add support for Batch DescribeVolume csi-operator#74 .
  2. Regression test all looks good only 1 failed case caused by some message optimize I fixed it in https://github.com/openshift/openshift-tests-private/pull/12998 .

@Phaow
Copy link

Phaow commented Nov 23, 2023

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Nov 23, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 23, 2023

@jsafrane: This pull request references STOR-1400 which is a valid jira issue.

In response to this:

Diff to upstream v1.25.0:
kubernetes-sigs/aws-ebs-csi-driver@v1.25.0...jsafrane:rebase-v1.25.0

I had to downgrade go to v1.20, we don't have 1.21 in OCP yet.

Notable changes since v1.18.0 (OCP 4.14):

Full changelog: https://github.com/kubernetes-sigs/aws-ebs-csi-driver/blob/master/CHANGELOG.md

@openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

openshift-ci bot commented Nov 23, 2023

@jsafrane: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-csi-extended ca1045c link false /test e2e-aws-csi-extended

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jsafrane
Copy link
Author

/override ci/prow/verify-commits

Copy link

openshift-ci bot commented Nov 23, 2023

@jsafrane: Overrode contexts on behalf of jsafrane: ci/prow/verify-commits

In response to this:

/override ci/prow/verify-commits

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-bot openshift-merge-bot bot merged commit ea19619 into openshift:master Nov 23, 2023
8 of 9 checks passed
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-aws-ebs-csi-driver-container-v4.15.0-202311231531.p0.gea19619.assembly.stream for distgit ose-aws-ebs-csi-driver.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet