New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
STOR-1303: Restart controller Pods if metrics-serving-cert changed #71
STOR-1303: Restart controller Pods if metrics-serving-cert changed #71
Conversation
The patch also piggyback cosmetic changes to README.md: 1) Define env var `PROVISIONER_IMAGE` and `KUBE_RBAC_PROXY_IMAGE` 2) Update env var `LIVENESS_PROBE_IMAGE` to use latest version of the image 3) Update env var `DRIVER_IMAGE` to use latest version of the image from quay.io
@mpatlasov: This pull request references STOR-1303 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @jsafrane |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jsafrane, mpatlasov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Pre verify passed with the commit build and run the operator locally. # After the metrics-serving-cert secret changed, driver controller restarted
$ oc get po -l app=aws-efs-csi-driver-controller -w
NAME READY STATUS RESTARTS AGE
aws-efs-csi-driver-controller-599dc45647-bkl8m 4/4 Running 0 2m47s
aws-efs-csi-driver-controller-599dc45647-qb7dn 4/4 Running 0 2m57s
aws-efs-csi-driver-controller-599dc45647-bkl8m 4/4 Terminating 0 2m56s
aws-efs-csi-driver-controller-5dc89dd8c8-w6vp2 0/4 Pending 0 0s
aws-efs-csi-driver-controller-5dc89dd8c8-w6vp2 0/4 Pending 0 0s
aws-efs-csi-driver-controller-5dc89dd8c8-w6vp2 0/4 ContainerCreating 0 0s
aws-efs-csi-driver-controller-5dc89dd8c8-w6vp2 0/4 Terminating 0 1s
aws-efs-csi-driver-controller-6c584f5845-db6kl 0/4 Pending 0 0s
aws-efs-csi-driver-controller-6c584f5845-db6kl 0/4 Pending 0 0s
aws-efs-csi-driver-controller-5dc89dd8c8-w6vp2 4/4 Terminating 0 1s
aws-efs-csi-driver-controller-599dc45647-bkl8m 0/4 Terminating 0 2m58s
aws-efs-csi-driver-controller-599dc45647-bkl8m 0/4 Terminating 0 2m58s
aws-efs-csi-driver-controller-599dc45647-bkl8m 0/4 Terminating 0 2m58s
aws-efs-csi-driver-controller-6c584f5845-db6kl 0/4 Pending 0 1s
aws-efs-csi-driver-controller-6c584f5845-db6kl 0/4 ContainerCreating 0 1s
aws-efs-csi-driver-controller-5dc89dd8c8-w6vp2 0/4 Terminating 0 2s
aws-efs-csi-driver-controller-5dc89dd8c8-w6vp2 0/4 Terminating 0 2s
aws-efs-csi-driver-controller-5dc89dd8c8-w6vp2 0/4 Terminating 0 2s
aws-efs-csi-driver-controller-6c584f5845-db6kl 4/4 Running 0 2s
aws-efs-csi-driver-controller-599dc45647-qb7dn 4/4 Terminating 0 3m9s
aws-efs-csi-driver-controller-6c584f5845-blvsg 0/4 Pending 0 0s
aws-efs-csi-driver-controller-6c584f5845-blvsg 0/4 Pending 0 0s
aws-efs-csi-driver-controller-6c584f5845-blvsg 0/4 ContainerCreating 0 0s
aws-efs-csi-driver-controller-6c584f5845-blvsg 4/4 Running 0 1s
aws-efs-csi-driver-controller-599dc45647-qb7dn 0/4 Terminating 0 3m11s
aws-efs-csi-driver-controller-599dc45647-qb7dn 0/4 Terminating 0 3m11s
aws-efs-csi-driver-controller-599dc45647-qb7dn 0/4 Terminating 0 3m11s |
/label qe-approved |
@mpatlasov: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Adding WithSecretHashAnnotationHook() for aws-ebs-csi-driver-controller-metrics-serving-cert ensures that new annotation is published in aws-ebs-csi-driver-controller deployment. This, in turn, leads to controller pods restart.
The PR also piggybacks cosmetic changes to README.md: 1) Define env var
PROVISIONER_IMAGE
andKUBE_RBAC_PROXY_IMAGE
2) Update env varLIVENESS_PROBE_IMAGE
to use latest version of the image 3) Update env varDRIVER_IMAGE
to use latest version of the image from quay.io