New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-10475: UPSTREAM: <carry>: Fix GOARCH in OpenShift build #37
OCPBUGS-10475: UPSTREAM: <carry>: Fix GOARCH in OpenShift build #37
Conversation
Do not overwrite GOARCH, it is set by our builders to the right value for x86_64 or arm or whatever we will support in OCP. In addition, build just one bin/aws-efs-csi-driver, for the current arch. Don't build anything else.
@jsafrane: This pull request references Jira Issue OCPBUGS-10475, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/jira refresh |
@jsafrane: This pull request references Jira Issue OCPBUGS-10475, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (wduan@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jsafrane, tsmetana The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
We want kubernetes/kubernetes#103780 in the EFS CSI driver to fix https://bugzilla.redhat.com/show_bug.cgi?id=2056629 We need to carry it until upstream updates to k8s 1.23 or newer. This replaces 7caacdb: UPSTREAM: <carry>: Ignore 'wait: no child processes' error when calling mount/umount
@jsafrane: This pull request references Jira Issue OCPBUGS-10475, which is valid. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (wduan@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@jsafrane: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/lgtm |
/cherry-pick release-4.13 |
@jsafrane: once the present PR merges, I will cherry-pick it on top of release-4.13 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@jsafrane: Jira Issue OCPBUGS-10475: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-10475 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@jsafrane: new pull request created: #38 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Do not overwrite GOARCH, it is set by our builders to the right value for x86_64 or arm or whatever we will support in OCP.
In addition, build just one bin/aws-efs-csi-driver, for the current arch. Don't build anything else.
This is cherry-pick of #29 in 4.14
I added a new carry commit to fix verify-deps:
@openshift/storage