Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-10475: UPSTREAM: <carry>: Fix GOARCH in OpenShift build #37

Merged
merged 2 commits into from Mar 17, 2023

Conversation

jsafrane
Copy link

@jsafrane jsafrane commented Mar 17, 2023

Do not overwrite GOARCH, it is set by our builders to the right value for x86_64 or arm or whatever we will support in OCP.

In addition, build just one bin/aws-efs-csi-driver, for the current arch. Don't build anything else.

This is cherry-pick of #29 in 4.14

I added a new carry commit to fix verify-deps:

UPSTREAM: : update mount-utils
We want kubernetes/kubernetes#103780 in the EFS CSI
driver to fix https://bugzilla.redhat.com/show_bug.cgi?id=2056629

We need to carry it until upstream updates to k8s 1.23 or newer.

This replaces 7caacdb:
UPSTREAM: : Ignore 'wait: no child processes' error when calling mount/umount

@openshift/storage

Do not overwrite GOARCH, it is set by our builders to the right value for
x86_64 or arm or whatever we will support in OCP.

In addition, build just one bin/aws-efs-csi-driver, for the current arch.
Don't build anything else.
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 17, 2023
@openshift-ci-robot
Copy link

@jsafrane: This pull request references Jira Issue OCPBUGS-10475, which is invalid:

  • expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Do not overwrite GOARCH, it is set by our builders to the right value for x86_64 or arm or whatever we will support in OCP.

In addition, build just one bin/aws-efs-csi-driver, for the current arch. Don't build anything else.

This is cherry-pick of #29 in 4.14

@openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 17, 2023
@jsafrane
Copy link
Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 17, 2023
@openshift-ci-robot
Copy link

@jsafrane: This pull request references Jira Issue OCPBUGS-10475, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (wduan@redhat.com), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@tsmetana tsmetana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 17, 2023
@openshift-ci
Copy link

openshift-ci bot commented Mar 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, tsmetana

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

We want kubernetes/kubernetes#103780 in the EFS CSI
driver to fix https://bugzilla.redhat.com/show_bug.cgi?id=2056629

We need to carry it until upstream updates to k8s 1.23 or newer.

This replaces 7caacdb:
    UPSTREAM: <carry>: Ignore 'wait: no child processes' error when calling mount/umount
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 17, 2023
@openshift-ci-robot
Copy link

@jsafrane: This pull request references Jira Issue OCPBUGS-10475, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (wduan@redhat.com), skipping review request.

In response to this:

Do not overwrite GOARCH, it is set by our builders to the right value for x86_64 or arm or whatever we will support in OCP.

In addition, build just one bin/aws-efs-csi-driver, for the current arch. Don't build anything else.

This is cherry-pick of #29 in 4.14

I added a new carry commit to fix verify-deps:

UPSTREAM: : update mount-utils
We want kubernetes/kubernetes#103780 in the EFS CSI
driver to fix https://bugzilla.redhat.com/show_bug.cgi?id=2056629

We need to carry it until upstream updates to k8s 1.23 or newer.

This replaces 7caacdb:
UPSTREAM: : Ignore 'wait: no child processes' error when calling mount/umount

@openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Mar 17, 2023

@jsafrane: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@tsmetana
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 17, 2023
@jsafrane
Copy link
Author

/cherry-pick release-4.13

@openshift-cherrypick-robot

@jsafrane: once the present PR merges, I will cherry-pick it on top of release-4.13 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 4b069a6 into openshift:master Mar 17, 2023
@openshift-ci-robot
Copy link

@jsafrane: Jira Issue OCPBUGS-10475: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-10475 has been moved to the MODIFIED state.

In response to this:

Do not overwrite GOARCH, it is set by our builders to the right value for x86_64 or arm or whatever we will support in OCP.

In addition, build just one bin/aws-efs-csi-driver, for the current arch. Don't build anything else.

This is cherry-pick of #29 in 4.14

I added a new carry commit to fix verify-deps:

UPSTREAM: : update mount-utils
We want kubernetes/kubernetes#103780 in the EFS CSI
driver to fix https://bugzilla.redhat.com/show_bug.cgi?id=2056629

We need to carry it until upstream updates to k8s 1.23 or newer.

This replaces 7caacdb:
UPSTREAM: : Ignore 'wait: no child processes' error when calling mount/umount

@openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@jsafrane: new pull request created: #38

In response to this:

/cherry-pick release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants