Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-22344: UPSTREAM: 3429: CVE-2023-44487 - bump golang.org/x/net v0.17.0 #13

Conversation

alebedev87
Copy link

@alebedev87 alebedev87 commented Nov 2, 2023

golang.org/x/net is bumped to v0.17.0:

go get golang.org/x/net@v0.17.0
go mod tidy
go mod vendor

The webhook cannot be disabled because controller-runtime is too old to have a dedicated field for any TLS option. Bumping controller-runtime@v0.13.2 showed to be expensive (may introduce new bugs).

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Nov 2, 2023
@openshift-ci-robot
Copy link

@alebedev87: This pull request references Jira Issue OCPBUGS-22344, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @ShudiLi

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Issue

Description

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the docs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@alebedev87 alebedev87 force-pushed the cve-2023-44487-openshift-upstream branch from 36529eb to 1410533 Compare November 3, 2023 11:49
@alebedev87 alebedev87 force-pushed the cve-2023-44487-openshift-upstream branch from 1410533 to 942c2e8 Compare November 3, 2023 12:19
@candita
Copy link

candita commented Nov 8, 2023

/assign @gcs278
/assign

@candita
Copy link

candita commented Nov 8, 2023

@alebedev87 could you please open a ticket to record a watch on the future work that needs to be done for this?

@candita
Copy link

candita commented Nov 8, 2023

/approve

@gcs278
Copy link

gcs278 commented Nov 8, 2023

Seems straightforward enough:
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 8, 2023
@alebedev87
Copy link
Author

#14 to add whole NetEdge as owners.

@alebedev87
Copy link
Author

#13 (comment) should be fixed now.

@alebedev87
Copy link
Author

@candita : a rebase from the upstream is needed to follow up on this PR. I think we can use this user story from ALBO Next epic.

@candita
Copy link

candita commented Nov 15, 2023

@alebedev87 I don't know what you mean by #13 (comment). Let me know more if followup from me is needed. Re-approving as requested.

/approve

Copy link

openshift-ci bot commented Nov 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: candita

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 15, 2023
Copy link

openshift-ci bot commented Nov 15, 2023

@alebedev87: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 0ae6e1a into openshift:main Nov 15, 2023
3 checks passed
@openshift-ci-robot
Copy link

@alebedev87: Jira Issue OCPBUGS-22344: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-22344 has not been moved to the MODIFIED state.

In response to this:

golang.org/x/net is bumped to v0.17.0:

go get golang.org/x/net@v0.17.0
go mod tidy
go mod vendor

The webhook cannot be disabled because controller-runtime is too old to have a dedicated field for any TLS option. Bumping controller-runtime@v0.13.2 showed to be expensive (may introduce new bugs).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants