-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-22344: UPSTREAM: 3429: CVE-2023-44487 - bump golang.org/x/net v0.17.0 #13
OCPBUGS-22344: UPSTREAM: 3429: CVE-2023-44487 - bump golang.org/x/net v0.17.0 #13
Conversation
@alebedev87: This pull request references Jira Issue OCPBUGS-22344, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
36529eb
to
1410533
Compare
Bug reference: OCPBUGS-22344
1410533
to
942c2e8
Compare
/assign @gcs278 |
@alebedev87 could you please open a ticket to record a watch on the future work that needs to be done for this? |
/approve |
Seems straightforward enough: |
#14 to add whole NetEdge as owners. |
#13 (comment) should be fixed now. |
@candita : a rebase from the upstream is needed to follow up on this PR. I think we can use this user story from |
@alebedev87 I don't know what you mean by #13 (comment). Let me know more if followup from me is needed. Re-approving as requested. /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: candita The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@alebedev87: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@alebedev87: Jira Issue OCPBUGS-22344: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged: These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with Jira Issue OCPBUGS-22344 has not been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
golang.org/x/net
is bumped tov0.17.0
:The webhook cannot be disabled because
controller-runtime
is too old to have a dedicated field for any TLS option. Bumpingcontroller-runtime@v0.13.2
showed to be expensive (may introduce new bugs).