Skip to content

Commit d3a3c29

Browse files
Merge pull request #20 from huffmanca/include-vsc-by-default
Bug 1969538: Include VolumeSnapshotClass by default
2 parents a08d8f0 + adbe473 commit d3a3c29

120 files changed

Lines changed: 8052 additions & 2946 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

assets/volumesnapshotclass.yaml

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
apiVersion: snapshot.storage.k8s.io/v1
2+
kind: VolumeSnapshotClass
3+
metadata:
4+
name: csi-azuredisk-vsc
5+
annotations:
6+
snapshot.storage.kubernetes.io/is-default-class: "true"
7+
driver: disk.csi.azure.com
8+
deletionPolicy: Delete
9+
parameters:
10+
incremental: "true" # available values: "true", "false" ("true" by default for Azure Public Cloud, and "false" by default for Azure Stack Cloud)

go.mod

Lines changed: 7 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -3,29 +3,17 @@ module github.com/openshift/azure-disk-csi-driver-operator
33
go 1.15
44

55
require (
6-
github.com/Microsoft/go-winio v0.4.11 // indirect
7-
github.com/certifi/gocertifi v0.0.0-20180905225744-ee1a9a0726d2 // indirect
8-
github.com/containerd/continuity v0.0.0-20190827140505-75bee3e2ccb6 // indirect
9-
github.com/docker/go-connections v0.3.0 // indirect
10-
github.com/docker/libnetwork v0.0.0-20190731215715-7f13a5c99f4b // indirect
116
github.com/fsnotify/fsnotify v1.4.9 // indirect
12-
github.com/fsouza/go-dockerclient v0.0.0-20171004212419-da3951ba2e9e // indirect
13-
github.com/getsentry/raven-go v0.0.0-20190513200303-c977f96e1095 // indirect
147
github.com/go-bindata/go-bindata v3.1.2+incompatible
15-
github.com/konsorten/go-windows-terminal-sequences v1.0.3 // indirect
16-
github.com/morikuni/aec v1.0.0 // indirect
17-
github.com/opencontainers/runc v0.0.0-20191031171055-b133feaeeb2e // indirect
18-
github.com/openshift/api v0.0.0-20210331193751-3acddb19d360
19-
github.com/openshift/build-machinery-go v0.0.0-20210209125900-0da259a2c359
20-
github.com/openshift/client-go v0.0.0-20210331195552-cf6c2669e01f
21-
github.com/openshift/library-go v0.0.0-20210408164723-7a65fdb398e2
8+
github.com/openshift/api v0.0.0-20210521075222-e273a339932a
9+
github.com/openshift/build-machinery-go v0.0.0-20210423112049-9415d7ebd33e
10+
github.com/openshift/client-go v0.0.0-20210521082421-73d9475a9142
11+
github.com/openshift/library-go v0.0.0-20210608075825-51ddcf37b1f8
2212
github.com/prometheus/client_golang v1.7.1
2313
github.com/spf13/cobra v1.1.1
2414
github.com/spf13/pflag v1.0.5
25-
github.com/vishvananda/netlink v1.0.0 // indirect
26-
github.com/vishvananda/netns v0.0.0-20191106174202-0a2b9b5464df // indirect
27-
k8s.io/apimachinery v0.21.0-rc.0
28-
k8s.io/client-go v0.21.0-rc.0
29-
k8s.io/component-base v0.21.0-rc.0
15+
k8s.io/apimachinery v0.21.1
16+
k8s.io/client-go v0.21.1
17+
k8s.io/component-base v0.21.1
3018
k8s.io/klog v1.0.0
3119
)

go.sum

Lines changed: 28 additions & 125 deletions
Large diffs are not rendered by default.

pkg/generated/bindata.go

Lines changed: 32 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/operator/starter.go

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ import (
1414
configclient "github.com/openshift/client-go/config/clientset/versioned"
1515
configinformers "github.com/openshift/client-go/config/informers/externalversions"
1616
"github.com/openshift/library-go/pkg/controller/controllercmd"
17+
"github.com/openshift/library-go/pkg/controller/factory"
1718
"github.com/openshift/library-go/pkg/operator/csi/csicontrollerset"
1819
"github.com/openshift/library-go/pkg/operator/csi/csidrivercontrollerservicecontroller"
1920
"github.com/openshift/library-go/pkg/operator/csi/csidrivernodeservicecontroller"
@@ -33,10 +34,12 @@ func RunOperator(ctx context.Context, controllerConfig *controllercmd.Controller
3334
// Create core clientset and informers
3435
kubeClient := kubeclient.NewForConfigOrDie(rest.AddUserAgent(controllerConfig.KubeConfig, operatorName))
3536
kubeInformersForNamespaces := v1helpers.NewKubeInformersForNamespaces(kubeClient, defaultNamespace, "")
37+
nodeInformer := kubeInformersForNamespaces.InformersFor("").Core().V1().Nodes()
3638

3739
// Create config clientset and informer. This is used to get the cluster ID
3840
configClient := configclient.NewForConfigOrDie(rest.AddUserAgent(controllerConfig.KubeConfig, operatorName))
3941
configInformers := configinformers.NewSharedInformerFactory(configClient, 20*time.Minute)
42+
infraInformer := configInformers.Config().V1().Infrastructures()
4043

4144
// Create GenericOperatorclient. This is used by the library-go controllers created down below
4245
gvr := opv1.SchemeGroupVersion.WithResource("clustercsidrivers")
@@ -59,10 +62,12 @@ func RunOperator(ctx context.Context, controllerConfig *controllercmd.Controller
5962
).WithStaticResourcesController(
6063
"AzureDiskDriverStaticResourcesController",
6164
kubeClient,
65+
dynamicClient,
6266
kubeInformersForNamespaces,
6367
generated.Asset,
6468
[]string{
6569
"storageclass.yaml",
70+
"volumesnapshotclass.yaml",
6671
"controller_sa.yaml",
6772
"node_sa.yaml",
6873
"csidriver.yaml",
@@ -93,13 +98,18 @@ func RunOperator(ctx context.Context, controllerConfig *controllercmd.Controller
9398
kubeClient,
9499
kubeInformersForNamespaces.InformersFor(defaultNamespace),
95100
configInformers,
101+
[]factory.Informer{
102+
nodeInformer.Informer(),
103+
infraInformer.Informer(),
104+
},
96105
csidrivercontrollerservicecontroller.WithObservedProxyDeploymentHook(),
97106
).WithCSIDriverNodeService(
98107
"AzureDiskDriverNodeServiceController",
99108
generated.MustAsset,
100109
"node.yaml",
101110
kubeClient,
102111
kubeInformersForNamespaces.InformersFor(defaultNamespace),
112+
nil, // Node doesn't need to react to any changes
103113
csidrivernodeservicecontroller.WithObservedProxyDaemonSetHook(),
104114
).WithServiceMonitorController(
105115
"AzureDiskServiceMonitorController",

vendor/github.com/openshift/api/Makefile

Lines changed: 3 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

vendor/github.com/openshift/api/apiserver/install.go

Lines changed: 22 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)