Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STOR-1065: Rework sidecar bindings to bind common ClusterRoles #84

Conversation

mpatlasov
Copy link
Contributor

PR openshift/cluster-storage-operator#379 published builiding blocks of sidecar ClusterRoles. Now, azure-disk csi driver operator may compose its sidecars ClusterRoles from those building blocks.

This PR also moves permissions for leases resource from ClusterRole to per-namespace Role (assets/rbac/lease_leader_election_role.yaml).

PR openshift/cluster-storage-operator#379 published builiding blocks of sidecar ClusterRoles. Now, azure-disk csi driver operator may compose its sidecars ClusterRoles from those building blocks.

This PR also moves permissions for `leases` resource from ClusterRole to per-namespace Role (`assets/rbac/lease_leader_election_role.yaml`).
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 28, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 28, 2023

@mpatlasov: This pull request references STOR-1065 which is a valid jira issue.

In response to this:

PR openshift/cluster-storage-operator#379 published builiding blocks of sidecar ClusterRoles. Now, azure-disk csi driver operator may compose its sidecars ClusterRoles from those building blocks.

This PR also moves permissions for leases resource from ClusterRole to per-namespace Role (assets/rbac/lease_leader_election_role.yaml).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from dobsonj and gnufied June 28, 2023 02:56
@mpatlasov
Copy link
Contributor Author

/retest

1 similar comment
@ropatil010
Copy link

/retest

@mpatlasov
Copy link
Contributor Author

/test e2e-azurestack-csi

1 similar comment
@mpatlasov
Copy link
Contributor Author

/test e2e-azurestack-csi

@ropatil010
Copy link

/retest

@mpatlasov
Copy link
Contributor Author

@ropatil010 , ci/prow/e2e-azurestack-csi is optional and it always fail: https://prow.ci.openshift.org/job-history/gs/origin-ci-test/pr-logs/directory/pull-ci-openshift-azure-disk-csi-driver-operator-master-e2e-azurestack-csi. I think we can proceed with this PR despite this test failures. (Lemme know if you think ci/prow/e2e-azurestack-csi is really required here)

@ropatil010
Copy link

Thanks @mpatlasov for confirmation.
Bases on the regression testing: PASS and results updated here: STOR-1363
/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Jul 7, 2023
@mpatlasov
Copy link
Contributor Author

/label docs-approved
/label px-approved

@openshift-ci openshift-ci bot added docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR labels Jul 7, 2023
@mpatlasov
Copy link
Contributor Author

/test e2e-azurestack-csi

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 19, 2023

@mpatlasov: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azurestack-csi 9a3135a link false /test e2e-azurestack-csi

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gnufied
Copy link
Member

gnufied commented Jul 19, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 19, 2023
@jsafrane
Copy link
Contributor

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, mpatlasov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 20, 2023
@openshift-merge-robot openshift-merge-robot merged commit 76df64f into openshift:master Jul 20, 2023
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants