Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-14824: Bump azure-disk-csi-driver-operator library-go #85

Merged
merged 1 commit into from Jul 4, 2023

Conversation

Phaow
Copy link
Contributor

@Phaow Phaow commented Jun 28, 2023

Bump library-go

The library-go fix openshift/library-go/pull/1541 merged we also need to bump the library-go dependency for csi drivers operators.

$ go get -u github.com/openshift/library-go
go: downloading github.com/spf13/cobra v1.6.1
go: upgraded github.com/openshift/api v0.0.0-20230509100629-894b49f57a15 => v0.0.0-20230613151523-ba04973d3ed1
go: upgraded github.com/openshift/library-go v0.0.0-20230508110756-9b7abe2c9cbf => v0.0.0-20230626162119-954ade536d6d
go: upgraded github.com/spf13/cobra v1.6.0 => v1.6.1
$ go mod tidy && go mod vendor 

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jun 28, 2023
@openshift-ci-robot
Copy link
Contributor

@Phaow: This pull request references Jira Issue OCPBUGS-14824, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @Phaow

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bump library-go

The library-go fix openshift/library-go/pull/1541 merged we also need to bump the library-go dependency for csi drivers operators.

$ go get -u github.com/openshift/library-go
go: downloading github.com/spf13/cobra v1.6.1
go: upgraded github.com/openshift/api v0.0.0-20230509100629-894b49f57a15 => v0.0.0-20230613151523-ba04973d3ed1
go: upgraded github.com/openshift/library-go v0.0.0-20230508110756-9b7abe2c9cbf => v0.0.0-20230626162119-954ade536d6d
go: upgraded github.com/spf13/cobra v1.6.0 => v1.6.1
$ go mod tidy && go mod vendor 

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 28, 2023

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: Phaow.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@Phaow: This pull request references Jira Issue OCPBUGS-14824, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @Phaow

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bump library-go

The library-go fix openshift/library-go/pull/1541 merged we also need to bump the library-go dependency for csi drivers operators.

$ go get -u github.com/openshift/library-go
go: downloading github.com/spf13/cobra v1.6.1
go: upgraded github.com/openshift/api v0.0.0-20230509100629-894b49f57a15 => v0.0.0-20230613151523-ba04973d3ed1
go: upgraded github.com/openshift/library-go v0.0.0-20230508110756-9b7abe2c9cbf => v0.0.0-20230626162119-954ade536d6d
go: upgraded github.com/spf13/cobra v1.6.0 => v1.6.1
$ go mod tidy && go mod vendor 

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Phaow
Copy link
Contributor Author

Phaow commented Jun 28, 2023

/retest-required

@Phaow
Copy link
Contributor Author

Phaow commented Jun 29, 2023

/test e2e-azurestack-csi

1 similar comment
@mpatlasov
Copy link
Contributor

/test e2e-azurestack-csi

@mpatlasov
Copy link
Contributor

/lgtm
/label docs-approved
/label px-approved

@openshift-ci openshift-ci bot added docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR labels Jun 29, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 29, 2023
@mpatlasov
Copy link
Contributor

/test e2e-azurestack-csi

@gnufied
Copy link
Member

gnufied commented Jun 30, 2023

/lgtm
/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gnufied, Phaow

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 09e2b6c and 2 for PR HEAD 6730c77 in total

@mpatlasov
Copy link
Contributor

/test e2e-azurestack-csi
/test e2e-azure-csi-extended

1 similar comment
@mpatlasov
Copy link
Contributor

/test e2e-azurestack-csi
/test e2e-azure-csi-extended

@Phaow
Copy link
Contributor Author

Phaow commented Jul 4, 2023

/retest-required

@Phaow
Copy link
Contributor Author

Phaow commented Jul 4, 2023

/retest-required

1 similar comment
@Phaow
Copy link
Contributor Author

Phaow commented Jul 4, 2023

/retest-required

@openshift-merge-robot openshift-merge-robot merged commit 4827bf1 into openshift:master Jul 4, 2023
6 of 8 checks passed
@openshift-ci-robot
Copy link
Contributor

@Phaow: Jira Issue OCPBUGS-14824: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-14824 has been moved to the MODIFIED state.

In response to this:

Bump library-go

The library-go fix openshift/library-go/pull/1541 merged we also need to bump the library-go dependency for csi drivers operators.

$ go get -u github.com/openshift/library-go
go: downloading github.com/spf13/cobra v1.6.1
go: upgraded github.com/openshift/api v0.0.0-20230509100629-894b49f57a15 => v0.0.0-20230613151523-ba04973d3ed1
go: upgraded github.com/openshift/library-go v0.0.0-20230508110756-9b7abe2c9cbf => v0.0.0-20230626162119-954ade536d6d
go: upgraded github.com/spf13/cobra v1.6.0 => v1.6.1
$ go mod tidy && go mod vendor 

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 4, 2023

@Phaow: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azurestack-csi 6730c77 link false /test e2e-azurestack-csi

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants