STOR-1433: Restart azure-disk-csi-driver-controller Pods if metrics-serving-cert changed

[Phaow]

STOR-1433: Restart azure-disk-csi-driver-controller Pods if metrics-serving-cert changed

• Adding WithSecretHashAnnotationHook() for azure-disk-csi-driver-controller ensures that new annotation is published in azure-disk-csi-driver-controller deployment. This, in turn, leads to controller pods restart.

[openshift-ci-robot]

@Phaow: This pull request references STOR-1433 which is a valid jira issue.

In response to this:

STOR-1433: Restart azure-disk-csi-driver-controller Pods if metrics-serving-cert changed

• Adding WithSecretHashAnnotationHook() for azure-disk-csi-driver-controller ensures that new annotation is published in azure-disk-csi-driver-controller deployment. This, in turn, leads to controller pods restart.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@Phaow: This pull request references STOR-1433 which is a valid jira issue.

In response to this:

STOR-1433: Restart azure-disk-csi-driver-controller Pods if metrics-serving-cert changed

• Adding WithSecretHashAnnotationHook() for azure-disk-csi-driver-controller ensures that new annotation is published in azure-disk-csi-driver-controller deployment. This, in turn, leads to controller pods restart.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[mpatlasov]

/assign @mpatlasov

[Phaow]

/test e2e-azure

[mpatlasov]

@Phaow , please remove that redundant line in .WithCSIDriverNodeService(...). Other than that, the PR looks fine.

[Phaow]

@Phaow , please remove that redundant line in .WithCSIDriverNodeService(...). Other than that, the PR looks fine.

Sure, updated, thank you!

[Phaow]

/label tide/merge-method-squash

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mpatlasov, Phaow

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [mpatlasov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mpatlasov]

/label docs-approved
/label px-approved
/lgtm
/approved

[Phaow]

/retest-required

[openshift-ci]

@Phaow: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-azure-csi-extended	682453a	link	false	/test e2e-azure-csi-extended
ci/prow/e2e-azurestack-csi	682453a	link	false	/test e2e-azurestack-csi

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[Phaow]

Pre verifiy passed with the pre merged build 4.14.0-0.ci.test-2023-08-07-014130-ci-ln-mnc9yfk-latest

# After the metrics-serving-cert secret changed, driver controller restarted
$ oc delete secret/azure-disk-csi-driver-controller-metrics-serving-cert
secret "azure-disk-csi-driver-controller-metrics-serving-cert" deleted

$ oc get po
NAME                                                READY   STATUS            RESTARTS   AGE
azure-disk-csi-driver-controller-765c59bd87-brntd   11/11   Running           0          10s
azure-disk-csi-driver-controller-765c59bd87-lbvcx   0/11    PodInitializing   0          4s
azure-disk-csi-driver-node-47ckd                    3/3     Running           0          5h20m
azure-disk-csi-driver-node-hztpn                    3/3     Running           0          5h20m
azure-disk-csi-driver-node-jf22m                    3/3     Running           0          5h20m
azure-disk-csi-driver-node-jxjkk                    3/3     Running           0          5h7m
azure-disk-csi-driver-node-n26ws                    3/3     Running           0          5h7m
azure-disk-csi-driver-node-t7sgw                    3/3     Running           0          5h7m
azure-disk-csi-driver-operator-648d5bbc45-7gllj     1/1     Running           0          5h20m
azure-file-csi-driver-controller-8558659fd6-gxtsc   9/9     Running           0          5h19m
azure-file-csi-driver-controller-8558659fd6-mb9gv   9/9     Running           0          5h20m
azure-file-csi-driver-node-2b84z                    3/3     Running           0          5h7m
azure-file-csi-driver-node-6qgd7                    3/3     Running           0          5h20m
azure-file-csi-driver-node-pdp76                    3/3     Running           0          5h7m
azure-file-csi-driver-node-rgtxt                    3/3     Running           0          5h7m
azure-file-csi-driver-node-thprg                    3/3     Running           0          5h20m
azure-file-csi-driver-node-zt84z                    3/3     Running           0          5h20m
azure-file-csi-driver-operator-5648bb47cd-n9xth     1/1     Running           0          5h20m

$ oc get po -l app=azure-disk-csi-driver-controller
NAME                                                READY   STATUS    RESTARTS   AGE
azure-disk-csi-driver-controller-765c59bd87-brntd   11/11   Running   0          7m31s
azure-disk-csi-driver-controller-765c59bd87-lbvcx   11/11   Running   0          7m25s

[Phaow]

/label qe-approved